On Wed, 18 Jan 2023 19:35:08 GMT, Xue-Lei Andrew Fan wrote:
> This PR is mainly focus on the hotspot, except two test files for jdk
> management.
I would suggest leaving those two management files for the serviceability PR.
-
PR: https://git.openjdk.org/jdk/pull/11935
On Wed, 18 Jan 2023 19:41:11 GMT, Xue-Lei Andrew Fan wrote:
>> The sprintf is deprecated in Xcode 14 because of security concerns. The
>> issue was addressed in
>> [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) for hotspot impl,
>> and [JDK-8299378](https://bugs.openjdk.org/browse/
On Wed, 18 Jan 2023 18:25:15 GMT, Roman Kennke wrote:
> This apparently slipped my testing because the test requires vm.flagless, but
> I would run it with TEST_VM_OPTS="-XX:+UnlockExperimentalVMOptions
> -XX:+UseFastLocking".
You need to test this by having it enabled by default, otherwise y
On Thu, 19 Jan 2023 01:04:39 GMT, Chris Plummer wrote:
>> src/jdk.jdi/share/classes/com/sun/tools/jdi/VMState.java line 177:
>>
>>> 175: private void removeUnreachableListeners() {
>>> 176: boolean found = false;
>>> 177: while (listenersReferenceQueue.poll() != null) {
>>
>
On Thu, 19 Jan 2023 00:46:22 GMT, Jaikiran Pai wrote:
>> Fix JDI leak when the debuggee creates a lot of threads, while at the same
>> the debugger is not sending any commands. The lack of commands being sent
>> results in code not being triggered that normally would clear out
>> unreachable l
On Wed, 18 Jan 2023 20:06:33 GMT, Chris Plummer wrote:
> Fix JDI leak when the debuggee creates a lot of threads, while at the same
> the debugger is not sending any commands. The lack of commands being sent
> results in code not being triggered that normally would clear out unreachable
> list
On Wed, 18 Jan 2023 20:30:47 GMT, Alan Bateman wrote:
> Maybe you've tried this already but if listeners were changed to be a
> WeakHashMap then this would expunge the stable entries.
> This would also avoid the O(n) search in removeUnreachableListeners and
> simplify many other operations. Bu
On Wed, 18 Jan 2023 20:06:33 GMT, Chris Plummer wrote:
> Fix JDI leak when the debuggee creates a lot of threads, while at the same
> the debugger is not sending any commands. The lack of commands being sent
> results in code not being triggered that normally would clear out unreachable
> list
Fix JDI leak when the debuggee creates a lot of threads, while at the same the
debugger is not sending any commands. The lack of commands being sent results
in code not being triggered that normally would clear out unreachable listeners
and also clear out ObjectReferences queued for disposal.
-
On Wed, 18 Jan 2023 19:45:55 GMT, Chris Plummer wrote:
>> I can see both styles are used in this file. The current code here uses 8
>> whitespaces indent, I would like to keep it.
>
> I scanned the first 1000 lines and saw many cases of multi-line argument
> passing, and they all indent as Dav
> The sprintf is deprecated in Xcode 14 because of security concerns. The issue
> was addressed in [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812)
> for hotspot impl, and
> [JDK-8299378](https://bugs.openjdk.org/browse/JDK-8299378) for building, but
> the test case was not covered. T
On Wed, 18 Jan 2023 00:37:05 GMT, Joe Darcy wrote:
> Use new javadoc capabilities courtesy JDK-8200337 to have
> more-readable-in-javadoc-source links to anchors in several management types.
> Analogous change is out for review in core libs, JDK-8300133.
This pull request has now been integrat
> This change adds a fast-locking scheme as an alternative to the current
> stack-locking implementation. It retains the advantages of stack-locking
> (namely fast locking in uncontended code-paths), while avoiding the overload
> of the mark word. That overloading causes massive problems with Li
On Wed, 18 Jan 2023 19:13:41 GMT, Joe Darcy wrote:
>> Use new javadoc capabilities courtesy JDK-8200337 to have
>> more-readable-in-javadoc-source links to anchors in several management
>> types. Analogous change is out for review in core libs, JDK-8300133.
>
> Joe Darcy has updated the pull re
On Wed, 18 Jan 2023 19:28:42 GMT, Xue-Lei Andrew Fan wrote:
>> I think the other acceptable approach is to put the first argument on the
>> 2nd line, and then indent all the argument lines by 8. That works well if
>> the first argument would otherwise start too far to the right. For the
>> abo
On Tue, 17 Jan 2023 01:36:43 GMT, David Holmes wrote:
> I would suggest constraining this PR to src/hotspot and test/hotspot and deal
> with the JDK serviceability files in a different PR (and there may be other
> JDK files impacted too).
I agreed. This PR is mainly focus on the hotspot, exce
> The sprintf is deprecated in Xcode 14 because of security concerns. The issue
> was addressed in [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812)
> for hotspot impl, and
> [JDK-8299378](https://bugs.openjdk.org/browse/JDK-8299378) for building, but
> the test case was not covered. T
On Tue, 17 Jan 2023 01:34:49 GMT, David Holmes wrote:
>> Xue-Lei Andrew Fan has updated the pull request with a new target base due
>> to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull request contains six
>> additional co
On Tue, 17 Jan 2023 20:50:26 GMT, Chris Plummer wrote:
>> src/hotspot/os/windows/os_windows.cpp line 387:
>>
>>> 385: os::snprintf_checked(buf, sizeof(buf), "%s%s;%s%s%s",
>>> 386: Arguments::get_java_home(), EXT_DIR,
>>> 387: path, PACKAGE_DIR, EXT_DIR);
>>
>> When
On Wed, 18 Jan 2023 12:22:01 GMT, Daniel Fuchs wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Improve link target per code review comments.
>
> src/java.management/share/classes/javax/management/remote/JMXConnectorFa
> Use new javadoc capabilities courtesy JDK-8200337 to have
> more-readable-in-javadoc-source links to anchors in several management types.
> Analogous change is out for review in core libs, JDK-8300133.
Joe Darcy has updated the pull request incrementally with one additional commit
since the l
On Wed, 18 Jan 2023 18:59:33 GMT, Joe Darcy wrote:
>> Use new javadoc capabilities courtesy JDK-8200337 to have
>> more-readable-in-javadoc-source links to anchors in several management
>> types. Analogous change is out for review in core libs, JDK-8300133.
>
> Joe Darcy has updated the pull re
> Use new javadoc capabilities courtesy JDK-8200337 to have
> more-readable-in-javadoc-source links to anchors in several management types.
> Analogous change is out for review in core libs, JDK-8300133.
Joe Darcy has updated the pull request incrementally with one additional commit
since the l
On Wed, 18 Jan 2023 07:32:15 GMT, Alan Bateman wrote:
>> Use new javadoc capabilities courtesy JDK-8200337 to have
>> more-readable-in-javadoc-source links to anchors in several management
>> types. Analogous change is out for review in core libs, JDK-8300133.
>
> src/java.management/share/clas
On Wed, 18 Jan 2023 17:52:24 GMT, Robbin Ehn wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Properly set ZF on anon-check path; avoid some conditional branches
>
> So far so good. If this passes I'll do some stres
> This change adds a fast-locking scheme as an alternative to the current
> stack-locking implementation. It retains the advantages of stack-locking
> (namely fast locking in uncontended code-paths), while avoiding the overload
> of the mark word. That overloading causes massive problems with Li
On Wed, 18 Jan 2023 17:56:43 GMT, Kevin Walls wrote:
>> The default setting for the ObjectInputFilter for JMX, introduced in jdk20,
>> is too restrictive.
>> javax.management.Attribute and AttributeList classes are also needed, and
>> Query related classes.
>>
>> There are a number of Query-re
> The default setting for the ObjectInputFilter for JMX, introduced in jdk20,
> is too restrictive.
> javax.management.Attribute and AttributeList classes are also needed, and
> Query related classes.
>
> There are a number of Query-relate classes, so adding javax.management.* is
> appropriate
On Wed, 18 Jan 2023 15:45:38 GMT, Roman Kennke wrote:
>> This change adds a fast-locking scheme as an alternative to the current
>> stack-locking implementation. It retains the advantages of stack-locking
>> (namely fast locking in uncontended code-paths), while avoiding the overload
>> of the
On Wed, 18 Jan 2023 15:46:22 GMT, Fredrik Bredberg wrote:
>> The code uses &sp()[R12_scratch2]. I think your comment is confusing. Please
>> remove it or write something comprehensive. E.g. save R18_locals in
>> compressed format relative to the new top frame's FP (= current SP).
>
> See what y
On Wed, 18 Jan 2023 05:07:38 GMT, Martin Doerr wrote:
>> My intention was to show how the contents of R18_locals (the absolute
>> address to locals) can be recreated by using R12_scratch2 as an index from
>> the frame pointer. Before we stored R18_locals in the stackframe, now we
>> store R12_
On Wed, 18 Jan 2023 14:57:33 GMT, Robbin Ehn wrote:
> Here are some tests that seems provide some reproducability (mac/linux
> aarch64): runtime/handshake/HandshakeDirectTest.java
> vmTestbase/gc/gctests/ObjectMonitorCleanup/ObjectMonitorCleanup.java (crashes
> in
> AccessInternal::PostRuntim
> This change adds a fast-locking scheme as an alternative to the current
> stack-locking implementation. It retains the advantages of stack-locking
> (namely fast locking in uncontended code-paths), while avoiding the overload
> of the mark word. That overloading causes massive problems with Li
On Tue, 17 Jan 2023 08:35:45 GMT, Fredrik Bredberg wrote:
>> Implementation of relativized locals in interpreter frames for x86. x64,
>> arm, aarch64, ppc64le and riscv.
>> Not relativized locals on zero and s390 but done some changes to cope with
>> the changed generic code.
>> Tested tier1-ti
On Fri, 28 Oct 2022 20:17:37 GMT, Roman Kennke wrote:
> This change adds a fast-locking scheme as an alternative to the current
> stack-locking implementation. It retains the advantages of stack-locking
> (namely fast locking in uncontended code-paths), while avoiding the overload
> of the mar
On Wed, 18 Jan 2023 13:25:22 GMT, Robbin Ehn wrote:
> Hi Roman, I get this error on aarch64 in random tests:
> ...
Ok, that is ... surprising! I'll re-run tests on aarch64. Meanwhile, can you
let me know what exactly you have run to get these failures?
Thank you!
Roman
-
PR: http
On Fri, 28 Oct 2022 20:17:37 GMT, Roman Kennke wrote:
> This change adds a fast-locking scheme as an alternative to the current
> stack-locking implementation. It retains the advantages of stack-locking
> (namely fast locking in uncontended code-paths), while avoiding the overload
> of the mar
On Tue, 22 Nov 2022 14:48:11 GMT, Afshin Zafari wrote:
> test of tier1-5 passed.
This pull request has now been integrated.
Changeset: c464ef1d
Author:Afshin Zafari
Committer: Robbin Ehn
URL:
https://git.openjdk.org/jdk/commit/c464ef1d61c2ea4a37759546f0ee39b1f530ccdc
Stats: 291
On Wed, 18 Jan 2023 00:37:05 GMT, Joe Darcy wrote:
> Use new javadoc capabilities courtesy JDK-8200337 to have
> more-readable-in-javadoc-source links to anchors in several management types.
> Analogous change is out for review in core libs, JDK-8300133.
src/java.management/share/classes/javax
On Tue, 17 Jan 2023 08:35:45 GMT, Fredrik Bredberg wrote:
>> Implementation of relativized locals in interpreter frames for x86. x64,
>> arm, aarch64, ppc64le and riscv.
>> Not relativized locals on zero and s390 but done some changes to cope with
>> the changed generic code.
>> Tested tier1-ti
On Tue, 17 Jan 2023 17:34:53 GMT, Andrew Haley wrote:
> > Implementation of relativized locals in interpreter frames for x86. x64,
> > arm, aarch64, ppc64le and riscv. Not relativized locals on zero and s390
> > but done some changes to cope with the changed generic code. Tested
> > tier1-tier
41 matches
Mail list logo
