Re: RFR: 8308237: add JDWP and JDI virtual thread support for ThreadReference.PopFrames [v2]

2023-05-19 Thread Serguei Spitsyn
On Wed, 17 May 2023 20:27:07 GMT, Chris Plummer wrote: >> This is a follow-on to >> [JDK-8264699](https://bugs.openjdk.org/browse/JDK-8264699) which adds JVMTI >> PopFrames support for virtual thread. For JDWP and JDI this is mostly a spec >> update, although JDI needs minor changes to

Re: RFR: 8308000: add PopFrame support for virtual threads [v7]

2023-05-19 Thread Serguei Spitsyn
On Thu, 18 May 2023 05:57:01 GMT, Serguei Spitsyn wrote: >> This enhancement adds `PopFrame` support for virtual threads. The spec >> defines minimal support that the JVMTI `PopFrame` can be used for a virtual >> thread suspended an an event. >> Actually, the `PopFrame` can supports suspended

Re: RFR: 8308000: add PopFrame support for virtual threads [v8]

2023-05-19 Thread Serguei Spitsyn
> This enhancement adds `PopFrame` support for virtual threads. The spec > defines minimal support that the JVMTI `PopFrame` can be used for a virtual > thread suspended an an event. > Actually, the `PopFrame` can supports suspended and mounted virtual threads. > > CSR (approved):

Re: RFR: 8308400: add ForceEarlyReturn support for virtual threads [v2]

2023-05-19 Thread Serguei Spitsyn
> This enhancement adds ForceEarlyReturnXXX support for virtual threads. The > spec defines minimal support that the JVMTI ForceEarlyReturnXXX can be used > for a virtual thread suspended an an event. > Actually, the ForceEarlyReturnXXX can supports suspended and mounted virtual > threads. > >

RFR: 8308400: add ForceEarlyReturn support for virtual threads

2023-05-19 Thread Serguei Spitsyn
This enhancement adds ForceEarlyReturnXXX support for virtual threads. The spec defines minimal support that the JVMTI ForceEarlyReturnXXX can be used for a virtual thread suspended an an event. Actually, the ForceEarlyReturnXXX can supports suspended and mounted virtual threads. CSR

Re: [External] : Re: New candidate JEP: 451: Prepare to Disallow the Dynamic Loading of Agents

2023-05-19 Thread Ron Pressler
I fully understand why authors of (truly excellent, in your case!) advanced serviceability agents would see any feature that could affect their area of interest as a problem, but you surely understand that our responsibility is toward a far larger ecosystem. Even the ultimate restriction —

Integrated: 8304685: Fix whitespace parsing in libjdwp

2023-05-19 Thread Kevin Walls
On Fri, 12 May 2023 18:32:35 GMT, Kevin Walls wrote: > Problem call to skipWhitespace in dbgsysExec > src/jdk.jdwp.agent/unix/native/libjdwp/exec_md.c:91 > > We call skipWhitespace even when the loop will terminate, should guard > against the last skipWhitespace call on the last iteration. >

Re: RFR: 8304685: Fix whitespace parsing in libjdwp [v2]

2023-05-19 Thread Kevin Walls
On Fri, 12 May 2023 20:29:50 GMT, Kevin Walls wrote: >> Problem call to skipWhitespace in dbgsysExec >> src/jdk.jdwp.agent/unix/native/libjdwp/exec_md.c:91 >> >> We call skipWhitespace even when the loop will terminate, should guard >> against the last skipWhitespace call on the last

Re: New candidate JEP: 451: Prepare to Disallow the Dynamic Loading of Agents

2023-05-19 Thread Andrei Pangin
Hi Ron, I reviewed integrity JEPs once again along with this email thread and I think there are several flaws in the proposal that need to be addressed before implementation. 1. First, the JEP draws equality between an agent and an instrumenting agent, which is not true. Instrumentation

Re: RFR: 8307478: Implementation of Prepare to Restrict The Dynamic Loading of Agents [v4]

2023-05-19 Thread Alan Bateman
> This is the implementation for JEP 451. There are two parts to this: > > 1. A multi-line warning is printed when a JVM TI or Java agent is loaded into > a running VM. For JVM TI, the message is printed to stderr from > JvmtiAgent::load. For Java agents, it is printed to System.err (as that

Re: RFR: 8308000: add PopFrame support for virtual threads [v7]

2023-05-19 Thread Leonid Mesnik
On Thu, 18 May 2023 05:57:01 GMT, Serguei Spitsyn wrote: >> This enhancement adds `PopFrame` support for virtual threads. The spec >> defines minimal support that the JVMTI `PopFrame` can be used for a virtual >> thread suspended an an event. >> Actually, the `PopFrame` can supports suspended

Re: New candidate JEP: 451: Prepare to Disallow the Dynamic Loading of Agents

2023-05-19 Thread Ron Pressler
Because the discussion of this JEP has veered in many directions, let me summarise where we are: This JEP proposes to emit a suppressible warning when a JVM TI or Java agent is loaded into a JVM sometime after startup through the Attach mechanism. The warning helps make users aware that an

Re: RFR: 8304074: [JMX] Add an approximation of total bytes allocated on the Java heap by the JVM [v22]

2023-05-19 Thread Paul Hohensee
On Fri, 19 May 2023 03:08:40 GMT, David Holmes wrote: >> Paul Hohensee has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8304074: Need acquire/release in incr_exited_allocated_bytes > > src/hotspot/share/services/threadService.hpp line

Re: RFR: 8304074: [JMX] Add an approximation of total bytes allocated on the Java heap by the JVM [v23]

2023-05-19 Thread Paul Hohensee
> Please review this addition to com.sun.management.ThreadMXBean that returns > the total number of bytes allocated on the Java heap since JVM launch by both > terminated and live threads. > > Because this PR adds a new interface method, I've updated the JMM_VERSION to > 4, but would be happy

Re: RFR: 8308237: add JDWP and JDI virtual thread support for ThreadReference.PopFrames [v2]

2023-05-19 Thread Alan Bateman
On Wed, 17 May 2023 20:27:07 GMT, Chris Plummer wrote: >> This is a follow-on to >> [JDK-8264699](https://bugs.openjdk.org/browse/JDK-8264699) which adds JVMTI >> PopFrames support for virtual thread. For JDWP and JDI this is mostly a spec >> update, although JDI needs minor changes to