Re: RFR: 8304074: [JMX] Add an approximation of total bytes allocated on the Java heap by the JVM [v24]

2023-05-25 Thread David Holmes
On Wed, 24 May 2023 16:36:05 GMT, Paul Hohensee wrote: >> Paul Hohensee has updated the pull request incrementally with 63 additional >> commits since the last revision: >> >> - 8304074: Change UnsupportedOperationException in javadoc comment to >> {@code UnsupportedOperationException} >> -

Re: RFR: 8304074: [JMX] Add an approximation of total bytes allocated on the Java heap by the JVM [v23]

2023-05-25 Thread Kevin Walls
On Tue, 23 May 2023 02:29:19 GMT, David Holmes wrote: >> Paul Hohensee has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8304074: atomic load needed in exited_allocated_bytes > > src/hotspot/share/services/management.cpp line 2104: > >> 2

RFR: JDK-8308288: Fix xlc17 clang warnings in shared code

2023-05-25 Thread JoKern65
When using the new xlc17 compiler (based on a recent clang) to build OpenJDk on AIX , we run into various "warnings as errors". Some of those are in shared codebase and could be addressed by small adjustments. A lot of those changes are in hotspot, some might be somewhere else in the OpenJDK C/C

Re: RFR: 8308655: Narrow types of ConstantPool and ConstMethod returns [v3]

2023-05-25 Thread Coleen Phillimore
On Wed, 24 May 2023 20:14:14 GMT, Coleen Phillimore wrote: >> This change uses a number of ways to eliminate -Wconversion warnings in the >> metadata files in the oops directory. >> >> 1. narrow return types to u2 if the accessor is for a field or value that's >> u2 (u2 is most common for con

Integrated: 8308655: Narrow types of ConstantPool and ConstMethod returns

2023-05-25 Thread Coleen Phillimore
On Tue, 23 May 2023 01:18:07 GMT, Coleen Phillimore wrote: > This change uses a number of ways to eliminate -Wconversion warnings in the > metadata files in the oops directory. > > 1. narrow return types to u2 if the accessor is for a field or value that's > u2 (u2 is most common for constMet

Re: RFR: JDK-8308288: Fix xlc17 clang warnings in shared code

2023-05-25 Thread Matthias Baesken
On Thu, 25 May 2023 09:14:14 GMT, JoKern65 wrote: > When using the new xlc17 compiler (based on a recent clang) to build OpenJDk > on AIX , we run into various "warnings as errors". > Some of those are in shared codebase and could be addressed by small > adjustments. > A lot of those changes ar

Re: RFR: 8304074: [JMX] Add an approximation of total bytes allocated on the Java heap by the JVM [v26]

2023-05-25 Thread Paul Hohensee
On Wed, 24 May 2023 16:50:55 GMT, Paul Hohensee wrote: >> Please review this addition to com.sun.management.ThreadMXBean that returns >> the total number of bytes allocated on the Java heap since JVM launch by >> both terminated and live threads. >> >> Because this PR adds a new interface meth

RFR: 8308814: extend SetLocalXXX minimal support for virtual threads

2023-05-25 Thread Serguei Spitsyn
Currently, the `SetLocalXXX` minimal support for virtual threads is defined for a virtual threads suspended at a breakpoint or single step event. This enhancement is to extend to virtual threads suspended any event. This make `SetLocalXXX` spec consistent with specs of the `StopThread`, `PopFram

Re: RFR: JDK-8308288: Fix xlc17 clang warnings in shared code

2023-05-25 Thread Kim Barrett
On Thu, 25 May 2023 09:14:14 GMT, JoKern65 wrote: > When using the new xlc17 compiler (based on a recent clang) to build OpenJDk > on AIX , we run into various "warnings as errors". > Some of those are in shared codebase and could be addressed by small > adjustments. > A lot of those changes ar

Re: RFR: JDK-8308288: Fix xlc17 clang warnings in shared code

2023-05-25 Thread JoKern65
On Thu, 25 May 2023 15:18:41 GMT, Kim Barrett wrote: >> When using the new xlc17 compiler (based on a recent clang) to build OpenJDk >> on AIX , we run into various "warnings as errors". >> Some of those are in shared codebase and could be addressed by small >> adjustments. >> A lot of those ch

Re: RFR: 8304074: [JMX] Add an approximation of total bytes allocated on the Java heap by the JVM [v23]

2023-05-25 Thread Mandy Chung
On Wed, 24 May 2023 16:50:59 GMT, Paul Hohensee wrote: >> test/jdk/com/sun/management/ThreadMXBean/ThreadAllocatedMemory.java line 160: >> >>> 158: try { >>> 159: curThread.join(); >>> 160: } catch (InterruptedException e) { >> >> should it just let `InterruptedExcep

Re: Proposal: Add overwrite heapdump flag to java

2023-05-25 Thread daniel . daugherty
Greetings, A similar request came up on the hotspot-dev alias back in 2022.11: https://mail.openjdk.org/pipermail/hotspot-dev/2022-November/066956.html Dan On 5/25/23 1:48 AM, David Holmes wrote: Hi Elon, I would suggest taking this up on serviceability-dev - cc'd. On 25/05/2023 3:46 am, E

Re: Proposal: Add overwrite heapdump flag to java

2023-05-25 Thread Elon Azoulay
Hi David, I will go through the guide and create the issues and requests, much appreciated! Thanks so much for all the info! Cheers On Wed, May 24, 2023 at 10:49 PM David Holmes wrote: > Hi Elon, > > I would suggest taking this up on serviceability-dev - cc'd. > > On 25/05/2023 3:46 am, Elon A

Re: Proposal: Add overwrite heapdump flag to java

2023-05-25 Thread Elon Azoulay
Hi Dan, That's great! Should I follow up in that thread as well? On Thu, May 25, 2023 at 12:04 PM wrote: > Greetings, > > A similar request came up on the hotspot-dev alias back in 2022.11: > > https://mail.openjdk.org/pipermail/hotspot-dev/2022-November/066956.html > > Dan > > > On 5/25/23 1:4

Re: [External] : Re: Proposal: Add overwrite heapdump flag to java

2023-05-25 Thread daniel . daugherty
Pointing the older thread to this newer incarnation would be a good idea. Dan On 5/25/23 3:11 PM, Elon Azoulay wrote: Hi Dan, That's great! Should I follow up in that thread as well? On Thu, May 25, 2023 at 12:04 PM wrote: Greetings, A similar request came up on the hotspot-dev al

Re: RFR: JDK-8308288: Fix xlc17 clang warnings in shared code

2023-05-25 Thread Martin Doerr
On Thu, 25 May 2023 15:04:32 GMT, Kim Barrett wrote: >> When using the new xlc17 compiler (based on a recent clang) to build OpenJDk >> on AIX , we run into various "warnings as errors". >> Some of those are in shared codebase and could be addressed by small >> adjustments. >> A lot of those ch

Re: [External] : Re: Proposal: Add overwrite heapdump flag to java

2023-05-25 Thread Elon Azoulay
Sounds good, thanks so much! On Thu, May 25, 2023 at 12:13 PM wrote: > Pointing the older thread to this newer incarnation would be a good idea. > > Dan > > > On 5/25/23 3:11 PM, Elon Azoulay wrote: > > Hi Dan, > That's great! Should I follow up in that thread as well? > > > On Thu, May 25, 2023

Re: RFR: 8304074: [JMX] Add an approximation of total bytes allocated on the Java heap by the JVM [v26]

2023-05-25 Thread David Holmes
On Wed, 24 May 2023 16:50:55 GMT, Paul Hohensee wrote: >> Please review this addition to com.sun.management.ThreadMXBean that returns >> the total number of bytes allocated on the Java heap since JVM launch by >> both terminated and live threads. >> >> Because this PR adds a new interface meth

Re: RFR: 8304074: [JMX] Add an approximation of total bytes allocated on the Java heap by the JVM [v26]

2023-05-25 Thread David Holmes
On Wed, 24 May 2023 16:50:55 GMT, Paul Hohensee wrote: >> Please review this addition to com.sun.management.ThreadMXBean that returns >> the total number of bytes allocated on the Java heap since JVM launch by >> both terminated and live threads. >> >> Because this PR adds a new interface meth

RFR: 8308819: add JDWP and JDI virtual thread support for ThreadReference.ForceEarlyReturn

2023-05-25 Thread Chris Plummer
Improve ThreadReference.ForceEarlyReturn to support virtual threads as long as they are suspended and mounted. [JDK-8308400](https://bugs.openjdk.org/browse/JDK-8308400) improved JVMTI ForceEarlyReturn support for virtual threads. The spec now says it is supported if the thread is suspended at

RE: [External] : Re: Proposal: Add overwrite heapdump flag to java

2023-05-25 Thread Kevin Walls
Hi, (I put this in the PR, but maybe drafts don’t get updates put on the mailing list?) HeapDumpOverwrite sounds quite general, there are different ways of heap dumping and this doesn't affect all of them. This could be HeapDumpOnOutOfMemoryErrorOverwrite, which is a long option even for us 8-)