On Thu, 22 Jun 2023 15:37:11 GMT, Ashutosh Mehra wrote:
>> Please review this PR that extends SA to write BootstrapMethods attribute
>> when dumping the class files.
>>
>> Tested it by dumping the class file for java/lang/String and comparing the
>> BootstrapMethods attribute shown by javap fo
On Mon, 26 Jun 2023 13:17:25 GMT, Doug Simon wrote:
>> The VMSupport class is required for translating an exception between the
>> HotSpot and libgraal heaps.
>> Loading it lazily can result in a loading exception, obscuring the exception
>> being translated.
>> To avoid this, VMSupport is load
On Mon, 26 Jun 2023 21:56:21 GMT, David Holmes wrote:
> I would think it is likely to fail with OOME under the same GC stress test
> conditions.
>
> But if this is just a stress test issue then bailing out when the loading
> fails would be far simpler than pre-loading the class. You've added t
On Mon, 26 Jun 2023 21:47:08 GMT, Doug Simon wrote:
> I doubt VMSupport. would ever fail in practice.
I would think it is likely to fail with OOME under the same GC stress test
conditions.
But if this is just a stress test issue then bailing out when the loading fails
would be far simpler th
On Mon, 26 Jun 2023 21:41:25 GMT, David Holmes wrote:
> Then why did you not simply handle the exception from the loading of
> VMSupport the same way?
The only actual case seen of the original way failing is due to OOME in GC
stress tests. If loading of VMSupport is done during VM startup, the
On Mon, 26 Jun 2023 13:06:46 GMT, Doug Simon wrote:
> That's fine - if VMSupport fails class initialization, then no "rich"
> decoding can occur (by definition) and so throwing the clinit error is the
> best we can do.
Then why did you not simply handle the exception from the loading of VMSupp
On Mon, 26 Jun 2023 17:47:25 GMT, Coleen Phillimore wrote:
> More casts for size of address differences in same code space,
> checked_casts<> and type changes to fix -Wconversion warnings. See CR for
> details.
> Tested with tier1-4.
After some offline conversation with Ioi, we thought of a b
On Mon, 26 Jun 2023 17:47:25 GMT, Coleen Phillimore wrote:
> More casts for size of address differences in same code space,
> checked_casts<> and type changes to fix -Wconversion warnings. See CR for
> details.
> Tested with tier1-4.
This pull request has been closed without being integrated.
On Mon, 26 Jun 2023 20:19:47 GMT, Frederic Parain wrote:
>> More casts for size of address differences in same code space,
>> checked_casts<> and type changes to fix -Wconversion warnings. See CR for
>> details.
>> Tested with tier1-4.
>
> src/hotspot/cpu/aarch64/continuationFreezeThaw_aarch64
On Fri, 23 Jun 2023 01:57:56 GMT, Alex Menkov wrote:
> This is follow-up JDK-8307153/JDK-8309612 (JVMTI GetThreadState on carrier
> should return STATE_WAITING)
> New test tests GetThreadState for different thread states.
> The test detected a bug in the implementation, new issue is created:
>
On Mon, 26 Jun 2023 17:47:25 GMT, Coleen Phillimore wrote:
> More casts for size of address differences in same code space,
> checked_casts<> and type changes to fix -Wconversion warnings. See CR for
> details.
> Tested with tier1-4.
Changes requested by fparain (Reviewer).
src/hotspot/cpu/a
On Fri, 23 Jun 2023 22:59:54 GMT, Alex Menkov wrote:
> Trivial fix in JVMTI spec.
> As it's just a typo, CSR is not required
Marked as reviewed by cjplummer (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/14634#pullrequestreview-1499146614
> This is a minor fix to core file reading on macos x. I can confirm that
> after this fix I can run the problem listed SA core file tests on Ventura.
Tom Rodriguez has updated the pull request incrementally with one additional
commit since the last revision:
Update copyright
-
More casts for size of address differences in same code space, checked_casts<>
and type changes to fix -Wconversion warnings. See CR for details.
Tested with tier1-4.
-
Commit messages:
- Fix -Wconversion warnings in runtime, oops and some code header files.
Changes: https://git.o
On Thu, 22 Jun 2023 11:51:15 GMT, Matthias Baesken wrote:
>> Currently, a number of tests fail on macOS because they miss the core file
>> (e.g. serviceability/sa/TestJmapCore.java).
>> The reason is that configure detects on some setups that codesign does not
>> work ("checking if debug mode c
On Mon, 26 Jun 2023 17:02:22 GMT, Tom Rodriguez wrote:
>> This is a minor fix to core file reading on macos x. I can confirm that
>> after this fix I can run the problem listed SA core file tests on Ventura.
>
> Tom Rodriguez has updated the pull request incrementally with one additional
> com
On Mon, 26 Jun 2023 05:06:13 GMT, Chris Plummer wrote:
>> Tom Rodriguez has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Flatten nested ifs
>> - Adjust ordering of message
>> - Adjust printing
>
> src/jdk.hotspot.agent/macosx/native
> This is a minor fix to core file reading on macos x. I can confirm that
> after this fix I can run the problem listed SA core file tests on Ventura.
Tom Rodriguez has updated the pull request incrementally with one additional
commit since the last revision:
Adjust for review
-
On Mon, 26 Jun 2023 13:17:25 GMT, Doug Simon wrote:
>> The VMSupport class is required for translating an exception between the
>> HotSpot and libgraal heaps.
>> Loading it lazily can result in a loading exception, obscuring the exception
>> being translated.
>> To avoid this, VMSupport is load
On Mon, 26 Jun 2023 13:17:25 GMT, Doug Simon wrote:
>> The VMSupport class is required for translating an exception between the
>> HotSpot and libgraal heaps.
>> Loading it lazily can result in a loading exception, obscuring the exception
>> being translated.
>> To avoid this, VMSupport is load
> The VMSupport class is required for translating an exception between the
> HotSpot and libgraal heaps.
> Loading it lazily can result in a loading exception, obscuring the exception
> being translated.
> To avoid this, VMSupport is loaded eagerly along with the other vmClasses.
Doug Simon has
On Mon, 26 Jun 2023 07:59:17 GMT, David Holmes wrote:
> if the first decode encounters a class initialization error then it will just
> return with the exception pending and no decoding will actually have occurred
That's fine - if VMSupport fails class initialization, then no "rich" decoding
c
> The VMSupport class is required for translating an exception between the
> HotSpot and libgraal heaps.
> Loading it lazily can result in a loading exception, obscuring the exception
> being translated.
> To avoid this, VMSupport is loaded eagerly along with the other vmClasses.
Doug Simon has
On Sat, 24 Jun 2023 06:47:48 GMT, Vladimir Sitnikov
wrote:
> I've posted the suggetion to add .editorconfig on ide-support-dev, however,
> the list does not seem to be active:
> https://mail.openjdk.org/pipermail/ide-support-dev/2023-June/000281.html
I think that sounds like a reasonable idea
On Fri, 23 Jun 2023 18:10:59 GMT, Kevin Walls wrote:
> Simple typo in a signature which is passed to JNU_NewObjectByName. The
> method clearly intentds to pass Float, but uses Double.
>
> This code is probably not invoked, unless there is a GC MXBean with such
> fields. I see no straightforw
On Fri, 23 Jun 2023 18:10:59 GMT, Kevin Walls wrote:
> Simple typo in a signature which is passed to JNU_NewObjectByName. The
> method clearly intentds to pass Float, but uses Double.
>
> This code is probably not invoked, unless there is a GC MXBean with such
> fields. I see no straightforw
On Sun, 25 Jun 2023 06:58:14 GMT, Doug Simon wrote:
> The VMSupport class is required for translating an exception between the
> HotSpot and libgraal heaps.
> Loading it lazily can result in a loading exception, obscuring the exception
> being translated.
> To avoid this, VMSupport is loaded ea
On Mon, 26 Jun 2023 07:46:38 GMT, Doug Simon wrote:
> The usages of `vmSupport` below all use `JavaCalls:call_static` which takes
> care of linking and initializing the class.
Sure but my point is that initialization can fail and the code does not seem to
directly take that into account - if t
On Mon, 26 Jun 2023 07:42:48 GMT, David Holmes wrote:
> The eager loading seems reasonable, but I do not understand the details here.
> In what way was loading failing? You still have to initialize `VMSupport`
> before you can call methods on it, so that could also fail - though the code
> doe
On Sun, 25 Jun 2023 06:58:14 GMT, Doug Simon wrote:
> The VMSupport class is required for translating an exception between the
> HotSpot and libgraal heaps.
> Loading it lazily can result in a loading exception, obscuring the exception
> being translated.
> To avoid this, VMSupport is loaded ea
30 matches
Mail list logo
