Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v24]

2023-09-21 Thread David Holmes
On Fri, 22 Sep 2023 00:11:19 GMT, Man Cao wrote: >> src/hotspot/share/gc/shared/collectedHeap.cpp line 161: >> >>> 159: } >>> 160: >>> 161: void CollectedHeap::inc_total_cpu_time(long diff) { >> >> We don't use `long` in shared code as it has different size on different >> platforms. > > Usin

Re: RFR: 8314029: Add file name parameter to Compiler.perfmap

2023-09-21 Thread David Holmes
On Thu, 21 Sep 2023 20:43:56 GMT, Yi-Fan Tsai wrote: > `jcmd Compiler.perfmap` uses the hard-coded file name for a perf map: > `/tmp/perf-%d.map`. This change adds an option for specifying a file name. > > The help message of Compiler.perfmap: > > Compiler.perfmap > Write map file for Linux pe

Re: RFR: 8299915: Remove ArrayAllocatorMallocLimit and associated code

2023-09-21 Thread David Holmes
On Thu, 21 Sep 2023 12:02:24 GMT, Afshin Zafari wrote: > 1. `ArrayAllocatorMallocLimit` is removed. The test cases that tested it also > are removed. > 2. `AllocArrayAllocator` instances are replaced with `MallocArrayAllocator`. > 3. The signature of `CHeapBitMap::free(ptr, size)` is kept as it

Re: RFR: JDK-8313804: JDWP support for -Djava.net.preferIPv6Addresses=system [v8]

2023-09-21 Thread Alex Menkov
On Fri, 22 Sep 2023 00:01:58 GMT, Liam Miller-Cushon wrote: >> Please consider this fix for >> [JDK-8313804](https://bugs.openjdk.org/browse/JDK-8313804), which adds >> support to JDWP for `-Djava.net.preferIPv6Addresses=system`. Previously it >> only handled `-Djava.net.preferIPv6Addresses=tr

Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v24]

2023-09-21 Thread Man Cao
On Wed, 20 Sep 2023 00:39:44 GMT, David Holmes wrote: >> Jonathan Joo has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix build issues > > src/hotspot/share/gc/shared/collectedHeap.cpp line 161: > >> 159: } >> 160: >> 161: void Collect

Re: RFR: JDK-8313804: JDWP support for -Djava.net.preferIPv6Addresses=system [v7]

2023-09-21 Thread Liam Miller-Cushon
On Thu, 21 Sep 2023 20:28:02 GMT, Alex Menkov wrote: >> Liam Miller-Cushon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add more test cases > > test/jdk/com/sun/jdi/JdwpNetProps.java line 89: > >> 87: .preferIPv4S

Re: RFR: JDK-8313804: JDWP support for -Djava.net.preferIPv6Addresses=system [v8]

2023-09-21 Thread Liam Miller-Cushon
> Please consider this fix for > [JDK-8313804](https://bugs.openjdk.org/browse/JDK-8313804), which adds > support to JDWP for `-Djava.net.preferIPv6Addresses=system`. Previously it > only handled `-Djava.net.preferIPv6Addresses=true` and > `-Djava.net.preferIPv6Addresses=false`. Liam Miller-Cu

Integrated: JDK-8315486: vmTestbase/nsk/jdwp/ThreadReference/ForceEarlyReturn/forceEarlyReturn002/forceEarlyReturn002.java timed out

2023-09-21 Thread Alex Menkov
On Wed, 6 Sep 2023 20:02:44 GMT, Alex Menkov wrote: > To test ForceEarlyReturn command for NO_MORE_FRAMES case the test creates > ThreadStartEventRequest with SUSPEND_ALL policy and requests debuggee to > start new thread. > If debuggee JVM starts some internal threads before the request is cle

RFR: 8304839: Move TestScaffold.main() to the separate class DebugeeWrapper

2023-09-21 Thread Leonid Mesnik
The code related to virtual threads support is moved into a separate class DebugeeWrapper. The code of method main() remains the same. I don't mix code change with moving code between files. Tesed by running make run-test JTREG_RETAIN=all TEST=com/sun/jdi make run-test JTREG_RETAIN=all JTREG

Integrated: 8316695: ProblemList serviceability/jvmti/RedefineClasses/RedefineLeakThrowable.java

2023-09-21 Thread Daniel D . Daugherty
On Thu, 21 Sep 2023 20:39:32 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > serviceability/jvmti/RedefineClasses/RedefineLeakThrowable.java > on all platforms. It's a new test and we already have 8 failure sightings in > the JDK22 CI. This pull request has now been integrate

Re: Integrated: 8316695: ProblemList serviceability/jvmti/RedefineClasses/RedefineLeakThrowable.java

2023-09-21 Thread Daniel D . Daugherty
On Thu, 21 Sep 2023 20:39:32 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > serviceability/jvmti/RedefineClasses/RedefineLeakThrowable.java > on all platforms. It's a new test and we already have 8 failure sightings in > the JDK22 CI. Not sure why the bot hasn't marked this

Re: Integrated: 8316695: ProblemList serviceability/jvmti/RedefineClasses/RedefineLeakThrowable.java

2023-09-21 Thread Daniel D . Daugherty
On Thu, 21 Sep 2023 20:42:51 GMT, Calvin Cheung wrote: >> A trivial fix to ProblemList >> serviceability/jvmti/RedefineClasses/RedefineLeakThrowable.java >> on all platforms. It's a new test and we already have 8 failure sightings in >> the JDK22 CI. > > Looks good and trivial. @calvinccheung

Re: Integrated: 8316695: ProblemList serviceability/jvmti/RedefineClasses/RedefineLeakThrowable.java

2023-09-21 Thread Calvin Cheung
On Thu, 21 Sep 2023 20:39:32 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > serviceability/jvmti/RedefineClasses/RedefineLeakThrowable.java > on all platforms. It's a new test and we already have 8 failure sightings in > the JDK22 CI. Looks good and trivial. -

Re: Integrated: 8316695: ProblemList serviceability/jvmti/RedefineClasses/RedefineLeakThrowable.java

2023-09-21 Thread Kim Barrett
On Thu, 21 Sep 2023 20:39:32 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > serviceability/jvmti/RedefineClasses/RedefineLeakThrowable.java > on all platforms. It's a new test and we already have 8 failure sightings in > the JDK22 CI. Looks good. - Marked as re

Integrated: 8316695: ProblemList serviceability/jvmti/RedefineClasses/RedefineLeakThrowable.java

2023-09-21 Thread Daniel D . Daugherty
A trivial fix to ProblemList serviceability/jvmti/RedefineClasses/RedefineLeakThrowable.java on all platforms. It's a new test and we already have 8 failure sightings in the JDK22 CI. - Commit messages: - 8316695: ProblemList serviceability/jvmti/RedefineClasses/RedefineLeakThrowa

RFR: 8314029: Add file name parameter to Compiler.perfmap

2023-09-21 Thread Yi-Fan Tsai
`jcmd Compiler.perfmap` uses the hard-coded file name for a perf map: `/tmp/perf-%d.map`. This change adds an option for specifying a file name. The help message of Compiler.perfmap: Compiler.perfmap Write map file for Linux perf tool. Impact: Low Syntax : Compiler.perfmap [options] Options:

Re: RFR: JDK-8313804: JDWP support for -Djava.net.preferIPv6Addresses=system [v7]

2023-09-21 Thread Alex Menkov
On Thu, 21 Sep 2023 00:49:45 GMT, Liam Miller-Cushon wrote: >> Please consider this fix for >> [JDK-8313804](https://bugs.openjdk.org/browse/JDK-8313804), which adds >> support to JDWP for `-Djava.net.preferIPv6Addresses=system`. Previously it >> only handled `-Djava.net.preferIPv6Addresses=tr

Re: RFR: JDK-8313804: JDWP support for -Djava.net.preferIPv6Addresses=system [v7]

2023-09-21 Thread Alex Menkov
On Thu, 21 Sep 2023 00:49:45 GMT, Liam Miller-Cushon wrote: >> Please consider this fix for >> [JDK-8313804](https://bugs.openjdk.org/browse/JDK-8313804), which adds >> support to JDWP for `-Djava.net.preferIPv6Addresses=system`. Previously it >> only handled `-Djava.net.preferIPv6Addresses=tr

RFR: JDK-8316691: Heap dump: separate stack traces for mounted virtual threads

2023-09-21 Thread Alex Menkov
This is subtask of JDK-8299426: Heap dump does not contain virtual Thread stack references The change: - reorganize thread-related code/prepare it to use for unmounted vthreads; - separate track traces for mounted virtual threads: - separate HPROF_FRAME/HPROF_TRACE records for mounted vthreads a

Re: RFR: 8316417: ObjectMonitorIterator does not return the most recent monitor and is incorrect if no monitors exists [v6]

2023-09-21 Thread Chris Plummer
On Thu, 21 Sep 2023 06:21:13 GMT, Axel Boldt-Christmas wrote: >> `inUseList` will end up with the same value as `inUseListHead`. The reason >> the old code worked is because `getAddressField` does not type check and >> `reinterpret_cast(&ObjectSynchronizer::_in_use_list) == >> reinterpret_cas

Re: RFR: 8316417: ObjectMonitorIterator does not return the most recent monitor and is incorrect if no monitors exists [v6]

2023-09-21 Thread Chris Plummer
On Thu, 21 Sep 2023 06:21:25 GMT, Axel Boldt-Christmas wrote: >> ObjectMonitorIterator fails to return the most resent monitor added. It >> start with returning the `nextOM()` ObjectMonitor from the `_head` >> ObjectMonitor but fails to ever return the `_head` ObjectMonitor. >> The current imp

Re: RFR: 8315966: Relativize initial_sp in interpreter frames

2023-09-21 Thread Fei Yang
On Wed, 20 Sep 2023 08:52:09 GMT, Fei Yang wrote: > Hi, I have arranged tier1-3 test on linux-riscv64 platform. Thanks for adding > handling for riscv. Tier1-3 test is clean. The riscv part looks good except for the nit. - PR Comment: https://git.openjdk.org/jdk/pull/15815#issueco

RFR: 8299915: Remove ArrayAllocatorMallocLimit and associated code

2023-09-21 Thread Afshin Zafari
1. `ArrayAllocatorMallocLimit` is removed. The test cases that tested it also are removed. 2. `AllocArrayAllocator` instances are replaced with `MallocArrayAllocator`. 3. The signature of `CHeapBitMap::free(ptr, size)` is kept as it is, since it is called in this way from `GrowableBitMap::resize`

Re: RFR: 8294977: Convert test/jdk/java tests from ASM library to Classfile API [v9]

2023-09-21 Thread Adam Sotona
On Wed, 28 Jun 2023 07:02:17 GMT, Chen Liang wrote: >> Summaries: >> 1. A few recommendations about updating the constant API is made at >> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-March/000233.html >> and I may update this patch shall the API changes be integrated before >> 2.