On Thu, 21 Sep 2023 00:49:45 GMT, Liam Miller-Cushon <cus...@openjdk.org> wrote:
>> Please consider this fix for >> [JDK-8313804](https://bugs.openjdk.org/browse/JDK-8313804), which adds >> support to JDWP for `-Djava.net.preferIPv6Addresses=system`. Previously it >> only handled `-Djava.net.preferIPv6Addresses=true` and >> `-Djava.net.preferIPv6Addresses=false`. > > Liam Miller-Cushon has updated the pull request incrementally with one > additional commit since the last revision: > > Add more test cases test/jdk/com/sun/jdi/JdwpNetProps.java line 133: > 131: .run(TestResult.ListenFailed); > 132: new ListenTest("localhost", ipv6Address) > 133: .run(TestResult.ListenFailed); this is IPv6-only system and testcase tries to attach from IPv6 address. It should succeed. test/jdk/com/sun/jdi/JdwpNetProps.java line 136: > 134: new ListenTest("localhost", ipv6Address) > 135: .preferIPv6Addresses("system") > 136: .run(systemPrefersIPv6 ? TestResult.Success : > TestResult.AttachFailed); this is IPv6-only system, so systemPrefersIPv6 cannot be false ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15796#discussion_r1333580132 PR Review Comment: https://git.openjdk.org/jdk/pull/15796#discussion_r1333581171
