On Thu, 9 Nov 2023 07:26:46 GMT, David Holmes wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix another windows error
>
> src/hotspot/share/services/diagnosticCommand.cpp line 1159:
>
>> 1157: }
>> 1158:
>>
On Thu, 2 Nov 2023 17:42:29 GMT, Thomas Stuefe wrote:
>> Analysts and supporters often use /proc/xx/maps to make sense of the memory
>> footprint of a process.
>>
>> Interpreting the memory map correctly can help when used as a complement to
>> other tools (e.g. NMT). There even exist tools
On Thu, 9 Nov 2023 07:03:34 GMT, David Holmes wrote:
> > > > As this adds a JCmd, doesn't this need both a CSR and a manual entry?
> > >
> > >
> > > ```
> > > * CSR: not sure; there are precedences for going with CSR and without
> > > CSR. Since we get awfully close to JDK22 freeze, I would
On Wed, 8 Nov 2023 11:40:35 GMT, Johan Sjölen wrote:
> > > As this adds a JCmd, doesn't this need both a CSR and a manual entry?
> >
> >
> > ```
> > * CSR: not sure; there are precedences for going with CSR and without CSR.
> > Since we get awfully close to JDK22 freeze, I would prefer for a
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request incrementally with one additional
commit since the last revision:
Add missing cpuTimeCounters files
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15082/files
-
On Wed, 8 Nov 2023 19:00:53 GMT, Roman Kennke wrote:
> See JBS issue for details.
>
> I basically:
> - took the test-modification and turned it into its own test-case
> - added test runners for lightweight- and legacy-locking, so that we keep
> testing both, no matter what is the default
>
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request incrementally with one additional
commit since the last revision:
Refactor changes to counters, successful build
-
Changes:
- all:
On Wed, 8 Nov 2023 14:37:29 GMT, Matthias Baesken wrote:
> In parseAllowedMask (file socketTransport.c) , prefixLen of mask is compared
> with a maxValue (32 for IPv4, 128 otherwise). This fails on AIX if it is
> larger than 32, because getaddrinfo seems to often (always ?) detect IPv4
>
See JBS issue for details.
I basically:
- took the test-modification and turned it into its own test-case
- added test runners for lightweight- and legacy-locking, so that we keep
testing both, no matter what is the default
- added Axels fix (mentioned in the JBS issue) with the modification
On Wed, 8 Nov 2023 14:37:29 GMT, Matthias Baesken wrote:
> In parseAllowedMask (file socketTransport.c) , prefixLen of mask is compared
> with a maxValue (32 for IPv4, 128 otherwise). This fails on AIX if it is
> larger than 32, because getaddrinfo seems to often (always ?) detect IPv4
>
On Wed, 8 Nov 2023 10:51:19 GMT, Albert Mingkun Yang wrote:
> Simple cleanup of removing an unnecessary indirection. The real change is
> only 11 LOC, using the global variables directly for young/old gen.
SA changes look good.
-
Marked as reviewed by cjplummer (Reviewer).
PR
On Wed, 8 Nov 2023 08:29:52 GMT, Matthias Baesken wrote:
> On AIX the test
> test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineLeakThrowable.java
> runs into this error:
>
> java.lang.RuntimeException: java.lang.OutOfMemoryError: Metaspace
> at
>
On Tue, 7 Nov 2023 14:44:52 GMT, Patricio Chilano Mateo
wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: get rid of the VM_HandshakeUnmountedVirtualThread
>
> src/hotspot/share/prims/jvmtiEnvBase.cpp
On Tue, 7 Nov 2023 14:23:34 GMT, Patricio Chilano Mateo
wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: get rid of the VM_HandshakeUnmountedVirtualThread
>
> src/hotspot/share/prims/jvmtiEnvBase.cpp
On Tue, 7 Nov 2023 14:54:05 GMT, Patricio Chilano Mateo
wrote:
> Hi Serguei,
> Looks good to me, nice code consolidation.
Hi Patricio, thank you a lot for reviewing this!
> src/hotspot/share/prims/jvmtiEnvBase.cpp line 1978:
>
>> 1976: }
>> 1977: if (target_jt == nullptr) {//
On Tue, 7 Nov 2023 18:12:45 GMT, Roman Kennke wrote:
>> See JBS issue for details.
>>
>> Testing:
>> - [x] gc/logging/TestUnifiedLoggingSwitchStress.java -XX:+UseParallelGC
>> - [x] tier1 -XX:+UseParallelGC
>> - [x] tier2 -XX:+UseParallelGC
>> - [x] hotspot_gc
>
> Roman Kennke has updated
On Fri, 3 Nov 2023 12:42:46 GMT, Roman Kennke wrote:
> See JBS issue for details.
>
> Testing:
> - [x] gc/logging/TestUnifiedLoggingSwitchStress.java -XX:+UseParallelGC
> - [x] tier1 -XX:+UseParallelGC
> - [x] tier2 -XX:+UseParallelGC
> - [x] hotspot_gc
This pull request has now been
On Fri, 3 Nov 2023 14:14:36 GMT, Albert Mingkun Yang wrote:
>> Parsing the separate components is easier :) Not sure if these tags in any
>> way ever indicated some level of abstraction.
>>
>> I do not have a strong opinion here. The combinations
>>
>> (Pinned)
>> (Allocation Failure)
>>
In parseAllowedMask (file socketTransport.c) , prefixLen of mask is compared
with a maxValue (32 for IPv4, 128 otherwise). This fails on AIX if it is larger
than 32, because getaddrinfo seems to often (always ?) detect IPv4 family, even
for IPv6 addresses, so we take the wrong maxValue.
On Wed, 8 Nov 2023 08:29:52 GMT, Matthias Baesken wrote:
> On AIX the test
> test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineLeakThrowable.java
> runs into this error:
>
> java.lang.RuntimeException: java.lang.OutOfMemoryError: Metaspace
> at
>
On Tue, 7 Nov 2023 18:12:45 GMT, Roman Kennke wrote:
>> See JBS issue for details.
>>
>> Testing:
>> - [x] gc/logging/TestUnifiedLoggingSwitchStress.java -XX:+UseParallelGC
>> - [x] tier1 -XX:+UseParallelGC
>> - [x] tier2 -XX:+UseParallelGC
>> - [x] hotspot_gc
>
> Roman Kennke has updated
On Wed, 8 Nov 2023 11:24:43 GMT, Thomas Stuefe wrote:
> > As this adds a JCmd, doesn't this need both a CSR and a manual entry?
>
> * CSR: not sure; there are precedences for going with CSR and without
> CSR. Since we get awfully close to JDK22 freeze, I would prefer for a CSR not
> to be
On Wed, 8 Nov 2023 09:51:12 GMT, Johan Sjölen wrote:
> As this adds a JCmd, doesn't this need both a CSR and a manual entry?
- CSR: not sure; there are precedences for going with CSR and without CSR.
Since we get awfully close to JDK22 freeze, I would prefer for a CSR not to be
needed. Also
Simple cleanup of removing an unnecessary indirection. The real change is only
11 LOC, using the global variables directly for young/old gen.
-
Commit messages:
- s1-remove-gen-spec
Changes: https://git.openjdk.org/jdk/pull/16554/files
Webrev:
On Thu, 2 Nov 2023 17:42:29 GMT, Thomas Stuefe wrote:
>> Analysts and supporters often use /proc/xx/maps to make sense of the memory
>> footprint of a process.
>>
>> Interpreting the memory map correctly can help when used as a complement to
>> other tools (e.g. NMT). There even exist tools
On AIX the test
test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineLeakThrowable.java
runs into this error:
java.lang.RuntimeException: java.lang.OutOfMemoryError: Metaspace
at
jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.invocationHelper(JavacTaskImpl.java:168)
at
26 matches
Mail list logo
