On Tue, 7 Nov 2023 14:54:05 GMT, Patricio Chilano Mateo
<[email protected]> wrote:
> Hi Serguei,
> Looks good to me, nice code consolidation.
Hi Patricio, thank you a lot for reviewing this!
> src/hotspot/share/prims/jvmtiEnvBase.cpp line 1978:
>
>> 1976: }
>> 1977: if (target_jt == nullptr) { // unmounted virtual thread
>> 1978: hs_cl->do_vthread(target_h); // execute handshake closure
>> callback on current thread directly
>
> I think comment should be: s/current thread/unmounted vthread
Thank you for the comment but I'm not sure what do you mean.
If target virtual thread is unmounted we execute the hs_cl callback on current
thread.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/16460#issuecomment-1802188368
PR Review Comment: https://git.openjdk.org/jdk/pull/16460#discussion_r1386857320
