On Fri, 15 Dec 2023 06:22:39 GMT, Thomas Stuefe wrote:
>> Joachim Kern has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> followed the proposals
>
> src/hotspot/os/aix/os_aix.cpp line 1129:
>
>> 1127:
>> 1128: // get the library search pa
On Tue, 12 Dec 2023 14:05:48 GMT, Joachim Kern wrote:
>> On AIX, repeated calls to dlopen referring to the same shared library may
>> result in different, unique dl handles to be returned from libc. In that it
>> differs from typical libc implementations that cache dl handles.
>>
>> This cause
On Thu, 14 Dec 2023 10:13:51 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to improve the code
> in `get_user_name_slow` function, which is used to identify the target JVM
> owner's user name? This addresses https://bugs.openjdk.org/browse/JDK-8321971.
>
>
On Thu, 14 Dec 2023 22:35:18 GMT, Serguei Spitsyn wrote:
>> src/java.base/share/classes/java/lang/VirtualThread.java line 1043:
>>
>>> 1041: notifyJvmtiDisableSuspend(true);
>>> 1042: try {
>>> 1043: // include the carrier thread state and name when
>>> m
> This fix is for JDK 23 but the intention is to back port it to 22 in RDP-1
> time frame.
> It is fixing a deadlock issue between `VirtualThread` class critical sections
> with the `interruptLock` (in methods: `unpark()`, `interrupt()`,
> `getAndClearInterrupt()`, `threadState()`, `toString()`)
On Thu, 14 Dec 2023 19:50:00 GMT, Alan Bateman wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: moved notifyJvmtiDisableSuspend(true) out of try-block
>
> src/java.base/share/classes/java/lang/VirtualThre
On Thu, 14 Dec 2023 05:46:01 GMT, David Holmes wrote:
> Updated the version to 23-ea and year to 2024.
>
> This initial generation also picks up the unpublished changes from:
>
> - [JDK-8302233](https://bugs.openjdk.org/browse/JDK-8302233) (keytool &
> jarsigner)
> - [JDK-8290702](https://bugs
On Thu, 14 Dec 2023 18:26:55 GMT, Serguei Spitsyn wrote:
>> This fix is for JDK 23 but the intention is to back port it to 22 in RDP-1
>> time frame.
>> It is fixing a deadlock issue between `VirtualThread` class critical
>> sections with the `interruptLock` (in methods: `unpark()`, `interrupt(
On Thu, 14 Dec 2023 18:24:16 GMT, Serguei Spitsyn wrote:
> Thank you, Alan. Fixed now. I believe, all your suggestions have been
> addressed now.
Thanks, it looks much better now.
-
PR Comment: https://git.openjdk.org/jdk/pull/17011#issuecomment-1856485757
On Thu, 14 Dec 2023 18:03:00 GMT, Alan Bateman wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: 1) replace CriticalLock with DisableSuspend; 2) minor tweaks
>
> src/java.base/share/classes/java/lang/Virtu
On Thu, 14 Dec 2023 18:04:02 GMT, Alan Bateman wrote:
> Okay with me. We'll need to move the notifyJvmtiDisableSuspend(true) to
> before the try in all cases, I've pointed out the cases that we missed.
Thank you, Alan. Fixed now.
-
PR Comment: https://git.openjdk.org/jdk/pull/1701
On Thu, 14 Dec 2023 12:16:34 GMT, Serguei Spitsyn wrote:
>> src/hotspot/share/runtime/javaThread.hpp line 320:
>>
>>> 318: bool _is_in_VTMS_transition; // thread is
>>> in virtual thread mount state transition
>>> 319: bool _is_in_tmp_VTMS_transiti
> This fix is for JDK 23 but the intention is to back port it to 22 in RDP-1
> time frame.
> It is fixing a deadlock issue between `VirtualThread` class critical sections
> with the `interruptLock` (in methods: `unpark()`, `interrupt()`,
> `getAndClearInterrupt()`, `threadState()`, `toString()`)
On Thu, 14 Dec 2023 17:30:54 GMT, Serguei Spitsyn wrote:
>> This fix is for JDK 23 but the intention is to back port it to 22 in RDP-1
>> time frame.
>> It is fixing a deadlock issue between `VirtualThread` class critical
>> sections with the `interruptLock` (in methods: `unpark()`, `interrupt(
On Thu, 14 Dec 2023 12:19:43 GMT, Alan Bateman wrote:
> Okay. What about the Leonid's suggestion to name it
> `notifyJvmtiDisableSuspend()` ?
Okay with me. We'll need to move the notifyJvmtiDisableSuspend(true) to before
the try in all cases, I've pointed out the cases that we missed.
---
On Thu, 14 Dec 2023 17:06:05 GMT, Alan Bateman wrote:
>> Implemented this renaming suggestion. Let's wait if Alan ia okay with it.
>
>> Implemented this renaming suggestion. Let's wait if Alan ia okay with it.
>
> Are you planning to drop the changes to mount/unmount too? They shouldn't be
> ne
> This fix is for JDK 23 but the intention is to back port it to 22 in RDP-1
> time frame.
> It is fixing a deadlock issue between `VirtualThread` class critical sections
> with the `interruptLock` (in methods: `unpark()`, `interrupt()`,
> `getAndClearInterrupt()`, `threadState()`, `toString()`)
On Thu, 14 Dec 2023 16:57:25 GMT, Serguei Spitsyn wrote:
> Implemented this renaming suggestion. Let's wait if Alan ia okay with it.
Are you planning to drop the changes to mount/unmount too? They shouldn't be
needed.
notifyJvmtiCriticalLock(boolean) is okay for now but needs to be called befo
On Thu, 14 Dec 2023 12:11:42 GMT, Serguei Spitsyn wrote:
>> src/java.base/share/classes/java/lang/VirtualThread.java line 1164:
>>
>>> 1162:
>>> 1163: @IntrinsicCandidate
>>> 1164: private native void notifyJvmtiCriticalLock(boolean enter);
>>
>> The name is confusing to me, the Critic
On Tue, 5 Dec 2023 13:48:11 GMT, Thomas Stuefe wrote:
>> Joachim Kern has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> encapsulate everything in os::Aix::dlopen
>
> Excellent, this is how I have pictured a good solution. Very nice.
>
> A
> Compiler Control (https://openjdk.org/jeps/165) provides method-context
> dependent control of the JVM compilers (C1 and C2). The active directive
> stack is built from the directive files passed with the
> `-XX:CompilerDirectivesFile` diagnostic command-line option and the
> Compiler.add_dir
> Updated the version to 23-ea and year to 2024.
>
> This initial generation also picks up the unpublished changes from:
>
> - [JDK-8302233](https://bugs.openjdk.org/browse/JDK-8302233) (keytool &
> jarsigner)
> - [JDK-8290702](https://bugs.openjdk.org/browse/JDK-8290702) (javadoc) (JDK
> 23 ba
On Thu, 14 Dec 2023 09:01:17 GMT, Alan Bateman wrote:
> Initially I wondered if JDK-8309981 should be separated but include keeps
> things in sync so I think okay.
Thanks for the review @AlanBateman .
Yeah I was in two minds there myself. I started fixing
[JDK-8309981](https://bugs.openjdk.or
On Thu, 14 Dec 2023 09:17:05 GMT, Pavel Rappo wrote:
> Thanks for doing this, David. I only note that the changes for JDK-8321384
> were published in [JDK-8308715](https://bugs.openjdk.org/browse/JDK-8308715),
> which was integrated in the mainline before JDK 22 RDP 1. So they are already
> pr
On Thu, 14 Dec 2023 12:06:41 GMT, Serguei Spitsyn wrote:
> Carrier thread also can be suspended when executing the "critical code". Why
> do you think it can't be a problem? Do you think the deadlocking scenario
> described in the bug report is not possible?
It's a different scenario. When mou
On Tue, 12 Dec 2023 23:54:43 GMT, Leonid Mesnik wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: (1) rename notifyJvmti method; (2) add try-final statements to
>> VirtualThread methods
>
> src/hotspot/sh
On Tue, 12 Dec 2023 23:42:07 GMT, Leonid Mesnik wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: (1) rename notifyJvmti method; (2) add try-final statements to
>> VirtualThread methods
>
> src/java.base/
On Fri, 8 Dec 2023 11:54:40 GMT, Serguei Spitsyn wrote:
>> This fix is for JDK 23 but the intention is to back port it to 22 in RDP-1
>> time frame.
>> It is fixing a deadlock issue between `VirtualThread` class critical
>> sections with the `interruptLock` (in methods: `unpark()`, `interrupt()
On Thu, 14 Dec 2023 05:46:01 GMT, David Holmes wrote:
> Updated the version to 23-ea and year to 2024.
>
> This initial generation also picks up the unpublished changes from:
>
> - [JDK-8302233](https://bugs.openjdk.org/browse/JDK-8302233) (keytool &
> jarsigner)
> - [JDK-8290702](https://bugs
On Thu, 14 Dec 2023 05:46:01 GMT, David Holmes wrote:
> Updated the version to 23-ea and year to 2024.
>
> This initial generation also picks up the unpublished changes from:
>
> - [JDK-8302233](https://bugs.openjdk.org/browse/JDK-8302233) (keytool &
> jarsigner)
> - [JDK-8290702](https://bugs
30 matches
Mail list logo
