Re: RFR: 8322476: Remove GrowableArray C-Heap version, replace usages with GrowableArrayCHeap

2023-12-22 Thread Kim Barrett
[Kim Barret wrote:] >>> pre-existing: There are a lot of non-static class data members that are >>> pointers to >>> GrowableArray that seem like they would be better as direct, e.g. >>> non-pointers. >>> >>> pre-existing: There are a lot of iterations over GrowableArray's that would >>> be >>>

Re: RFR: JDK-8322237: Heap dump contains duplicate thread records for mounted virtual threads [v4]

2023-12-22 Thread Alex Menkov
> HeapDumper dumps virtual threads in 2 places: > - dumping platform threads (mounted virtual threads are dumped as separate > thread object); > - dumping heap objects when the object is `java.lang.VirtualThread`. > > In the 2nd case mounted virtual threads should be skipped (as they are >

Re: RFR: JDK-8320890: [AIX] Find a better way to mimic dl handle equality [v11]

2023-12-22 Thread Joachim Kern
> On AIX, repeated calls to dlopen referring to the same shared library may > result in different, unique dl handles to be returned from libc. In that it > differs from typical libc implementations that cache dl handles. > > This causes problems in the JVM with code that assumes equality of

Re: RFR: JDK-8320890: [AIX] Find a better way to mimic dl handle equality [v10]

2023-12-22 Thread Thomas Stuefe
On Fri, 22 Dec 2023 14:50:16 GMT, Joachim Kern wrote: >> On AIX, repeated calls to dlopen referring to the same shared library may >> result in different, unique dl handles to be returned from libc. In that it >> differs from typical libc implementations that cache dl handles. >> >> This

Re: RFR: JDK-8320890: [AIX] Find a better way to mimic dl handle equality [v10]

2023-12-22 Thread Joachim Kern
> On AIX, repeated calls to dlopen referring to the same shared library may > result in different, unique dl handles to be returned from libc. In that it > differs from typical libc implementations that cache dl handles. > > This causes problems in the JVM with code that assumes equality of

Re: RFR: 8322476: Remove GrowableArray C-Heap version, replace usages with GrowableArrayCHeap

2023-12-22 Thread Emanuel Peter
On Fri, 22 Dec 2023 13:22:19 GMT, Stefan Karlsson wrote: >> pre-existing: There are a lot of non-static class data members that are >> pointers to >> GrowableArray that seem like they would be better as direct, e.g. >> non-pointers. >> >> pre-existing: There are a lot of iterations over

Re: RFR: 8322476: Remove GrowableArray C-Heap version, replace usages with GrowableArrayCHeap

2023-12-22 Thread Stefan Karlsson
On Wed, 20 Dec 2023 21:11:09 GMT, Kim Barrett wrote: > I'm not a fan of the additional clutter in APIs that the static memory types > add. If we had a variant of GrowableArrayCHeap that was not itself > dynamically allocatable and took a memory type to use internally as a > constructor

Re: RFR: JDK-8322237: Heap dump contains duplicate thread records for mounted virtual threads [v3]

2023-12-22 Thread Serguei Spitsyn
On Fri, 22 Dec 2023 01:43:07 GMT, Alex Menkov wrote: >> HeapDumper dumps virtual threads in 2 places: >> - dumping platform threads (mounted virtual threads are dumped as separate >> thread object); >> - dumping heap objects when the object is `java.lang.VirtualThread`. >> >> In the 2nd case

Re: RFR: JDK-8320005 : Allow loading of shared objects with .a extension on AIX [v7]

2023-12-22 Thread Suchismith Roy
On Thu, 21 Dec 2023 10:01:04 GMT, Thomas Stuefe wrote: > > > > > What happens if we accidentally attempt to load a "real" static > > > > > library, which is also named *.a? Would dlopen() then crash? What > > > > > would happen? > > > > > > > > > > I don't think the problem is with *.a .

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v15]

2023-12-22 Thread Dmitry Chuyko
On Wed, 20 Dec 2023 02:57:29 GMT, Andrei Pangin wrote: >> Dmitry Chuyko has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 33 commits: >> >> - Merge branch 'openjdk:master' into compiler-directives-force-update >> - Merge branch

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v19]

2023-12-22 Thread Dmitry Chuyko
> Compiler Control (https://openjdk.org/jeps/165) provides method-context > dependent control of the JVM compilers (C1 and C2). The active directive > stack is built from the directive files passed with the > `-XX:CompilerDirectivesFile` diagnostic command-line option and the >

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v15]

2023-12-22 Thread Dmitry Chuyko
On Wed, 20 Dec 2023 02:40:40 GMT, Andrei Pangin wrote: >> Dmitry Chuyko has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 33 commits: >> >> - Merge branch 'openjdk:master' into compiler-directives-force-update >> - Merge branch