Re: RFR: JDK-8327769: jcmd GC.heap_dump without options should write to location given by -XX:HeapDumpPath, if set [v8]

2024-03-22 Thread Matthias Baesken
On Thu, 21 Mar 2024 16:44:29 GMT, Chris Plummer wrote: > I'd like to consult with a couple of people at Oracle who unfortunately are > out of town until Monday. Can this PR wait until next week? That's fine, no need to rush it into jdk-head this week. - PR Comment: https://git.ope

Re: RFR: 8318026: jcmd should provide access to low-level JVM debug information [v7]

2024-03-22 Thread Kevin Walls
On Tue, 5 Mar 2024 11:31:13 GMT, Kevin Walls wrote: >> Introduce the jcmd "VM.debug" to implement access to a useful set of the >> established debug.cpp utilities, with "jcmd PID VM.debug subcommand ...". >> >> Not recommended for live production use. Calling these "debug" utilities, >> and n

Re: RFR: 8261242: [Linux] OSContainer::is_containerized() returns true when run outside a container

2024-03-22 Thread Severin Gehwolf
On Mon, 11 Mar 2024 16:55:36 GMT, Severin Gehwolf wrote: > Please review this enhancement to the container detection code which allows > it to figure out whether the JVM is actually running inside a container > (`podman`, `docker`, `crio`), or with some other means that enforces > memory/cpu l

Re: RFR: JDK-8328303: 3 JDI tests timed out with UT enabled [v2]

2024-03-22 Thread Alex Menkov
> The change fixes 3 nsk JDI tests. > Root cause in all 3 tests is the same - the tests requests JDI event with > SUSPEND_ALL policy, but event handler thread stops handle incoming event and > this causes debuggee to hang (suspended by JDI event). > > All 3 tests are updated to exit event handle

Re: RFR: JDK-8328303: 3 JDI tests timed out with UT enabled [v2]

2024-03-22 Thread Chris Plummer
On Fri, 22 Mar 2024 19:26:33 GMT, Alex Menkov wrote: >> The change fixes 3 nsk JDI tests. >> Root cause in all 3 tests is the same - the tests requests JDI event with >> SUSPEND_ALL policy, but event handler thread stops handle incoming event and >> this causes debuggee to hang (suspended by JD

Re: RFR: JDK-8328303: 3 JDI tests timed out with UT enabled [v2]

2024-03-22 Thread Serguei Spitsyn
On Fri, 22 Mar 2024 19:26:33 GMT, Alex Menkov wrote: >> The change fixes 3 nsk JDI tests. >> Root cause in all 3 tests is the same - the tests requests JDI event with >> SUSPEND_ALL policy, but event handler thread stops handle incoming event and >> this causes debuggee to hang (suspended by JD

Re: RFR: JDK-8328303: 3 JDI tests timed out with UT enabled [v2]

2024-03-22 Thread Serguei Spitsyn
On Fri, 22 Mar 2024 19:26:33 GMT, Alex Menkov wrote: >> The change fixes 3 nsk JDI tests. >> Root cause in all 3 tests is the same - the tests requests JDI event with >> SUSPEND_ALL policy, but event handler thread stops handle incoming event and >> this causes debuggee to hang (suspended by JD

Re: RFR: JDK-8328303: 3 JDI tests timed out with UT enabled [v2]

2024-03-22 Thread Daniel D . Daugherty
On Fri, 22 Mar 2024 19:26:33 GMT, Alex Menkov wrote: >> The change fixes 3 nsk JDI tests. >> Root cause in all 3 tests is the same - the tests requests JDI event with >> SUSPEND_ALL policy, but event handler thread stops handle incoming event and >> this causes debuggee to hang (suspended by JD

Re: RFR: JDK-8328303: 3 JDI tests timed out with UT enabled [v3]

2024-03-22 Thread Alex Menkov
> The change fixes 3 nsk JDI tests. > Root cause in all 3 tests is the same - the tests requests JDI event with > SUSPEND_ALL policy, but event handler thread stops handle incoming event and > this causes debuggee to hang (suspended by JDI event). > > All 3 tests are updated to exit event handle

Re: RFR: JDK-8328303: 3 JDI tests timed out with UT enabled [v2]

2024-03-22 Thread Alex Menkov
On Fri, 22 Mar 2024 20:31:01 GMT, Serguei Spitsyn wrote: >> Alex Menkov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> feedback > > test/hotspot/jtreg/vmTestbase/nsk/jdi/ClassPrepareEvent/referenceType/refType001.java > line 116: > >>

Re: RFR: JDK-8328303: 3 JDI tests timed out with UT enabled [v2]

2024-03-22 Thread Alex Menkov
On Fri, 22 Mar 2024 20:45:51 GMT, Alex Menkov wrote: >> test/hotspot/jtreg/vmTestbase/nsk/jdi/ClassPrepareEvent/referenceType/refType001.java >> line 116: >> >>> 114: >>> 115: boolean isConnected = true; >>> 116: boolean eventsReceived = false; >> >> Ni

Re: RFR: JDK-8328303: 3 JDI tests timed out with UT enabled [v2]

2024-03-22 Thread Alex Menkov
On Fri, 22 Mar 2024 20:27:31 GMT, Daniel D. Daugherty wrote: >> Alex Menkov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> feedback > > test/hotspot/jtreg/vmTestbase/nsk/jdi/ClassPrepareEvent/referenceType/refType001.java > line 117:

Re: RFR: JDK-8328303: 3 JDI tests timed out with UT enabled [v3]

2024-03-22 Thread Alex Menkov
On Fri, 22 Mar 2024 04:09:28 GMT, Chris Plummer wrote: >> Alex Menkov has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - updated comments >> - eventsReceived -> allEventsReceived > > test/hotspot/jtreg/vmTestbase/nsk/jdi/ClassPrepareEven

Re: RFR: JDK-8328303: 3 JDI tests timed out with UT enabled [v2]

2024-03-22 Thread Alex Menkov
On Fri, 22 Mar 2024 20:39:47 GMT, Serguei Spitsyn wrote: > One more question. Why these tests are failed with the UT enabled? Or maybe > this was wrong assumption? UT can add additional events (ClassPrepareEvent, ThreadDeathEvent). As the event are requested with SUSPEND_ALL policy, debuggee V

Re: RFR: JDK-8328303: 3 JDI tests timed out with UT enabled [v3]

2024-03-22 Thread Alex Menkov
On Fri, 22 Mar 2024 21:29:03 GMT, Alex Menkov wrote: >> The change fixes 3 nsk JDI tests. >> Root cause in all 3 tests is the same - the tests requests JDI event with >> SUSPEND_ALL policy, but event handler thread stops handle incoming event and >> this causes debuggee to hang (suspended by JD

Integrated: JDK-8328303: 3 JDI tests timed out with UT enabled

2024-03-22 Thread Alex Menkov
On Thu, 21 Mar 2024 22:25:23 GMT, Alex Menkov wrote: > The change fixes 3 nsk JDI tests. > Root cause in all 3 tests is the same - the tests requests JDI event with > SUSPEND_ALL policy, but event handler thread stops handle incoming event and > this causes debuggee to hang (suspended by JDI ev

Re: RFR: 8318026: jcmd should provide access to low-level JVM debug information [v7]

2024-03-22 Thread Serguei Spitsyn
On Tue, 5 Mar 2024 11:31:13 GMT, Kevin Walls wrote: >> Introduce the jcmd "VM.debug" to implement access to a useful set of the >> established debug.cpp utilities, with "jcmd PID VM.debug subcommand ...". >> >> Not recommended for live production use. Calling these "debug" utilities, >> and n