On Fri, 22 Mar 2024 19:26:33 GMT, Alex Menkov <amen...@openjdk.org> wrote:
>> The change fixes 3 nsk JDI tests. >> Root cause in all 3 tests is the same - the tests requests JDI event with >> SUSPEND_ALL policy, but event handler thread stops handle incoming event and >> this causes debuggee to hang (suspended by JDI event). >> >> All 3 tests are updated to exit event handler thread after getting >> VMDeathEvent or VMDisconnectEvent (and resume debuggee after any other >> events). >> ClassPrepareEvent tests need to wait some time to allow handle all expected >> events before terminate the debuggee. The logic was implemented by using >> CountDownLatch. >> >> All tests are passed with "--test-repeat 20" > > Alex Menkov has updated the pull request incrementally with one additional > commit since the last revision: > > feedback test/hotspot/jtreg/vmTestbase/nsk/jdi/ClassPrepareEvent/referenceType/refType001.java line 116: > 114: > 115: boolean isConnected = true; > 116: boolean eventsReceived = false; Nit: It'd better to rename this local to `allEventsReceived`. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18442#discussion_r1536178517
