On Tue, 2 Apr 2024 00:40:37 GMT, Alex Menkov wrote:
> The fix updated HeapDumper to always perform merge on the current thread.
>
> Testing: tier1-5, all HeapDump-related tests
> Covered heap dumping scenarios:
> - `jcmd GC.heap_dump` command;
> - `HotSpotDiagnosticMXBean.dumpHeap()`;
On Thu, 4 Apr 2024 12:46:26 GMT, Kevin Walls wrote:
>> Introduce the jcmd "VM.inspect" to implement access to detailed JVM object
>> information.
>>
>> Not recommended for live production use. Requires UnlockDiagnosticVMOptions
>> and not included in jcmd help output, to remind us this is
On Fri, 29 Mar 2024 19:35:45 GMT, Vladimir Kozlov wrote:
> Revert [JDK-8152664](https://bugs.openjdk.org/browse/JDK-8152664) RFE
> [changes](https://github.com/openjdk/jdk/commit/b853eb7f5ca24eeeda18acbb14287f706499c365)
> which was used for AOT [JEP 295](https://openjdk.org/jeps/295)
>
On Thu, 4 Apr 2024 17:31:53 GMT, Stefan Karlsson wrote:
>> Vladimir Kozlov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address next round of comments
>
> Looks good.
Thank you, @stefank, @iwanowww, @dean-long and @xmas92 for
On Thu, 4 Apr 2024 17:04:30 GMT, Vladimir Kozlov wrote:
>> Revert [JDK-8152664](https://bugs.openjdk.org/browse/JDK-8152664) RFE
>> [changes](https://github.com/openjdk/jdk/commit/b853eb7f5ca24eeeda18acbb14287f706499c365)
>> which was used for AOT [JEP 295](https://openjdk.org/jeps/295)
>>
> Revert [JDK-8152664](https://bugs.openjdk.org/browse/JDK-8152664) RFE
> [changes](https://github.com/openjdk/jdk/commit/b853eb7f5ca24eeeda18acbb14287f706499c365)
> which was used for AOT [JEP 295](https://openjdk.org/jeps/295)
> implementation in JDK 9. The code was left in HotSpot assuming
On Thu, 4 Apr 2024 07:54:16 GMT, Stefan Karlsson wrote:
>> Vladimir Kozlov has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>>
On Tue, 27 Feb 2024 10:44:20 GMT, Kevin Walls wrote:
> The deprecated Subject Delegation feature in JMX will be removed.
>
> This was marked in JDK 21 as deprecated for removal (JDK-8298966).
This pull request has now been integrated.
Changeset: 6382a129
Author:Kevin Walls
URL:
On Thu, 4 Apr 2024 16:03:12 GMT, Stefan Karlsson wrote:
>> Quote: "an" goes before words that begin with vowels.
>
> I don't think that holds if the 'n' is pronounced the way nmethod is
> pronounced.
`grep` shows that we have both cases but `an nmethod` is used more.
-
PR Review
On Thu, 4 Apr 2024 16:16:41 GMT, Vladimir Kozlov wrote:
>> I don't think that holds if the 'n' is pronounced the way nmethod is
>> pronounced.
>
> `grep` shows that we have both cases but `an nmethod` is used more.
I will fix it here as you suggested but I am not touching other places.
On Thu, 4 Apr 2024 07:51:47 GMT, Stefan Karlsson wrote:
>> Vladimir Kozlov has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>>
On Thu, 4 Apr 2024 15:56:34 GMT, Vladimir Kozlov wrote:
>> src/hotspot/share/gc/shared/gcBehaviours.hpp line 31:
>>
>>> 29: #include "oops/oopsHierarchy.hpp"
>>> 30:
>>> 31: // This is the behaviour for checking if a nmethod is unloading
>>
>> Maybe this should be *an* nmethod?
>
> Quote:
On Thu, 4 Apr 2024 07:31:24 GMT, Stefan Karlsson wrote:
>> Vladimir Kozlov has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>>
On Thu, 4 Apr 2024 07:26:21 GMT, Stefan Karlsson wrote:
>> Vladimir Kozlov has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>>
The internal JVM TI JvmtiHandshake and JvmtiUnitedHandshakeClosure classes were
introduced in the JDK 22 to unify/simplify the JVM TI functions supporting
implementation of the virtual threads. This enhancement is to refactor the JVM
TI internal functions
On Thu, 4 Apr 2024 12:19:03 GMT, Stefan Karlsson wrote:
>> I'm not even sure what they want to say, really. Should be good to remove,
>> and if anybody can make sense of it, record an issue in the bug-tracker?
>
> OK. I removed the %%%. I'll wait a little bit to see if someone else wants to
>
On Thu, 4 Apr 2024 12:18:24 GMT, Stefan Karlsson wrote:
>> We have a few places that uses the terms `KlassObj` and `klassOop` when
>> referring to Klasses. This is old code from before the PermGen removal, when
>> Klasses also were Java objects.
>>
>> These names tripped me up when I was
On Fri, 29 Mar 2024 15:25:48 GMT, Coleen Phillimore wrote:
> This change simplifies the code that grows the jmethodID cache in
> InstanceKlass. Instead of lazily, when there's a rare request for a
> jmethodID for an obsolete method, the jmethodID cache is grown during the
> RedefineClasses
On Thu, 4 Apr 2024 00:07:34 GMT, Coleen Phillimore wrote:
>> This change simplifies the code that grows the jmethodID cache in
>> InstanceKlass. Instead of lazily, when there's a rare request for a
>> jmethodID for an obsolete method, the jmethodID cache is grown during the
>>
> The deprecated Subject Delegation feature in JMX will be removed.
>
> This was marked in JDK 21 as deprecated for removal (JDK-8298966).
Kevin Walls has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 25 commits:
- Merge
On Wed, 27 Mar 2024 05:26:09 GMT, Chris Plummer wrote:
>> Kevin Walls has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Undo include
>
> src/hotspot/share/utilities/debug.cpp line 680:
>
>> 678:
>> 679: // Additional "good oop" checks,
On Fri, 29 Mar 2024 04:05:53 GMT, Serguei Spitsyn wrote:
>> Kevin Walls has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Test more pointer types: compiled method and metadata.
>
>
> Introduce the jcmd "VM.inspect" to implement access to detailed JVM object
> information.
>
> Not recommended for live production use. Requires UnlockDiagnosticVMOptions
> and not included in jcmd help output, to remind us this is not a
> general-purpose customer-facing tool.
Kevin Walls
On Thu, 4 Apr 2024 12:18:24 GMT, Stefan Karlsson wrote:
>> We have a few places that uses the terms `KlassObj` and `klassOop` when
>> referring to Klasses. This is old code from before the PermGen removal, when
>> Klasses also were Java objects.
>>
>> These names tripped me up when I was
On Thu, 4 Apr 2024 12:13:21 GMT, Roman Kennke wrote:
>> I think it is an old-style TODO. I'm considering if we shouldn't just remove
>> these comments. What do people think about that?
>
> I'm not even sure what they want to say, really. Should be good to remove,
> and if anybody can make
On Thu, 4 Apr 2024 10:07:11 GMT, Roman Kennke wrote:
>> Stefan Karlsson has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review Roman
>
> src/hotspot/share/memory/heapInspection.cpp line 173:
>
>> 171:
On Thu, 4 Apr 2024 12:08:23 GMT, Stefan Karlsson wrote:
>> src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 1202:
>>
>>> 1200: ldrw(scan_temp, Address(recv_klass, Klass::vtable_length_offset()));
>>> 1201:
>>> 1202: // %%% Could store the aligned, prescaled offset in the klassoop.
> We have a few places that uses the terms `KlassObj` and `klassOop` when
> referring to Klasses. This is old code from before the PermGen removal, when
> Klasses also were Java objects.
>
> These names tripped me up when I was reading the heap heapInspection.cpp and
> first though we were
On Thu, 4 Apr 2024 09:55:38 GMT, Roman Kennke wrote:
>> We have a few places that uses the terms `KlassObj` and `klassOop` when
>> referring to Klasses. This is old code from before the PermGen removal, when
>> Klasses also were Java objects.
>>
>> These names tripped me up when I was reading
On Tue, 2 Apr 2024 00:22:28 GMT, Serguei Spitsyn wrote:
> The internal JVM TI `JvmtiHandshake` and `JvmtiUnitedHandshakeClosure`
> classes were introduced in the JDK 22 to unify/simplify the JVM TI functions
> supporting implementation of the virtual threads. This enhancement is to
> refactor
On Thu, 4 Apr 2024 09:45:58 GMT, Stefan Karlsson wrote:
> We have a few places that uses the terms `KlassObj` and `klassOop` when
> referring to Klasses. This is old code from before the PermGen removal, when
> Klasses also were Java objects.
>
> These names tripped me up when I was reading
We have a few places that uses the terms `KlassObj` and `klassOop` when
referring to Klasses. This is old code from before the PermGen removal, when
Klasses also were Java objects.
These names tripped me up when I was reading the heap heapInspection.cpp and
first though we were mixing the
> Introduce the jcmd "VM.inspect" to implement access to detailed JVM object
> information.
>
> Not recommended for live production use. Requires UnlockDiagnosticVMOptions
> and not included in jcmd help output, to remind us this is not a
> general-purpose customer-facing tool.
Kevin Walls
On Thu, 4 Apr 2024 00:05:20 GMT, Vladimir Kozlov wrote:
>> Revert [JDK-8152664](https://bugs.openjdk.org/browse/JDK-8152664) RFE
>> [changes](https://github.com/openjdk/jdk/commit/b853eb7f5ca24eeeda18acbb14287f706499c365)
>> which was used for AOT [JEP 295](https://openjdk.org/jeps/295)
>>
On Thu, 4 Apr 2024 00:05:20 GMT, Vladimir Kozlov wrote:
>> Revert [JDK-8152664](https://bugs.openjdk.org/browse/JDK-8152664) RFE
>> [changes](https://github.com/openjdk/jdk/commit/b853eb7f5ca24eeeda18acbb14287f706499c365)
>> which was used for AOT [JEP 295](https://openjdk.org/jeps/295)
>>
35 matches
Mail list logo
