On Thu, 4 Apr 2024 07:51:47 GMT, Stefan Karlsson <[email protected]> wrote:
>> Vladimir Kozlov has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commits since the last revision:
>>
>> - Address comments
>> - Merge branch 'master' into 8329332
>> - Removed not_used state of nmethod
>> - remove trailing whitespace
>> - 8329332: Remove CompiledMethod and CodeBlobLayout classes
>
> src/hotspot/share/code/codeBlob.hpp line 168:
>
>> 166: bool is_vtable_blob() const { return _kind ==
>> CodeBlobKind::Blob_Vtable; }
>> 167: bool is_method_handles_adapter_blob() const { return _kind ==
>> CodeBlobKind::Blob_MH_Adapter; }
>> 168: bool is_upcall_stub() const { return _kind ==
>> CodeBlobKind::Blob_Upcall; }
>
> The `Blob_` prefix is now redundant since we always have to prefix with
> CodeBlobKind::. Just a suggestion if you want to shorten these.
Good suggestion
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18554#discussion_r1552009581
