Re: RFR: 8330846: Add stacks of mounted virtual threads to the HotSpot thread dump [v18]

2024-06-12 Thread David Holmes
On Wed, 12 Jun 2024 08:45:46 GMT, Inigo Mediavilla Saiz wrote: >> Print the stack traces of mounted virtual threads when calling `jcmd >> Thread.print`. > > Inigo Mediavilla Saiz has updated the pull request incrementally with one > additional commit since the last revision: > > Remove unn

Integrated: 8330846: Add stacks of mounted virtual threads to the HotSpot thread dump

2024-06-12 Thread Inigo Mediavilla Saiz
On Thu, 30 May 2024 14:13:34 GMT, Inigo Mediavilla Saiz wrote: > Print the stack traces of mounted virtual threads when calling `jcmd > Thread.print`. This pull request has now been integrated. Changeset: fcedde80 Author:Inigo Mediavilla Saiz Committer: David Holmes URL: https:/

Re: RFR: 8322811: jcmd System.dump_map help info has conflicting statements

2024-06-12 Thread Chris Plummer
On Tue, 11 Jun 2024 07:45:29 GMT, Kevin Walls wrote: >> src/hotspot/share/services/diagnosticCommand.cpp line 1211: >> >>> 1209: } else { >>> 1210: name = _filename.value(); >>> 1211: } >> >> This code should be considering if a default it specified or not, in case >> the specified val

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v4]

2024-06-12 Thread Damon Nguyen
On Mon, 10 Jun 2024 23:11:04 GMT, Jonathan Gibbons wrote: >> @jonathan-gibbons I just realized that this change to the German file >> matches the file with the Japanese and Chinese localized files. By that I >> mean the "backwards" translations are also present for the Japanese and >> Chinese

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v4]

2024-06-12 Thread Damon Nguyen
> This issue is responsible for updating the translations of all the > localize(able) resources in the JDK. Primarily, the changes between JDK 22 > RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. > > The translation tool adjusted some definitions, which causes some ch

Re: RFR: 8333344: JMX attaching of Subject does not work when security manager not allowed [v3]

2024-06-12 Thread Sean Mullan
On Wed, 12 Jun 2024 14:06:39 GMT, Kevin Walls wrote: >> For the same reason you should be able to just call `Subject.current` in the >> tests. I don't think you need the `SimpleStandard.useGetSubjectACC` property >> to toggle the testing of either old or replacement APIs as long as the test >>

Re: RFR: 8333344: JMX attaching of Subject does not work when security manager not allowed [v6]

2024-06-12 Thread Sean Mullan
On Wed, 12 Jun 2024 16:11:28 GMT, Kevin Walls wrote: >> JMX uses APIs related to the Security Mananger which are deprecated. Use of >> AccessControlContext will be removed when Security Manager is removed. >> >> Until then, updates are needed to not require setting >> -Djava.security.manager

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v3]

2024-06-12 Thread Justin Lu
On Tue, 11 Jun 2024 19:28:27 GMT, Damon Nguyen wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK. Primarily, the changes between JDK 22 >> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. >> >> The tra

Re: RFR: 8333891: Method excluded with directive is not compiled after removal of directive

2024-06-12 Thread Evgeny Astigeevich
On Mon, 10 Jun 2024 20:05:03 GMT, Evgeny Astigeevich wrote: > We can exclude Java methods from compilation with compiler directives. Later > we can remove those directives. > This PR fixes a bug that after removal of those directives Java methods don't > become compilable. > A regression test

Re: RFR: 8333827: JDK 23 RDP1 L10n resource files update [v3]

2024-06-12 Thread Phil Race
On Tue, 11 Jun 2024 19:28:27 GMT, Damon Nguyen wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK. Primarily, the changes between JDK 22 >> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated. >> >> The tra

Re: RFR: 8333344: JMX attaching of Subject does not work when security manager not allowed [v6]

2024-06-12 Thread Daniel Fuchs
On Wed, 12 Jun 2024 16:11:28 GMT, Kevin Walls wrote: >> JMX uses APIs related to the Security Mananger which are deprecated. Use of >> AccessControlContext will be removed when Security Manager is removed. >> >> Until then, updates are needed to not require setting >> -Djava.security.manager

Re: RFR: 8333344: JMX attaching of Subject does not work when security manager not allowed [v4]

2024-06-12 Thread Kevin Walls
On Wed, 12 Jun 2024 14:55:31 GMT, Daniel Fuchs wrote: >> Hmm I may have fixed that since changing the policy files, as I'm not seeing >> the problem without that AuthPermission any more. Am just retesting >> everything before updating this... > > (Same with other policy files in which the perm

Re: RFR: 8333344: JMX attaching of Subject does not work when security manager not allowed [v6]

2024-06-12 Thread Kevin Walls
> JMX uses APIs related to the Security Mananger which are deprecated. Use of > AccessControlContext will be removed when Security Manager is removed. > > Until then, updates are needed to not require setting > -Djava.security.manager=allow to use JMX authentication. Kevin Walls has updated t

Re: RFR: 8333344: JMX attaching of Subject does not work when security manager not allowed [v5]

2024-06-12 Thread Kevin Walls
> JMX uses APIs related to the Security Mananger which are deprecated. Use of > AccessControlContext will be removed when Security Manager is removed. > > Until then, updates are needed to not require setting > -Djava.security.manager=allow to use JMX authentication. Kevin Walls has updated t

Re: RFR: 8333344: JMX attaching of Subject does not work when security manager not allowed [v4]

2024-06-12 Thread Daniel Fuchs
On Wed, 12 Jun 2024 14:44:56 GMT, Kevin Walls wrote: >> I think Daniel is right, can you remove this permission and paste in the >> debug output to see where this is happening? > > Hmm I may have fixed that since changing the policy files, as I'm not seeing > the problem without that AuthPermis

Re: RFR: 8333344: JMX attaching of Subject does not work when security manager not allowed [v4]

2024-06-12 Thread Kevin Walls
On Wed, 12 Jun 2024 14:31:26 GMT, Alan Bateman wrote: >> test/jdk/javax/management/remote/mandatory/notif/policy.negative line 7: >> >>> 5: permission javax.management.MBeanPermission >>> "[domain:type=NB,name=2]", "addNotificationListener"; >>> 6: permission javax.management.MBeanPermi

Re: RFR: 8333344: JMX attaching of Subject does not work when security manager not allowed [v4]

2024-06-12 Thread Alan Bateman
On Wed, 12 Jun 2024 14:23:07 GMT, Daniel Fuchs wrote: >> Kevin Walls has updated the pull request incrementally with one additional >> commit since the last revision: >> >> udpates > > test/jdk/javax/management/remote/mandatory/notif/policy.negative line 7: > >> 5: permission javax.manag

Re: RFR: 8333344: JMX attaching of Subject does not work when security manager not allowed [v4]

2024-06-12 Thread Daniel Fuchs
On Wed, 12 Jun 2024 14:01:40 GMT, Kevin Walls wrote: >> JMX uses APIs related to the Security Mananger which are deprecated. Use of >> AccessControlContext will be removed when Security Manager is removed. >> >> Until then, updates are needed to not require setting >> -Djava.security.manager

Re: RFR: 8333344: JMX attaching of Subject does not work when security manager not allowed [v3]

2024-06-12 Thread Kevin Walls
On Tue, 11 Jun 2024 20:31:03 GMT, Sean Mullan wrote: >> src/java.management/share/classes/com/sun/jmx/remote/internal/ServerNotifForwarder.java >> line 350: >> >>> 348: @SuppressWarnings("removal") >>> 349: private Subject getSubject() { >>> 350: Subject subject = null; >> >> J

Re: RFR: 8333344: JMX attaching of Subject does not work when security manager not allowed [v4]

2024-06-12 Thread Kevin Walls
> JMX uses APIs related to the Security Mananger which are deprecated. Use of > AccessControlContext will be removed when Security Manager is removed. > > Until then, updates are needed to not require setting > -Djava.security.manager=allow to use JMX authentication. Kevin Walls has updated t

Re: RFR: 8333344: JMX attaching of Subject does not work when security manager not allowed [v3]

2024-06-12 Thread Kevin Walls
On Tue, 11 Jun 2024 16:55:44 GMT, Weijun Wang wrote: >> Kevin Walls has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Sean comments > > src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnectionImpl.java > line 1633:

Re: RFR: 8333344: JMX attaching of Subject does not work when security manager not allowed [v3]

2024-06-12 Thread Kevin Walls
On Tue, 11 Jun 2024 16:53:09 GMT, Weijun Wang wrote: >> Kevin Walls has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Sean comments > > src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnectionImpl.java > line 1438:

Re: RFR: 8333344: JMX attaching of Subject does not work when security manager not allowed [v3]

2024-06-12 Thread Kevin Walls
On Tue, 11 Jun 2024 20:58:54 GMT, Sean Mullan wrote: >> src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnectionImpl.java >> line 1436: >> >>> 1434: } else { >>> 1435: // ACC is present, we have a Subject and SM is >>> permitted: >>> 1436:

Re: RFR: 8330846: Add stacks of mounted virtual threads to the HotSpot thread dump [v18]

2024-06-12 Thread David Holmes
On Wed, 12 Jun 2024 08:45:46 GMT, Inigo Mediavilla Saiz wrote: >> Print the stack traces of mounted virtual threads when calling `jcmd >> Thread.print`. > > Inigo Mediavilla Saiz has updated the pull request incrementally with one > additional commit since the last revision: > > Remove unn

Re: RFR: 8333344: JMX attaching of Subject does not work when security manager not allowed [v3]

2024-06-12 Thread Kevin Walls
On Tue, 11 Jun 2024 16:59:31 GMT, Weijun Wang wrote: >> Kevin Walls has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Sean comments > > src/java.management/share/classes/javax/management/monitor/Monitor.java line > 1541: > >> 1539:

Re: RFR: 8332400: isspace argument should be a valid unsigned char [v2]

2024-06-12 Thread Julian Waters
On Tue, 11 Jun 2024 18:07:10 GMT, Robert Toyonaga wrote: >> ### Summary >> This change ensures we don't get undefined behavior when >> calling[`isspace`](https://pubs.opengroup.org/onlinepubs/007904975/functions/isspace.html). >> `isspace` accepts an `int` argument that "the application shall

Re: RFR: 8332400: isspace argument should be a valid unsigned char [v2]

2024-06-12 Thread Thomas Stuefe
On Tue, 11 Jun 2024 18:07:10 GMT, Robert Toyonaga wrote: >> ### Summary >> This change ensures we don't get undefined behavior when >> calling[`isspace`](https://pubs.opengroup.org/onlinepubs/007904975/functions/isspace.html). >> `isspace` accepts an `int` argument that "the application shall

Re: RFR: 8261242: [Linux] OSContainer::is_containerized() returns true when run outside a container [v4]

2024-06-12 Thread Severin Gehwolf
On Fri, 7 Jun 2024 12:59:26 GMT, Severin Gehwolf wrote: >> Please review this enhancement to the container detection code which allows >> it to figure out whether the JVM is actually running inside a container >> (`podman`, `docker`, `crio`), or with some other means that enforces >> memory/cp

Re: RFR: 8332400: isspace argument should be a valid unsigned char [v2]

2024-06-12 Thread Amit Kumar
On Tue, 11 Jun 2024 18:07:10 GMT, Robert Toyonaga wrote: >> ### Summary >> This change ensures we don't get undefined behavior when >> calling[`isspace`](https://pubs.opengroup.org/onlinepubs/007904975/functions/isspace.html). >> `isspace` accepts an `int` argument that "the application shall

Re: RFR: 8330846: Add stacks of mounted virtual threads to the HotSpot thread dump [v17]

2024-06-12 Thread Inigo Mediavilla Saiz
On Wed, 12 Jun 2024 08:34:17 GMT, Alan Bateman wrote: > Thanks for taking feedback, I don't have any other comments. Thanks a lot for all your comments ! 🙇 - PR Comment: https://git.openjdk.org/jdk/pull/19482#issuecomment-2162443508

Re: RFR: 8330846: Add stacks of mounted virtual threads to the HotSpot thread dump [v18]

2024-06-12 Thread Inigo Mediavilla Saiz
> Print the stack traces of mounted virtual threads when calling `jcmd > Thread.print`. Inigo Mediavilla Saiz has updated the pull request incrementally with one additional commit since the last revision: Remove unneeded line - Changes: - all: https://git.openjdk.org/jdk/pull

Re: RFR: 8330846: Add stacks of mounted virtual threads to the HotSpot thread dump [v17]

2024-06-12 Thread Alan Bateman
On Wed, 12 Jun 2024 07:14:59 GMT, Inigo Mediavilla Saiz wrote: >> Print the stack traces of mounted virtual threads when calling `jcmd >> Thread.print`. > > Inigo Mediavilla Saiz has updated the pull request incrementally with one > additional commit since the last revision: > > Fix scope

Re: RFR: 8330846: Add stacks of mounted virtual threads to the HotSpot thread dump [v17]

2024-06-12 Thread Inigo Mediavilla Saiz
> Print the stack traces of mounted virtual threads when calling `jcmd > Thread.print`. Inigo Mediavilla Saiz has updated the pull request incrementally with one additional commit since the last revision: Fix scope of the try block - Changes: - all: https://git.openjdk.org/jd

Re: RFR: 8330846: Add stacks of mounted virtual threads to the HotSpot thread dump [v15]

2024-06-12 Thread Inigo Mediavilla Saiz
On Wed, 12 Jun 2024 06:17:37 GMT, Alan Bateman wrote: >> Inigo Mediavilla Saiz has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Require continuations to run the test > > test/hotspot/jtreg/serviceability/dcmd/thread/PrintMountedVirtualThr

Re: RFR: 8330846: Add stacks of mounted virtual threads to the HotSpot thread dump [v16]

2024-06-12 Thread Inigo Mediavilla Saiz
> Print the stack traces of mounted virtual threads when calling `jcmd > Thread.print`. Inigo Mediavilla Saiz has updated the pull request incrementally with one additional commit since the last revision: Test fixes: pass to junit, avoid spinning thread on fail - Changes: - a

Integrated: 8333730: ubsan: FieldIndices/libFieldIndicesTest.cpp:276:11: runtime error: null pointer passed as argument 2, which is declared to never be null

2024-06-12 Thread Matthias Baesken
On Tue, 11 Jun 2024 13:00:44 GMT, Matthias Baesken wrote: > When running HS :tier1 tests with ubsan-enabled binaries, the following issue > is reported : > test > serviceability/jvmti/FollowReferences/FieldIndices/FieldIndicesTest.jtr > > test/hotspot/jtreg/serviceability/jvmti/FollowReferences

Re: RFR: 8333730: ubsan: FieldIndices/libFieldIndicesTest.cpp:276:11: runtime error: null pointer passed as argument 2, which is declared to never be null

2024-06-12 Thread Matthias Baesken
On Tue, 11 Jun 2024 13:00:44 GMT, Matthias Baesken wrote: > When running HS :tier1 tests with ubsan-enabled binaries, the following issue > is reported : > test > serviceability/jvmti/FollowReferences/FieldIndices/FieldIndicesTest.jtr > > test/hotspot/jtreg/serviceability/jvmti/FollowReferences