On Tue, 11 Jun 2024 07:45:29 GMT, Kevin Walls <[email protected]> wrote:
>> src/hotspot/share/services/diagnosticCommand.cpp line 1211:
>>
>>> 1209: } else {
>>> 1210: name = _filename.value();
>>> 1211: }
>>
>> This code should be considering if a default it specified or not, in case
>> the specified value is identical to what is contained in `default_filename`.
>> With the current solution, if the user literally specifies
>> vm_memory_map_<pid\>.txt, the <pid> part will be expanded to the actual pid.
>> See how [JDK-8323546](https://bugs.openjdk.org/browse/JDK-8323546) handled
>> this.
>
> Oops yes should definitely be using _filename.is_set() rather than strcmp.
I filed [JDK-8334164](https://bugs.openjdk.org/browse/JDK-8334164) for not
using `_filename.is_set()` and
[JDK-8334145](https://bugs.openjdk.org/browse/JDK-8334145) for the issue with
<pid\> missing from the default filename in the jcmd.l.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19596#discussion_r1637173696
