Re: RFR: 8334215: serviceability/dcmd/thread/PrintMountedVirtualThread.java failing with JTREG_TEST_THREAD_FACTORY=Virtual [v4]

2024-06-19 Thread Alan Bateman
On Wed, 19 Jun 2024 06:18:12 GMT, David Holmes wrote: > FWIW I would have kept the vt name just in case it does have one. But as Alan > said that can be added in later if desired. I suggested we drop this for now because the thread dump can happen at times when there isn't a reference to the v

Re: RFR: 8334215: serviceability/dcmd/thread/PrintMountedVirtualThread.java failing with JTREG_TEST_THREAD_FACTORY=Virtual [v4]

2024-06-19 Thread David Holmes
On Wed, 19 Jun 2024 07:01:49 GMT, Alan Bateman wrote: > the thread dump can happen at times when there isn't a reference to the > virtual Thread I don't follow. We have checked vt is not null and not the carrier, so we do have it. - PR Comment: https://git.openjdk.org/jdk/pull/19

Re: RFR: 8326820: Metadata artificially kept alive [v2]

2024-06-19 Thread Erik Österlund
On Wed, 19 Jun 2024 06:14:21 GMT, Axel Boldt-Christmas wrote: >> ClassLoaderDataGraph provides APIs for walking different metadata. All the >> iterators which are not designed to be used by the GC also keep the holder >> of the CLDs alive and by extensions keeps all metadata alive. This is >>

Re: RFR: 8334215: serviceability/dcmd/thread/PrintMountedVirtualThread.java failing with JTREG_TEST_THREAD_FACTORY=Virtual [v4]

2024-06-19 Thread Alan Bateman
On Wed, 19 Jun 2024 07:31:41 GMT, David Holmes wrote: > I don't follow. We have checked vt is not null and not the carrier, so we do > have it. My comment was about the case where the thread dump happens during a transition so sees the self-reference. In the loom repo the JavaThread has the th

Re: RFR: 8326820: Metadata artificially kept alive [v2]

2024-06-19 Thread Stefan Karlsson
On Wed, 19 Jun 2024 06:14:21 GMT, Axel Boldt-Christmas wrote: >> ClassLoaderDataGraph provides APIs for walking different metadata. All the >> iterators which are not designed to be used by the GC also keep the holder >> of the CLDs alive and by extensions keeps all metadata alive. This is >>

Re: Status check for JDK-8282441

2024-06-19 Thread Iñigo Mediavilla
Perfect, no problem. I will look into something else to work on. Best Íñigo On Tue, Jun 18, 2024 at 8:11 PM Chris Plummer wrote: > I did quite a bit of work on this a few months ago, but had to table it > for a while so I could work on other things. I plan on getting back to it > in 24. > > ch

Integrated: 8334215: serviceability/dcmd/thread/PrintMountedVirtualThread.java failing with JTREG_TEST_THREAD_FACTORY=Virtual

2024-06-19 Thread Inigo Mediavilla Saiz
On Mon, 17 Jun 2024 09:13:57 GMT, Inigo Mediavilla Saiz wrote: > Follow up to https://github.com/openjdk/jdk/pull/19482 that was causing > issues when the PrintMountedVirtualTest.java was > running with `JTREG_TEST_THREAD_FACTORY=Virtual` in the loom repo. > > - Fixes issues where the test ob

Re: RFR: 8333344: JMX attaching of Subject does not work when security manager not allowed [v19]

2024-06-19 Thread Daniel Fuchs
On Tue, 18 Jun 2024 12:17:46 GMT, Kevin Walls wrote: >> JMX uses APIs related to the Security Mananger which are deprecated. Use of >> AccessControlContext will be removed when Security Manager is removed. >> >> Until then, updates are needed to not require setting >> -Djava.security.manager

Re: RFR: 8333344: JMX attaching of Subject does not work when security manager not allowed [v19]

2024-06-19 Thread Kevin Walls
On Wed, 19 Jun 2024 11:21:45 GMT, Daniel Fuchs wrote: > The code changes look good to me (if a bit verbose) and the test changes look > reasonable. It could be beneficial to add some more tests in the future > involving monitoring and getting the subject from within a monitored MBean. Yes, agr

Re: RFR: 8326820: Metadata artificially kept alive [v2]

2024-06-19 Thread Axel Boldt-Christmas
On Wed, 19 Jun 2024 08:53:33 GMT, Stefan Karlsson wrote: >> Axel Boldt-Christmas has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Document the iterator and functions > > src/hotspot/share/classfile/systemDictionary.cpp line 1588: > >> 15

Re: RFR: 8326820: Metadata artificially kept alive [v3]

2024-06-19 Thread Axel Boldt-Christmas
> ClassLoaderDataGraph provides APIs for walking different metadata. All the > iterators which are not designed to be used by the GC also keep the holder of > the CLDs alive and by extensions keeps all metadata alive. This is > problematic for concurrent GC as it keeps otherwise unreachable clas

Re: RFR: 8326820: Metadata artificially kept alive [v3]

2024-06-19 Thread Stefan Karlsson
On Wed, 19 Jun 2024 15:06:25 GMT, Axel Boldt-Christmas wrote: >> ClassLoaderDataGraph provides APIs for walking different metadata. All the >> iterators which are not designed to be used by the GC also keep the holder >> of the CLDs alive and by extensions keeps all metadata alive. This is >>

Re: RFR: 8333344: JMX attaching of Subject does not work when security manager not allowed [v19]

2024-06-19 Thread Kevin Walls
On Tue, 18 Jun 2024 12:17:46 GMT, Kevin Walls wrote: >> JMX uses APIs related to the Security Mananger which are deprecated. Use of >> AccessControlContext will be removed when Security Manager is removed. >> >> Until then, updates are needed to not require setting >> -Djava.security.manager

Integrated: 8333344: JMX attaching of Subject does not work when security manager not allowed

2024-06-19 Thread Kevin Walls
On Mon, 10 Jun 2024 11:28:28 GMT, Kevin Walls wrote: > JMX uses APIs related to the Security Mananger which are deprecated. Use of > AccessControlContext will be removed when Security Manager is removed. > > Until then, updates are needed to not require setting > -Djava.security.manager=allo