On Tue, 25 Jun 2024 13:54:46 GMT, Severin Gehwolf wrote:
>> Please review this enhancement to the container detection code which allows
>> it to figure out whether the JVM is actually running inside a container
>> (`podman`, `docker`, `crio`), or with some other means that enforces
>> memory/c
VM.classes uses:
995VM_PrintClasses vmop(output(), _verbose.is_set());
_verbose.is_set() is wrong: it could be set, but set to false.
_verbose.value() should be used (see other examples such as
StringtableDCmd::execute).
With this change -verbose=false will turn off verbose mode like all o
On Wed, 26 Jun 2024 10:23:45 GMT, Kevin Walls wrote:
> VM.classes uses:
>
> 995VM_PrintClasses vmop(output(), _verbose.is_set());
>
> _verbose.is_set() is wrong: it could be set, but set to false.
>
> _verbose.value() should be used (see other examples such as
> StringtableDCmd::execute).
On Wed, 26 Jun 2024 12:29:18 GMT, David Holmes wrote:
>> VM.classes uses:
>>
>> 995VM_PrintClasses vmop(output(), _verbose.is_set());
>>
>> _verbose.is_set() is wrong: it could be set, but set to false.
>>
>> _verbose.value() should be used (see other examples such as
>> StringtableDCmd::
On Wed, 26 Jun 2024 12:40:07 GMT, Kevin Walls wrote:
>> src/hotspot/share/services/diagnosticCommand.cpp line 995:
>>
>>> 993:
>>> 994: void ClassesDCmd::execute(DCmdSource source, TRAPS) {
>>> 995: VM_PrintClasses vmop(output(), _verbose.value());
>>
>> What if it wasn't set?
>
> It has a d
On Wed, 26 Jun 2024 10:23:45 GMT, Kevin Walls wrote:
> VM.classes uses:
>
> 995VM_PrintClasses vmop(output(), _verbose.is_set());
>
> _verbose.is_set() is wrong: it could be set, but set to false.
>
> _verbose.value() should be used (see other examples such as
> StringtableDCmd::execute).
On Wed, 26 Jun 2024 12:44:03 GMT, David Holmes wrote:
>> It has a default value... Generally "false" for _verbose DCmdArguments.
>
> Ok
Thanks!
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19901#discussion_r1654753099
On Tue, 25 Jun 2024 13:55:32 GMT, Sonia Zaldana Calles
wrote:
>> Hi all,
>>
>> This PR addresses [8332124](https://bugs.openjdk.org/browse/JDK-8332124)
>> enabling jcmd to accept "help" as an argument to subcommands.
>>
>> Testing:
>> - [x] Verified running `jcmd 4711 VM.metaspace help` wo
On Wed, 26 Jun 2024 10:23:45 GMT, Kevin Walls wrote:
> VM.classes uses:
>
> 995VM_PrintClasses vmop(output(), _verbose.is_set());
>
> _verbose.is_set() is wrong: it could be set, but set to false.
>
> _verbose.value() should be used (see other examples such as
> StringtableDCmd::execute).
Forwarded Message
Subject: Re: RFR: 8332124: Jcmd processing should accept the "help" sub
option as command argument [v2]
Date: Tue, 25 Jun 2024 13:30:04 -0700
From: Laurence Cable
To: serviceability-dev@openjdk.org
what about '*jcmd help *' not a great deal of
will do!
On 6/26/24 3:04 AM, Severin Gehwolf wrote:
On Tue, 25 Jun 2024 13:54:46 GMT, Severin Gehwolf wrote:
Please review this enhancement to the container detection code which allows it to
figure out whether the JVM is actually running inside a container (`podman`,
`docker`, `crio`), or w
On Wed, 26 Jun 2024 06:36:05 GMT, SendaoYan wrote:
> Hi all,
> The newly added test `com/sun/jdi/BreakpointOnClassPrepare.java` fails at
> `SUSPEND_NONE` mode.
> To make this test less noisy, should we disable the SUSPEND_NONE mode for now.
@sendaoYan I have a PR out to fix the issue. I think i
Allow ObjectCollectedException during ThreadReference.toString() call. This can
happen when using SUSPEND_NONE since the thread continues to run after hitting
the breakpoint.
So far I've just run the test locally. I'll run the full suite of debugger
tests before committing. Note I don't know ho
On Tue, 25 Jun 2024 13:55:32 GMT, Sonia Zaldana Calles
wrote:
>> Hi all,
>>
>> This PR addresses [8332124](https://bugs.openjdk.org/browse/JDK-8332124)
>> enabling jcmd to accept "help" as an argument to subcommands.
>>
>> Testing:
>> - [x] Verified running `jcmd 4711 VM.metaspace help` wo
On Wed, 26 Jun 2024 06:36:05 GMT, SendaoYan wrote:
> Hi all,
> The newly added test `com/sun/jdi/BreakpointOnClassPrepare.java` fails at
> `SUSPEND_NONE` mode.
> To make this test less noisy, should we disable the SUSPEND_NONE mode for now.
> @sendaoYan I have a PR out to fix the issue. I think
On Wed, 26 Jun 2024 06:36:05 GMT, SendaoYan wrote:
> Hi all,
> The newly added test `com/sun/jdi/BreakpointOnClassPrepare.java` fails at
> `SUSPEND_NONE` mode.
> To make this test less noisy, should we disable the SUSPEND_NONE mode for now.
This pull request has been closed without being integr
On Wed, 26 Jun 2024 06:36:05 GMT, SendaoYan wrote:
> Hi all,
> The newly added test `com/sun/jdi/BreakpointOnClassPrepare.java` fails at
> `SUSPEND_NONE` mode.
> To make this test less noisy, should we disable the SUSPEND_NONE mode for now.
We've done a lot of G1 testing without seeing this pro
17 matches
Mail list logo
