On Wed, 26 Jun 2024 10:23:45 GMT, Kevin Walls <kev...@openjdk.org> wrote:
> VM.classes uses: > > 995 VM_PrintClasses vmop(output(), _verbose.is_set()); > > _verbose.is_set() is wrong: it could be set, but set to false. > > _verbose.value() should be used (see other examples such as > StringtableDCmd::execute). > > With this change -verbose=false will turn off verbose mode like all other > DCmds which accept -verbose > > bash-4.2$ jcmd 20193 VM.classes -verbose=false | wc -l > 2490 > bash-4.2$ jcmd 20193 VM.classes -verbose=true | wc -l > 90258 Looks good. ------------- Marked as reviewed by dholmes (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/19901#pullrequestreview-2141698713
