On Fri, 28 Jun 2024 12:14:55 GMT, Coleen Phillimore wrote:
> Clean backport of JDK-8333542. After this, we need a backport for
> JDK-8335134 to fix the test.
Marked as reviewed by cjplummer (Reviewer).
-
PR Review:
`ClassFile::transform` was initially `ClassModel::transform`, which transforms
the receiver class model to a new class byte array. This functionality was in
parallel with `ClassBuilder::transform`, which accepts a `ClassModel` and a
`ClassTransform` and forwards the results to the receiver
The completely unrelated fix to
[JDK-8335124](https://bugs.openjdk.org/browse/JDK-8335124) led me to believe
that the issue with sometimes not being able to get the stack trace of the
SteadyStateThread might be due to the thread being active for a short period
after being reported as in the
On Thu, 27 Jun 2024 08:54:16 GMT, Kevin Walls wrote:
> This test has had occasional failures for years, possibly forever.
> A previous update made the test "othervm" which removed some interruptions,
> but a time accounting problem remains.
>
> This change adds a simple sleep after observing
On Fri, 28 Jun 2024 18:14:59 GMT, Kevin Walls wrote:
>> Disable running this test with -Xcomp.
>>
>> The NPE seen in this test is due to a timeout establishing the connection.
>> ServerCommunicatorAdmin hits its timeout, during an addNotificationListener
>> call on a new connection.
>>
>>
On macosx-aarch64, sometimes the generated core file does not contain all valid
memory. This causes SA tests to fail with various address related java
exceptions. There's nothing SA can do to work around the problem, and these
failures over time have been just too noisy, so I'm problem listing
On Fri, 28 Jun 2024 18:14:59 GMT, Kevin Walls wrote:
>> Disable running this test with -Xcomp.
>>
>> The NPE seen in this test is due to a timeout establishing the connection.
>> ServerCommunicatorAdmin hits its timeout, during an addNotificationListener
>> call on a new connection.
>>
>>
On Thu, 27 Jun 2024 08:54:16 GMT, Kevin Walls wrote:
> This test has had occasional failures for years, possibly forever.
> A previous update made the test "othervm" which removed some interruptions,
> but a time accounting problem remains.
>
> This change adds a simple sleep after observing
> Disable running this test with -Xcomp.
>
> The NPE seen in this test is due to a timeout establishing the connection.
> ServerCommunicatorAdmin hits its timeout, during an addNotificationListener
> call on a new connection.
>
> -Xcomp causes this slowdown and the failure is reproducible.
On Wed, 5 Jun 2024 06:22:17 GMT, Sebastian Lövdahl wrote:
>> 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid
>> (Kubernetes debug container)
>
> Sebastian Lövdahl has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Add
On Fri, 28 Jun 2024 15:41:48 GMT, Severin Gehwolf wrote:
>> Please review this enhancement to the container detection code which allows
>> it to figure out whether the JVM is actually running inside a container
>> (`podman`, `docker`, `crio`), or with some other means that enforces
>>
On 6/28/24 8:45 AM, Severin Gehwolf wrote:
On Thu, 27 Jun 2024 18:40:09 GMT, Larry Cable wrote:
Severin Gehwolf has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 17 commits:
- Refactor mount info matching to helper function
On Thu, 27 Jun 2024 15:53:09 GMT, Kevin Walls wrote:
> Disable running this test with -Xcomp.
>
> The NPE seen in this test is due to a timeout establishing the connection.
> ServerCommunicatorAdmin hits its timeout, during an addNotificationListener
> call on a new connection.
>
> -Xcomp
On Fri, 28 Jun 2024 15:41:48 GMT, Severin Gehwolf wrote:
>> Please review this enhancement to the container detection code which allows
>> it to figure out whether the JVM is actually running inside a container
>> (`podman`, `docker`, `crio`), or with some other means that enforces
>>
On Thu, 27 Jun 2024 18:40:09 GMT, Larry Cable wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 17 commits:
>>
>> - Refactor mount info matching to helper function
>> - Merge branch 'master' into
> Please review this enhancement to the container detection code which allows
> it to figure out whether the JVM is actually running inside a container
> (`podman`, `docker`, `crio`), or with some other means that enforces
> memory/cpu limits by means of the cgroup filesystem. If neither of
On Thu, 27 Jun 2024 18:38:14 GMT, Sonia Zaldana Calles
wrote:
>> Hi all,
>>
>> This PR addresses [8332124](https://bugs.openjdk.org/browse/JDK-8332124)
>> enabling jcmd to accept "help" as an argument to subcommands.
>>
>> Testing:
>> - [x] Verified running `jcmd 4711 VM.metaspace help`
On Thu, 27 Jun 2024 18:38:14 GMT, Sonia Zaldana Calles
wrote:
>> Hi all,
>>
>> This PR addresses [8332124](https://bugs.openjdk.org/browse/JDK-8332124)
>> enabling jcmd to accept "help" as an argument to subcommands.
>>
>> Testing:
>> - [x] Verified running `jcmd 4711 VM.metaspace help`
On Thu, 27 Jun 2024 18:38:14 GMT, Sonia Zaldana Calles
wrote:
>> Hi all,
>>
>> This PR addresses [8332124](https://bugs.openjdk.org/browse/JDK-8332124)
>> enabling jcmd to accept "help" as an argument to subcommands.
>>
>> Testing:
>> - [x] Verified running `jcmd 4711 VM.metaspace help`
Clean backport of JDK-8333542. After this, we need a backport for JDK-8335134
to fix the test.
-
Commit messages:
- Backport b3bf31a0a08da679ec2fd21613243fb17b1135a9
Changes: https://git.openjdk.org/jdk/pull/19938/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=19938=00
On Tue, 25 Jun 2024 13:54:46 GMT, Severin Gehwolf wrote:
>> Please review this enhancement to the container detection code which allows
>> it to figure out whether the JVM is actually running inside a container
>> (`podman`, `docker`, `crio`), or with some other means that enforces
>>
21 matches
Mail list logo