On Thu, 1 Aug 2024 03:06:15 GMT, Jiawei Tang wrote:
>> I add the testcase which can reproduce the crash. I hope that I could get
>> some advise if the codes need changing.
>
> Jiawei Tang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> rem
On Thu, 1 Aug 2024 04:09:31 GMT, Serguei Spitsyn wrote:
> The JVMTI Watch Field functions do not disable VTMS transitions with the
> `JvmtiVTMSTransitionDisabler`:
> - `SetFieldAccessWatch()`
> - `ClearFieldAccessWatch()`
> - `SetFieldModificationWatch()`
> - `ClearFieldModificationWatch()`
> s
On Wed, 31 Jul 2024 19:50:01 GMT, Alex Menkov wrote:
>> "Attach fails" scenarios (debuggee starts listening and debugger is expected
>> to fail trying to attach) sometimes interfere with other JDI tests (so
>> JdwpNetProps.java test or other JDI test or both fail).
>> The fix disables the scena
The JVMTI Watch Field functions do not disable VTMS transitions with the
`JvmtiVTMSTransitionDisabler`:
- `SetFieldAccessWatch()`
- `ClearFieldAccessWatch()`
- `SetFieldModificationWatch()`
- `ClearFieldModificationWatch()`
so in the `recompute_enabled()` we could see that a vthread is mounted, b
On Wed, 31 Jul 2024 19:10:41 GMT, Henry Lin wrote:
> Adds a command line option `-redact` to `jcmd`, `redact` to `jmap` and
> `-XX:+HeapDumpRedacted` enabling redacted heap dumps. When enabled, the
> output binary heap dump has zeroes written out in place of the original
> primitive values in
> I add the testcase which can reproduce the crash. I hope that I could get
> some advise if the codes need changing.
Jiawei Tang has updated the pull request incrementally with one additional
commit since the last revision:
remove useless codes and refactor the testcase
-
Chang
On Tue, 30 Jul 2024 11:20:48 GMT, Serguei Spitsyn wrote:
>> Jiawei Tang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> refactor testcase and change the location of fix codes
>
> src/hotspot/share/prims/jvmtiExport.cpp line 1098:
>
>> 1
On Wed, 31 Jul 2024 19:10:41 GMT, Henry Lin wrote:
> Adds a command line option `-redact` to `jcmd`, `redact` to `jmap` and
> `-XX:+HeapDumpRedacted` enabling redacted heap dumps. When enabled, the
> output binary heap dump has zeroes written out in place of the original
> primitive values in
On Wed, 31 Jul 2024 10:52:06 GMT, Kevin Walls wrote:
> Problemlist update only, should be trivial:
>
> Remove problemlist entries for sun/management/jdp tests on MacOS and Linux.
>
> 8241865 was a failure last seen July 2022.
> Was related to
> 8241530 com/sun/jdi tests fail due to network issu
On Wed, 31 Jul 2024 19:55:54 GMT, Alex Menkov wrote:
>> test/jdk/com/sun/jdi/JdwpListenTest.java line 54:
>>
>>> 52: // It's off by default as it causes test time increase and test
>>> interference (see JDK-8231915).
>>> 53: private static boolean allowNegativeTesting =
>>> 54:
Adds a command line option `-redact` to `jcmd`, `redact` to `jmap` and
`-XX:+HeapDumpRedacted` enabling redacted heap dumps. When enabled, the output
binary heap dump has zeroes written out in place of the original primitive
values in the object fields. There is a new jtreg test
`heapDumpRedact
On Tue, 30 Jul 2024 01:57:33 GMT, Alex Menkov wrote:
> Obsolete UseNotificationThread flag which was deprecated in JDK 23.
>
> Testing: tier1..tier5
This pull request has now been integrated.
Changeset: 8af2ef35
Author:Alex Menkov
URL:
https://git.openjdk.org/jdk/commit/8af2ef35b6f
On Wed, 31 Jul 2024 12:08:33 GMT, David Holmes wrote:
>> Alex Menkov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add sys.prop to enable negative testing
>
> test/jdk/com/sun/jdi/JdwpListenTest.java line 54:
>
>> 52: // It's off
> "Attach fails" scenarios (debuggee starts listening and debugger is expected
> to fail trying to attach) sometimes interfere with other JDI tests (so
> JdwpNetProps.java test or other JDI test or both fail).
> The fix disables the scenarios to remove noise in the CI.
Alex Menkov has updated th
On Wed, 31 Jul 2024 10:12:16 GMT, Serguei Spitsyn wrote:
> Did you consider to add a test for this?
Good idea. I'll add one.
-
PR Comment: https://git.openjdk.org/jdk/pull/20367#issuecomment-2260951141
On Tue, 23 Jul 2024 14:11:20 GMT, Albert Mingkun Yang wrote:
> Simple obsoleting a Parallel GC product flag.
This pull request has now been integrated.
Changeset: e4c7850c
Author:Albert Mingkun Yang
URL:
https://git.openjdk.org/jdk/commit/e4c7850c177899a5da6f5050cb0647a6e1a75d31
Sta
On Thu, 25 Jul 2024 07:44:45 GMT, Albert Mingkun Yang wrote:
>> Simple obsoleting a Parallel GC product flag.
>
> Albert Mingkun Yang has updated the pull request incrementally with one
> additional commit since the last revision:
>
> copyright
Thanks for review.
-
PR Comment:
On Wed, 31 Jul 2024 11:25:50 GMT, Albert Mingkun Yang wrote:
> Trivial removing an unused gc-cause; it was previously used by Parallel only.
Looks good, and trivial.
-
Marked as reviewed by kbarrett (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/20403#pullrequestreview-22
On Wed, 31 Jul 2024 11:25:50 GMT, Albert Mingkun Yang wrote:
> Trivial removing an unused gc-cause; it was previously used by Parallel only.
Good.
-
Marked as reviewed by tschatzl (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/20403#pullrequestreview-2210168192
On Tue, 30 Jul 2024 04:12:33 GMT, Kim Barrett wrote:
> Please review this change that removes some uses of literal 0 as a null
> pointer constant in prims code.
>
> Testing: mach5 tier1
This pull request has now been integrated.
Changeset: 07dd7250
Author:Kim Barrett
URL:
https://g
On Tue, 30 Jul 2024 07:54:43 GMT, David Holmes wrote:
>> Please review this change that removes some uses of literal 0 as a null
>> pointer constant in prims code.
>>
>> Testing: mach5 tier1
>
> Okay - looks good. Thanks.
Thanks for reviews @dholmes-ora , @shipilev , @TheShermanTanker , and @ss
On Thu, 25 Jul 2024 07:44:45 GMT, Albert Mingkun Yang wrote:
>> Simple obsoleting a Parallel GC product flag.
>
> Albert Mingkun Yang has updated the pull request incrementally with one
> additional commit since the last revision:
>
> copyright
Marked as reviewed by tschatzl (Reviewer).
---
On Tue, 30 Jul 2024 01:57:33 GMT, Alex Menkov wrote:
> Obsolete UseNotificationThread flag which was deprecated in JDK 23.
>
> Testing: tier1..tier5
Thank you for doing this.
-
Marked as reviewed by coleenp (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/20381#pullrequest
On Tue, 30 Jul 2024 20:11:03 GMT, Alex Menkov wrote:
>> "Attach fails" scenarios (debuggee starts listening and debugger is expected
>> to fail trying to attach) sometimes interfere with other JDI tests (so
>> JdwpNetProps.java test or other JDI test or both fail).
>> The fix disables the scena
Problemlist update only, should be trivial:
Remove problemlist entries for sun/management/jdp tests on MacOS and Linux.
8241865 was a failure last seen July 2022.
Was related to
8241530 com/sun/jdi tests fail due to network issues on OSX 10.15
Originally logged for macOS failures but Linux failur
Trivial removing an unused gc-cause; it was previously used by Parallel only.
-
Commit messages:
- remove-gc-cause
Changes: https://git.openjdk.org/jdk/pull/20403/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20403&range=00
Issue: https://bugs.openjdk.org/browse/JDK-833
On Thu, 25 Jul 2024 15:13:29 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test-only backport of the fix that we did
> in master branch a few weeks back?
>
> This isn't a clean backport, there were trivial merge issues in the
> `NativeMethodPrefixApp` test class, which I have re
On Thu, 25 Jul 2024 15:13:29 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test-only backport of the fix that we did
> in master branch a few weeks back?
>
> This isn't a clean backport, there were trivial merge issues in the
> `NativeMethodPrefixApp` test class, which I have re
On Thu, 25 Jul 2024 15:13:29 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test-only backport of the fix that we did
> in master branch a few weeks back?
>
> This isn't a clean backport, there were trivial merge issues in the
> `NativeMethodPrefixApp` test class, which I have re
On Sat, 27 Jul 2024 02:12:33 GMT, Chris Plummer wrote:
> JVMTI has a somewhat unique event called DataDumpRequest. One way it is
> triggered is via the JVMTI.data_dump jcmd, which causes JVMTI to send the
> DataDumpRequest event to all agents that have registered for the event
> callback. The
Man page update for jcmd.
Add updates for the filename options/arguments affected by:
8334492: DiagnosticCommands (jcmd) should accept %p in output filenames and
substitute PID
Also:
In the initial "command" summary, remove the text about "If the pid is 0.." as
it is completely duplicated very
On Wed, 31 Jul 2024 08:30:47 GMT, Kevin Walls wrote:
> Man page update for jcmd.
>
> Add updates for the filename options/arguments affected by:
> 8334492: DiagnosticCommands (jcmd) should accept %p in output filenames and
> substitute PID
>
> Also:
> In the initial "command" summary, remove t
On Tue, 30 Jul 2024 01:57:33 GMT, Alex Menkov wrote:
> Obsolete UseNotificationThread flag which was deprecated in JDK 23.
>
> Testing: tier1..tier5
Marked as reviewed by sspitsyn (Reviewer).
Looks good.
-
PR Review: https://git.openjdk.org/jdk/pull/20381#pullrequestreview-220950
On Tue, 30 Jul 2024 04:12:33 GMT, Kim Barrett wrote:
> Please review this change that removes some uses of literal 0 as a null
> pointer constant in prims code.
>
> Testing: mach5 tier1
Looks good. Thank you for fixing this!
The `ResultType ret{};` syntax is a little bit unusual but I'm okay wi
On Tue, 30 Jul 2024 20:11:03 GMT, Alex Menkov wrote:
>> "Attach fails" scenarios (debuggee starts listening and debugger is expected
>> to fail trying to attach) sometimes interfere with other JDI tests (so
>> JdwpNetProps.java test or other JDI test or both fail).
>> The fix disables the scena
On Sat, 27 Jul 2024 01:55:23 GMT, Chris Plummer wrote:
> The test is setting breakpoints on the wrong line numbers, which causes
> setting up the breakpoint to fail, but the test also has buggy error
> checking, so the test doesn't detect the failures and still passes. I fixed
> the breakpoint
36 matches
Mail list logo
