On Mon, 28 Jul 2025 14:41:25 GMT, Francesco Andreuzzi wrote:
>> This PR sorts the includes in `hotspot/share/services` using
>> `SortIncludes.java`. I'm also adding the directory to
>> `TestIncludesAreSorted`.
>>
>> Passes tier1.
>
> Francesco Andreuzzi has updated the pull request with a new
On Tue, 29 Jul 2025 02:20:56 GMT, Lei Zhu wrote:
> Hi all,
>
> Fixed type errors in documentation, minor changes.
>
> Thanks!
This pull request has now been integrated.
Changeset: 1be412dc
Author:Lei Zhu
Committer: Serguei Spitsyn
URL:
https://git.openjdk.org/jdk/commit/1be412dca
On Tue, 29 Jul 2025 02:20:56 GMT, Lei Zhu wrote:
> Hi all,
>
> Fixed type errors in documentation, minor changes.
>
> Thanks!
Marked as reviewed by sspitsyn (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/26521#pullrequestreview-3069907149
On Tue, 29 Jul 2025 18:08:29 GMT, Alex Menkov wrote:
>> Hi all,
>>
>> Fixed type errors in documentation, minor changes.
>>
>> Thanks!
>
> Marked as reviewed by amenkov (Reviewer).
@alexmenkov Thank you for the review! And can you help me execute `/sponsor`
command.
-
PR Comment
On Tue, 29 Jul 2025 15:23:29 GMT, Alan Bateman wrote:
> I don't think the current proposed change (which drop's setting the interrupt
> flag in install_async_exception) will cause a target thread blocked in sleep
> to wakeup. A target thread blocked in JavaThread::sleep_nanos will wakeup
> fro
On Fri, 25 Jul 2025 23:09:48 GMT, Chris Plummer wrote:
> Fix gcc warning about double close. forkedChildProcess() calls
> closeDescriptors(), which always closes STDERR_FILENO + 1 and STDERR_FILENO +
> 2. However, if it fails at some point after that, then forkedChildProcess()
> will attempt t
On Tue, 29 Jul 2025 06:23:20 GMT, Thomas Stuefe wrote:
> No, I am talking about this:
>
> https://github.com/openjdk/jdk/blob/4669005123420d8dbe86740dd9bcbee04735bc4f/src/java.base/unix/native/libjava/childproc.c#L109
> where we close all file descriptors apart from the ones we need to
> commun
On Mon, 28 Jul 2025 16:18:44 GMT, Chris Plummer wrote:
>> Fix gcc warning about double close. forkedChildProcess() calls
>> closeDescriptors(), which always closes STDERR_FILENO + 1 and STDERR_FILENO
>> + 2. However, if it fails at some point after that, then
>> forkedChildProcess() will attem
On Tue, 29 Jul 2025 02:20:56 GMT, Lei Zhu wrote:
> Hi all,
>
> Fixed type errors in documentation, minor changes.
>
> Thanks!
Marked as reviewed by amenkov (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/26521#pullrequestreview-3068654927
On Tue, 29 Jul 2025 07:06:21 GMT, David Holmes wrote:
> FWIW I think the fix is reasonable to avoid messing with the interrupt flag,
> but the fact Alan seems to want the "stop" to not interrupt at all makes me
> wonder how stop would then actually work?
I don't think the current proposed chan
On Tue, 29 Jul 2025 09:56:23 GMT, Markus Grönlund wrote:
> 8356587: Missing object ID X in pool jdk.types.Method
This pull request has now been integrated.
Changeset: 9fe2aa59
Author:Markus Grönlund
URL:
https://git.openjdk.org/jdk/commit/9fe2aa59ffde718795cfa10919468c253b34
Sta
On Tue, 29 Jul 2025 09:56:23 GMT, Markus Grönlund wrote:
> 8356587: Missing object ID X in pool jdk.types.Method
Marked as reviewed by egahlin (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/26529#pullrequestreview-3066684022
8356587: Missing object ID X in pool jdk.types.Method
-
Commit messages:
- Backport a34994476e8f4783c9f5a83a9c3db63ad605b323
Changes: https://git.openjdk.org/jdk/pull/26529/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=26529&range=00
Issue: https://bugs.openjdk.org/brow
On Thu, 24 Jul 2025 12:49:36 GMT, Markus Grönlund wrote:
> Greetings,
>
> The following change set addresses the data loss resulting in the assertion
> "Missing object ID X in pool jdk.types.Method".
>
> It involves three components:
>
> 1. Address a regression introduced by
> [JDK-835221](h
On Mon, 28 Jul 2025 10:50:23 GMT, Alan Bateman wrote:
> It would put the onus on the debugger to interrupt, which I think is the
> right thing to do. it would remove the interrupt from
> JavaThread::install_async_exception and would mean no change to
> JavaThread::sleep_nanos.
Thank you for t
> If JVMTI `StopThread` is done when the thread is in certain various states
> (but not all states), after the `async` exception is delivered and handled,
> hotspot leaves the thread's `interrupted` flag set. The end result is the
> next time the thread does something like `Thread.sleep()`, it w
On Tue, 29 Jul 2025 02:20:56 GMT, Lei Zhu wrote:
> Hi all,
>
> Fixed type errors in documentation, minor changes.
>
> Thanks!
@Korov
Your change (at version b6a19df4f83266856f9688f4ac204055908b89a8) is now ready
to be sponsored by a Committer.
-
PR Comment: https://git.openjdk.
On Mon, 28 Jul 2025 06:57:42 GMT, Serguei Spitsyn wrote:
>> If JVMTI `StopThread` is done when the thread is in certain various states
>> (but not all states), after the `async` exception is delivered and handled,
>> hotspot leaves the thread's `interrupted` flag set. The end result is the
>>
18 matches
Mail list logo
