On Thu, 18 Jul 2024 07:30:47 GMT, SendaoYan wrote:
>> Hi all,
>> The testcase `serviceability/attach/LongArgTest.java` intermittent fails
>> `java.lang.NoClassDefFoundError: jdk/test/lib/Utils`. Jtreg doesn't
>> automatically compile `jdk/test/lib/Utils.class` and
>> `jdk/test/lib/apps/Lingere
On Thu, 4 Jul 2024 10:49:47 GMT, Volker Simonis wrote:
>> Since Java 5 the `java.lang.instrument` package provides services that allow
>> Java programming language agents to instrument (i.e. modify the bytecode) of
>> programs running on the Java Virtual Machine. The `java.lang.instrument`
>>
On Wed, 3 Jul 2024 16:14:31 GMT, Volker Simonis wrote:
> Since Java 5 the `java.lang.instrument` package provides services that allow
> Java programming language agents to instrument (i.e. modify the bytecode) of
> programs running on the Java Virtual Machine. The `java.lang.instrument`
> func
`ClassFile::transform` was initially `ClassModel::transform`, which transforms
the receiver class model to a new class byte array. This functionality was in
parallel with `ClassBuilder::transform`, which accepts a `ClassModel` and a
`ClassTransform` and forwards the results to the receiver build
On Fri, 14 Jun 2024 10:52:40 GMT, Magnus Ihse Bursie wrote:
>> Ah, I had not realized that there was more than 1 newline. GitHub's UI
>> confused me here, so we're good to go
>
> GitHub's UI assumes the final line has an line break. If it is missing, it
> displays a red 🚫 at the end of the last
On Fri, 7 Jun 2024 12:47:39 GMT, Erik Joelsson wrote:
>> test/jdk/java/rmi/reliability/benchmark/bench/Makefile line 50:
>>
>>> 48: clean:
>>> 49: rm -f *.class .classes
>>> 50:
>>
>> Hmm, shouldn't this newline at EOF be kept? Asking @ all the people who've
>> reviewed this so far, n
On Fri, 7 Jun 2024 07:29:39 GMT, SendaoYan wrote:
>> Hi all,
>> This PR several extra empty spaces and extra empty lines in several
>> Makefiles. It's trivial fix, no risk.
>>
>> Thanks.
>
> SendaoYan has updated the pull request incrementally with one additional
> commit since the last revi
On Tue, 4 Jun 2024 07:47:46 GMT, SendaoYan wrote:
> Hi all,
> This PR several extra empty spaces and extra empty lines in several
> Makefiles. It's trivial fix, no risk.
>
> Thanks.
Changes requested by liach (Author).
test/jdk/java/rmi/reliability/benchmark/bench/rmi/Makefile line 1:
> 1:
On Tue, 4 Jun 2024 07:47:46 GMT, SendaoYan wrote:
> Hi all,
> This PR several extra empty spaces and extra empty lines in several
> Makefiles. It's trivial fix, no risk.
>
> Thanks.
@altrisi As trivial and low-effort as this seems, this is actually fixing some
technical debt for legacy Make
On Fri, 24 May 2024 18:11:18 GMT, Nizar Benalla wrote:
> This is a simple noreg cleanup. The motivation was that I noticed javac
> doesn't recognise package.html files well.
>
> Some of the contents of the `package.html` files (and code in the package)
> may be outdated, but I think it is out
On Tue, 14 Mar 2023 02:43:41 GMT, Chen Liang wrote:
> Summaries:
> 1. A few recommendations about updating the constant API is made at
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-March/000233.html
> and I may update this patch shall the API changes be integrated bef
On Thu, 21 Sep 2023 11:46:19 GMT, Adam Sotona wrote:
>> Chen Liang has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 14 commits:
>>
>> - Classfile object update
>> - Merge branch 'master'
On Sun, 17 Dec 2023 23:11:10 GMT, Chen Liang wrote:
>> Summaries:
>> 1. A few recommendations about updating the constant API is made at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-March/000233.html
>> and I may update this patch shall the API changes b
test/jdk/java/lang/instrument/asmlib/Instrumentor.java
>
>
> @asotona Would you mind reviewing?
Chen Liang has updated the pull request incrementally with one additional
commit since the last revision:
Fix the 2 failing tests and add notes
-
Changes:
- all: https://git.openjd
test/jdk/java/lang/instrument/asmlib/Instrumentor.java
>
>
> @asotona Would you mind reviewing?
Chen Liang has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 17 commits:
- Some tests don't work well with previews
- Update tests t
On Wed, 28 Jun 2023 07:02:17 GMT, Chen Liang wrote:
>> Summaries:
>> 1. A few recommendations about updating the constant API is made at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-March/000233.html
>> and I may update this patch shall the API changes b
On Wed, 28 Jun 2023 07:02:17 GMT, Chen Liang wrote:
>> Summaries:
>> 1. A few recommendations about updating the constant API is made at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-March/000233.html
>> and I may update this patch shall the API changes b
On Tue, 12 Sep 2023 21:57:31 GMT, Justin Lu wrote:
> JDK .properties files still use ISO-8859-1 encoding with escape sequences. It
> would improve readability to see the native characters instead of escape
> sequences (especially for the L10n process). The majority of files changed
> are local
On Wed, 12 Jul 2023 13:49:17 GMT, Daohan Qu wrote:
> This patch should fix the wrong CP index for `invokedynamic` instruction
> generated by SA's `ClassWriter`. The buggy code in
> `sun.jvm.hotspot.tools.jcore.ByteCodeRewriter` should have been up-to-date
> with the following code snippet in `
test/jdk/java/lang/instrument/asmlib/Instrumentor.java
>
>
> @asotona Would you mind reviewing?
Chen Liang has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 14 commits:
- Classfile object update
- Merge branch 'master' into
On Tue, 9 May 2023 04:17:28 GMT, Chen Liang wrote:
>> Summaries:
>> 1. A few recommendations about updating the constant API is made at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-March/000233.html
>> and I may update this patch shall the API changes b
On Mon, 15 May 2023 08:38:54 GMT, Adam Sotona wrote:
> Package `jdk.internal.classfile.java.lang.constant` containing `ModuleDesc`
> and `PackageDesc` become obsolete after
> [JDK-8306729](https://bugs.openjdk.org/browse/JDK-8306729).
> All references to `jdk.internal.classfile.java.lang.const
test/jdk/java/lang/instrument/asmlib/Instrumentor.java
>
>
> @asotona Would you mind reviewing?
Chen Liang has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 12 commits:
- Merge branch 'master' into invoke-test-classfile
-
On Tue, 21 Mar 2023 21:39:48 GMT, Chen Liang wrote:
>> Summaries:
>> 1. A few recommendations about updating the constant API is made at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-March/000233.html
>> and I may update this patch shall the API changes b
test/jdk/java/lang/instrument/asmlib/Instrumentor.java
>
>
> @asotona Would you mind reviewing?
Chen Liang has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 11 commits:
- Switch to ConstantDescs for and void constants
- Merge Ann
test/jdk/java/lang/instrument/asmlib/Instrumentor.java
>
>
> @asotona Would you mind reviewing?
Chen Liang has updated the pull request incrementally with one additional
commit since the last revision:
Update test/jdk/java/lang/invoke/8022701/MHIllegalAccess.java
Co-authored-by: Andrey Turb
On Thu, 16 Mar 2023 14:50:14 GMT, Alan Bateman wrote:
>> test/jdk/java/util/ServiceLoader/BadProvidersTest.java line 216:
>>
>>> 214: clb.withSuperclass(CD_Object);
>>> 215: clb.withFlags(AccessFlag.PUBLIC, AccessFlag.SUPER);
>>> 216: var provider$1Desc = Clas
test/jdk/java/lang/instrument/asmlib/Instrumentor.java
>
>
> @asotona Would you mind reviewing?
Chen Liang has updated the pull request incrementally with one additional
commit since the last revision:
Fix LambdaStackTrace after running
-
Changes:
- all: https://git.openjdk.org
test/jdk/java/lang/instrument/asmlib/Instrumentor.java
>
>
> @asotona Would you mind reviewing?
Chen Liang has updated the pull request incrementally with one additional
commit since the last revision:
formatting
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13009/files
test/jdk/java/lang/instrument/asmlib/Instrumentor.java
>
>
> @asotona Would you mind reviewing?
Chen Liang has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request con
30 matches
Mail list logo
