On Mon, 26 Feb 2024 11:24:13 GMT, Suchismith Roy wrote:
>> J2SE agent does not start and throws error when it tries to find the shared
>> library ibm_16_am.
>> After searching for ibm_16_am.so ,the jvm agent throws and error as dll_load
>> fails.It fails to identify the shared library ibm_16_am
On Mon, 19 Feb 2024 13:00:01 GMT, Suchismith Roy wrote:
>> Suchi, errno is a global static variable. If some runtime API sets it, it
>> will continue to have this value until the next runtime call updates it. If
>> you call dll_load_library, there are many execution paths not passing
>> dlopen
On Mon, 19 Feb 2024 11:11:23 GMT, Suchismith Roy wrote:
>> src/hotspot/os/aix/os_aix.cpp line 1181:
>>
>>> 1179: // First try to load the existing file.
>>> 1180: result = dll_load_library(filename, ebuf, ebuflen);
>>> 1181: int error_code = errno;
>>
>> this might not necessarily be the
On Mon, 19 Feb 2024 10:05:17 GMT, Suchismith Roy wrote:
>> J2SE agent does not start and throws error when it tries to find the shared
>> library ibm_16_am.
>> After searching for ibm_16_am.so ,the jvm agent throws and error as dll_load
>> fails.It fails to identify the shared library ibm_16_am
On Mon, 12 Feb 2024 18:04:21 GMT, Suchismith Roy wrote:
>> J2SE agent does not start and throws error when it tries to find the shared
>> library ibm_16_am.
>> After searching for ibm_16_am.so ,the jvm agent throws and error as dll_load
>> fails.It fails to identify the shared library ibm_16_am
On Thu, 8 Feb 2024 14:47:26 GMT, Joachim Kern wrote:
>> And also `#define statvfs statvfs64` is not necessary with the same
>> explanation as for the `opendir` defines above -- sorry again.
>> The very only difference between statvfs and statvfs64 is that the
>> filesy
On Thu, 8 Feb 2024 09:03:10 GMT, Joachim Kern wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Once more, remove AIX dirent64 et al defines
>
> And also `#define statvfs statvf
On Thu, 8 Feb 2024 11:01:25 GMT, Suchismith Roy wrote:
> > > > > > May be this is academical: Your code works for plain libraries
> > > > > > replacing the .so extension by .a. Suppose the case the goal is to
> > > > > > load a member of an archive libname.a(member.o), but as in the
> > > > >
On Thu, 8 Feb 2024 10:38:37 GMT, Suchismith Roy wrote:
> > > > May be this is academical: Your code works for plain libraries
> > > > replacing the .so extension by .a. Suppose the case the goal is to load
> > > > a member of an archive libname.a(member.o), but as in the plain case
> > > > you
On Thu, 8 Feb 2024 10:22:53 GMT, Suchismith Roy wrote:
> > May be this is academical: Your code works for plain libraries replacing
> > the .so extension by .a. Suppose the case the goal is to load a member of
> > an archive libname.a(member.o), but as in the plain case you get as input
> > li
On Thu, 8 Feb 2024 09:59:11 GMT, Suchismith Roy wrote:
>> J2SE agent does not start and throws error when it tries to find the shared
>> library ibm_16_am.
>> After searching for ibm_16_am.so ,the jvm agent throws and error as dll_load
>> fails.It fails to identify the shared library ibm_16_am.
On Thu, 8 Feb 2024 07:44:18 GMT, Magnus Ihse Bursie wrote:
>> Similar to [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we
>> should use -D_FILE_OFFSET_BITS=64, and not -D_LARGEFILE64_SOURCE in the JDK
>> native libraries.
>
> Magnus Ihse Bursie has updated the pull request increme
On Tue, 6 Feb 2024 08:18:14 GMT, Magnus Ihse Bursie wrote:
>> Similar to [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we
>> should use -D_FILE_OFFSET_BITS=64, and not -D_LARGEFILE64_SOURCE in the JDK
>> native libraries.
>
> Magnus Ihse Bursie has updated the pull request increme
On Tue, 6 Feb 2024 08:45:12 GMT, Suchismith Roy wrote:
>> J2SE agent does not start and throws error when it tries to find the shared
>> library ibm_16_am.
>> After searching for ibm_16_am.so ,the jvm agent throws and error as dll_load
>> fails.It fails to identify the shared library ibm_16_am.
On Mon, 5 Feb 2024 12:07:45 GMT, Matthias Baesken wrote:
> Current commit compiles nicely on AIX. One issue we might still have
> statvfs/statvfs64 is not mentioned here in the table of functions/structs
> redefined on AIX
> https://www.ibm.com/docs/en/aix/7.1?topic=volumes-writing-programs-th
On Wed, 31 Jan 2024 07:42:49 GMT, Suchismith Roy wrote:
>> src/hotspot/os/aix/os_aix.cpp line 1166:
>>
>>> 1164: Search order:
>>> 1165: libfilename-> load "libfilename.so" first,then load libfilename.a,on
>>> failure.
>>> 1166: In,OpenJ9,the libary with .so extension is loaded first and th
On Sat, 27 Jan 2024 17:38:59 GMT, Suchismith Roy wrote:
>> J2SE agent does not start and throws error when it tries to find the shared
>> library ibm_16_am.
>> After searching for ibm_16_am.so ,the jvm agent throws and error as dll_load
>> fails.It fails to identify the shared library ibm_16_am
On Thu, 11 Jan 2024 15:46:59 GMT, Joachim Kern wrote:
> In parseAllowedMask in socketTransport.c, prefixLen of mask is compared with
> a maxValue (32 for IPv4, 128 otherwise). This fails if it is larger than 32,
> because getaddrinfo seems to detect IPv4 family, if IPv6 address has
On Tue, 16 Jan 2024 08:43:34 GMT, Suchismith Roy wrote:
>> src/hotspot/os/aix/os_aix.cpp line 1168:
>>
>>> 1166: int extension_length = 3;
>>> 1167: char* file_path = NEW_C_HEAP_ARRAY(char, buffer_length +
>>> extension_length + 1, mtInternal);
>>> 1168: strncpy(file_path,filename, buffer
On Fri, 12 Jan 2024 21:22:35 GMT, Alex Menkov wrote:
>> Joachim Kern has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> following proposals of alexmenkov
>
> src/jdk.jdwp.agent/share/native/libdt_soc
ke the wrong maxValue.
Joachim Kern has updated the pull request incrementally with one additional
commit since the last revision:
cosmetic changes
-
Changes:
- all: https://git.openjdk.org/jdk/pull/17374/files
- new: https://git.openjdk.org/jdk/pull/17374/files/0266dc12..f31e1
On Thu, 11 Jan 2024 16:14:39 GMT, Joachim Kern wrote:
>> In parseAllowedMask in socketTransport.c, prefixLen of mask is compared with
>> a maxValue (32 for IPv4, 128 otherwise). This fails if it is larger than
>> 32, because getaddrinfo seems to detect IPv4 family, if IP
ke the wrong maxValue.
Joachim Kern has updated the pull request incrementally with one additional
commit since the last revision:
following proposals of alexmenkov
-
Changes:
- all: https://git.openjdk.org/jdk/pull/17374/files
- new: https://git.openjdk.org/jdk/pull/17374/fi
ke the wrong maxValue.
Joachim Kern has updated the pull request incrementally with one additional
commit since the last revision:
cosmetic changes
-
Changes:
- all: https://git.openjdk.org/jdk/pull/17374/files
- new: https://git.openjdk.org/jdk/pull/17374/files/cbc56dd4..a5bfd
On Thu, 11 Jan 2024 16:00:45 GMT, Matthias Baesken wrote:
>> Joachim Kern has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> cosmetic changes
>
> src/jdk.jdwp.agent/share/native/libdt_socket/socketT
In parseAllowedMask in socketTransport.c, prefixLen of mask is compared with a
maxValue (32 for IPv4, 128 otherwise). This fails if it is larger than 32,
because getaddrinfo seems to detect IPv4 family, if IPv6 address has set only
some of the last 32 Bits. So we take the wrong maxValue.
-
On Fri, 1 Dec 2023 11:33:46 GMT, Joachim Kern wrote:
> On AIX, repeated calls to dlopen referring to the same shared library may
> result in different, unique dl handles to be returned from libc. In that it
> differs from typical libc implementations that cache dl handles.
>
&
it is implemented on other platforms,
> and this works for all callers of os::dll_load.
Joachim Kern has updated the pull request incrementally with two additional
commits since the last revision:
- cosmetic changes
- cosmetic changes
-
Changes:
- all: https://git.openj
it is implemented on other platforms,
> and this works for all callers of os::dll_load.
Joachim Kern has updated the pull request incrementally with one additional
commit since the last revision:
No need for malloc
-
Changes:
- all: https://git.openjdk.org/jdk/pull/169
it is implemented on other platforms,
> and this works for all callers of os::dll_load.
Joachim Kern has updated the pull request incrementally with one additional
commit since the last revision:
additional fix of sideeffect reported in JDK-8322691
-
Changes:
- all: https
On Thu, 21 Dec 2023 10:17:18 GMT, Martin Doerr wrote:
>> Let's keep it simple. A linear array of only a few items is easily scanned,
>> probably faster than pointer hopping hash table entries. Not that it matters
>> in any way for the few calls to dlopen.
>>
>> Also, avoiding hotspot structure
it is implemented on other platforms,
> and this works for all callers of os::dll_load.
Joachim Kern has updated the pull request incrementally with one additional
commit since the last revision:
cosmetic changes
-
Changes:
- all: https://git.openjdk.org/jdk/pull/169
On Wed, 20 Dec 2023 23:45:16 GMT, Martin Doerr wrote:
>> Joachim Kern has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> improve error handling
>
> src/hotspot/os/aix/porting_aix.cpp line 916:
>
>
On Wed, 20 Dec 2023 23:10:29 GMT, Martin Doerr wrote:
>> Joachim Kern has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> improve error handling
>
> src/hotspot/os/aix/porting_aix.cpp line 25:
>
>>
it is implemented on other platforms,
> and this works for all callers of os::dll_load.
Joachim Kern has updated the pull request incrementally with one additional
commit since the last revision:
improve error handling
-
Changes:
- all: https://git.openjdk.org/jdk/pull/169
On Wed, 20 Dec 2023 11:16:03 GMT, Suchismith Roy wrote:
>> J2SE agent does not start and throws error when it tries to find the shared
>> library ibm_16_am.
>> After searching for ibm_16_am.so ,the jvm agent throws and error as dll_load
>> fails.It fails to identify the shared library ibm_16_am
On Tue, 19 Dec 2023 12:37:33 GMT, Suchismith Roy wrote:
>> The libpath parsing code is from me, so no license problems.
>
> Hi @JoKern65 Is this good to integrate now ?
Hi @suchismith1993, I'm waiting for a second review. Complex hotspot changes
should be reviewed twice.
-
PR Com
On Mon, 18 Dec 2023 10:19:24 GMT, Thomas Stuefe wrote:
>> Joachim Kern has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - trailing whitespace
>> - Following most of Thomas proposals
>
> src/hots
On Mon, 18 Dec 2023 10:25:50 GMT, Thomas Stuefe wrote:
>> Joachim Kern has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - trailing whitespace
>> - Following most of Thomas proposals
>
> src/hotspot
On Mon, 18 Dec 2023 10:16:07 GMT, Thomas Stuefe wrote:
>> Joachim Kern has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - trailing whitespace
>> - Following most of Thomas proposals
>
> src/hots
On Mon, 18 Dec 2023 10:54:31 GMT, Thomas Stuefe wrote:
>> Yes it is, It's the fallback if LIBPATH is not defined
>
> In that case there may be errors in other places, since so far we assumed its
> either one or the other, but not both. Example:
>
> https://github.com/openjdk/jdk/blob/a247d0c74b
it is implemented on other platforms,
> and this works for all callers of os::dll_load.
Joachim Kern has updated the pull request incrementally with one additional
commit since the last revision:
cosmetic changes
-
Changes:
- all: https://git.openjdk.org/jdk/pull/169
it is implemented on other platforms,
> and this works for all callers of os::dll_load.
Joachim Kern has updated the pull request incrementally with one additional
commit since the last revision:
Followed Thomas proposals
-
Changes:
- all: https://git.openjdk.org/jd
On Mon, 18 Dec 2023 10:14:42 GMT, Thomas Stuefe wrote:
>> Joachim Kern has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - trailing whitespace
>> - Following most of Thomas proposals
>
> src/hot
On Tue, 12 Dec 2023 14:05:48 GMT, Joachim Kern wrote:
>> On AIX, repeated calls to dlopen referring to the same shared library may
>> result in different, unique dl handles to be returned from libc. In that it
>> differs from typical libc implementations that cache dl ha
it is implemented on other platforms,
> and this works for all callers of os::dll_load.
Joachim Kern has updated the pull request incrementally with two additional
commits since the last revision:
- trailing whitespace
- Following most of Thomas proposals
-
Changes:
- all:
On Fri, 15 Dec 2023 07:27:14 GMT, Thomas Stuefe wrote:
>> Joachim Kern has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> followed the proposals
>
> src/hotspot/os/aix/os_aix.cpp line 1234:
>
>>
On Fri, 15 Dec 2023 07:20:47 GMT, Thomas Stuefe wrote:
>> Joachim Kern has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> followed the proposals
>
> src/hotspot/os/aix/os_aix.cpp line 1187:
>
>> 1
On Fri, 15 Dec 2023 07:01:06 GMT, Thomas Stuefe wrote:
>> Joachim Kern has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> followed the proposals
>
> src/hotspot/os/aix/os_aix.cpp line 1174:
>
>> 117
On Fri, 15 Dec 2023 06:15:56 GMT, Thomas Stuefe wrote:
>> Joachim Kern has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> followed the proposals
>
> src/hotspot/os/aix/os_aix.cpp line 1135:
>
>>
On Fri, 15 Dec 2023 06:15:15 GMT, Thomas Stuefe wrote:
>> Joachim Kern has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> followed the proposals
>
> src/hotspot/os/aix/os_aix.cpp line 206:
>
>> 20
On Fri, 15 Dec 2023 06:44:03 GMT, Thomas Stuefe wrote:
>> src/hotspot/os/aix/os_aix.cpp line 1129:
>>
>>> 1127:
>>> 1128: // get the library search path burned in to the executable file
>>> during linking
>>> 1129: // If the libpath cannot be retrieved return an empty path
>>
>> This is new.
it is implemented on other platforms,
> and this works for all callers of os::dll_load.
Joachim Kern has updated the pull request incrementally with one additional
commit since the last revision:
followed the proposals
-
Changes:
- all: https://git.openjdk.org/jdk/pull/169
it is implemented on other platforms,
> and this works for all callers of os::dll_load.
Joachim Kern has updated the pull request incrementally with one additional
commit since the last revision:
encapsulate everything in os::Aix::dlopen
-
Changes:
- all: https://git.openj
it is implemented on other platforms,
> and this works for all callers of os::dll_load.
Joachim Kern has updated the pull request incrementally with one additional
commit since the last revision:
improve handling of nonexisting files
-
Changes:
- all: https://git.openj
On AIX, repeated calls to dlopen referring to the same shared library may
result in different, unique dl handles to be returned from libc. In that it
differs from typical libc implementations that cache dl handles.
This causes problems in the JVM with code that assumes equality of handles. One
On Fri, 15 Sep 2023 07:22:32 GMT, Joachim Kern wrote:
>> After push of [JDK-8307478](https://bugs.openjdk.org/browse/JDK-8307478) ,
>> the following test started to fail on AIX :
>> com/sun/tools/attach/warnings/DynamicLoadWarningTest.java;
>> The problem was descr
On Mon, 27 Nov 2023 13:23:42 GMT, Thomas Stuefe wrote:
>> Joachim Kern has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> adopt types
>
> This now causes problems with
>
> https://github.com/openjdk/jd
On Wed, 6 Sep 2023 08:18:45 GMT, Joachim Kern wrote:
> After push of [JDK-8307478](https://bugs.openjdk.org/browse/JDK-8307478) ,
> the following test started to fail on AIX :
> com/sun/tools/attach/warnings/DynamicLoadWarningTest.java;
> The problem was described in
> [JDK
get
> this information which is then stored parallel to the library handle in the
> jvmtiAgent. For AIX we then can compare these values instead of the library
> handle and get the same functionality as on linux.
Joachim Kern has updated the pull request incrementally with one addi
On Fri, 15 Sep 2023 02:01:26 GMT, David Holmes wrote:
>> Joachim Kern has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Merge remote-tracking branch 'origin/JDK-8315706' into JDK-8315706
>> -
On Thu, 14 Sep 2023 12:32:18 GMT, Joachim Kern wrote:
>> After push of [JDK-8307478](https://bugs.openjdk.org/browse/JDK-8307478) ,
>> the following test started to fail on AIX :
>> com/sun/tools/attach/warnings/DynamicLoadWarningTest.java;
>> The problem was descr
get
> this information which is then stored parallel to the library handle in the
> jvmtiAgent. For AIX we then can compare these values instead of the library
> handle and get the same functionality as on linux.
Joachim Kern has updated the pull request incrementally with two additio
On Thu, 14 Sep 2023 09:40:54 GMT, Alan Bateman wrote:
>> Joachim Kern has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contain
get
> this information which is then stored parallel to the library handle in the
> jvmtiAgent. For AIX we then can compare these values instead of the library
> handle and get the same functionality as on linux.
Joachim Kern has updated the pull request with a new target base due to a m
On Wed, 13 Sep 2023 15:30:22 GMT, Joachim Kern wrote:
>> After push of [JDK-8307478](https://bugs.openjdk.org/browse/JDK-8307478) ,
>> the following test started to fail on AIX :
>> com/sun/tools/attach/warnings/DynamicLoadWarningTest.java;
>> The problem was descr
get
> this information which is then stored parallel to the library handle in the
> jvmtiAgent. For AIX we then can compare these values instead of the library
> handle and get the same functionality as on linux.
Joachim Kern has updated the pull request incrementally with one additional
On Tue, 12 Sep 2023 04:59:13 GMT, David Holmes wrote:
>> Joachim Kern has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> try to improve code following Davids suggestions and do some cosmetic
>> chang
68 matches
Mail list logo
