On Fri, 15 Dec 2023 06:15:15 GMT, Thomas Stuefe <[email protected]> wrote:
>> Joachim Kern has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> followed the proposals
>
> src/hotspot/os/aix/os_aix.cpp line 206:
>
>> 204: constexpr int max_handletable = 1024;
>> 205: static int g_handletable_used = 0;
>> 206: static struct handletableentry g_handletable[max_handletable] = {{0, 0,
>> 0, 0}};
>
> I would move all that new and clearly delineated dlopen stuff into an own
> file, e.g. dlopen_aix.cpp or porting_aix.cpp (in porting_aix.cpp, we already
> have wrappers for other functions). os_aix.cpp is already massive.
I moved the static variable declarations and the functions `Aix_dlopen(),
search_file_in_LIBPATH(), rtv_linkedin_libpath()` and `os::pd_dll_unload()` to
porting_aix.cpp. This links, but in my opinion `os::pd_dll_unload()` should
reside in os_aix.cpp, because it is member of the os class. But there it will
not compile anymore if the static variables are moved away.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16920#discussion_r1427803856
