On Mon, 31 Jul 2023 01:50:07 GMT, Jonathan Joo wrote:
> 8315149: Add hsperf counters for CPU time of internal GC threads
This pull request has now been integrated.
Changeset: 9e570105
Author: Jonathan Joo
Committer: Man Cao
URL:
https://git.openjdk.org/jdk/com
On Fri, 1 Dec 2023 14:42:22 GMT, Albert Mingkun Yang wrote:
>> I would say it depends on the use-case and here when switching to use static
>> functions to use the instance it felt more like an all-static class. I agree
>> that it would be nice to avoid the additional memory usage if `UsePerfDa
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request incrementally with two additional
commits since the last revision:
- Only create CPUTimeCounters if supported
- Ensure TTTC is destructed before publishing
-
Chan
On Fri, 1 Dec 2023 16:19:49 GMT, Volker Simonis wrote:
>> src/hotspot/share/gc/parallel/parallelScavengeHeap.cpp line 905:
>>
>>> 903: gc_threads_do(&tttc);
>>> 904:
>>> 905: CPUTimeCounters::publish_gc_total_cpu_time();
>>
>> As I suggested in the other comment, maybe we should not keep t
On Fri, 1 Dec 2023 21:01:29 GMT, Man Cao wrote:
>> I agree that the counter is valuable if always up-to-date, but if it is out
>> of sync compared to the "concurrent counters" I think it will confuse some
>> users. So if we want to keep it I think we should try to keep it in sync.
>>
>> I sup
On Thu, 30 Nov 2023 09:30:14 GMT, Stefan Johansson wrote:
>> Both `publish_gc_total_cpu_time` and `~ThreadTotalCPUTimeClosure` are called
>> by the vm-thread inside a safepoint, so there shouldn't be any other threads
>> running simultaneously, I believe.
>
> Me and Albert just spoke and we do
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request incrementally with one additional
commit since the last revision:
Return after ShouldNotReachHere
Co-authored-by: Stefan Johansson <54407259+kstef...@users.noreply.gith
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request incrementally with one additional
commit since the last revision:
Add missing include
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15082/files
- new: ht
On Wed, 29 Nov 2023 15:24:52 GMT, Albert Mingkun Yang wrote:
>> src/hotspot/share/runtime/cpuTimeCounters.cpp line 91:
>>
>>> 89: } while (old_value != fetched_value);
>>> 90: get_counter(CPUTimeGroups::CPUTimeType::gc_total)->inc(fetched_value);
>>> 91: }
>>
>> Why do we have to do this pu
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request incrementally with one additional
commit since the last revision:
fix whitespace again
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15082/files
- new: ht
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 56 commits:
- Merge branch 'openjdk:master' into master
- remove whitespace
- Change A
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request incrementally with one additional
commit since the last revision:
remove whitespace
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15082/files
- new: ht
On Wed, 29 Nov 2023 15:23:55 GMT, Albert Mingkun Yang wrote:
>> We could add a new closure just used by GC that 's a sub-class of
>> `ThreadTotalCPUTimeClosure` and just adds this to the constructor:
>>
>> instance->inc_gc_total_cpu_time(net_cpu_time);
>>
>>
>> That way we could get rid of `
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request incrementally with one additional
commit since the last revision:
Change APIs to be all-static, address other comments
-
Changes:
- all: https://git.openjdk.org/
On Thu, 23 Nov 2023 12:43:00 GMT, Albert Mingkun Yang wrote:
>> Jonathan Joo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Cleanup and address comments
>
> src/hotspot/share/gc/g1/g1CollectedHeap.cpp line
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request incrementally with two additional
commits since the last revision:
- Fix namespace issues (2)
Co-authored-by: Stefan Johansson <54407259+kstef...@users.noreply.github.com&g
On Tue, 21 Nov 2023 21:42:39 GMT, Jonathan Joo wrote:
>> 8315149: Add hsperf counters for CPU time of internal GC threads
>
> Jonathan Joo has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Update memory tracking typ
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request incrementally with one additional
commit since the last revision:
Cleanup and address comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15082/files
-
On Tue, 21 Nov 2023 21:42:39 GMT, Jonathan Joo wrote:
>> 8315149: Add hsperf counters for CPU time of internal GC threads
>
> Jonathan Joo has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Update memory tracking typ
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request incrementally with two additional
commits since the last revision:
- Update memory tracking type for CPUTimeCounters
- Fix assertion logic
-
Changes:
- all: ht
On Wed, 15 Nov 2023 23:50:02 GMT, Jonathan Joo wrote:
>> 8315149: Add hsperf counters for CPU time of internal GC threads
>
> Jonathan Joo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix whitespace
Addressed com
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request incrementally with one additional
commit since the last revision:
Address comments and refactor TTTC class for simplification
-
Changes:
- all: https://git.openjdk.
On Wed, 15 Nov 2023 09:36:47 GMT, Stefan Johansson wrote:
>> Jonathan Joo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update parallel workers time after Remark
>
> Thanks for addressing my comm
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request incrementally with one additional
commit since the last revision:
Fix whitespace
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15082/files
- new: ht
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request incrementally with two additional
commits since the last revision:
- Move vm and conc_dedup counters to cpuTimeCounters class
- Revert test changes and fix whitespace iss
On Sat, 11 Nov 2023 00:23:28 GMT, Jonathan Joo wrote:
>> 8315149: Add hsperf counters for CPU time of internal GC threads
>
> Jonathan Joo has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Refactor ConcurrentR
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request incrementally with one additional
commit since the last revision:
Update parallel workers time after Remark
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15
On Sat, 11 Nov 2023 00:23:28 GMT, Jonathan Joo wrote:
>> 8315149: Add hsperf counters for CPU time of internal GC threads
>
> Jonathan Joo has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Refactor ConcurrentR
On Thu, 9 Nov 2023 10:29:29 GMT, Stefan Johansson wrote:
>> Jonathan Joo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add missing cpuTimeCounters files
>
> src/hotspot/share/gc/g1/g1ConcurrentRefine
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request incrementally with two additional
commits since the last revision:
- Refactor ConcurrentRefine logic
- Make CPUTimeCounters a singleton class
-
Changes:
- all: ht
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request incrementally with one additional
commit since the last revision:
Add missing cpuTimeCounters files
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15082/fi
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request incrementally with one additional
commit since the last revision:
Refactor changes to counters, successful build
-
Changes:
- all: https://git.openjdk.org/jdk/p
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request incrementally with one additional
commit since the last revision:
Attempt to fix duplicate name error in test
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15
On Wed, 1 Nov 2023 09:34:01 GMT, Stefan Johansson wrote:
>> Jonathan Joo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Replace NULL with nullptr
>
> Sorry for being a bit late to this PR. I think the ad
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request incrementally with two additional
commits since the last revision:
- revert gitignore change
- Attempt to fix broken test
-
Changes:
- all: https://git.openjdk.org/
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains 36 additional comm
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request incrementally with one additional
commit since the last revision:
Replace NULL with nullptr
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15082/files
-
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request incrementally with one additional
commit since the last revision:
Implement hsperf counter for G1ServiceThread
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15
On Fri, 27 Oct 2023 14:00:43 GMT, Albert Mingkun Yang wrote:
> Okay, these counters can be accessed frequently, but is it necessary for them
> to provide up-to-date information on every access? If not, what level of
> delay is acceptable? I assume this depends on how often AHS resizes the heap.
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request incrementally with one additional
commit since the last revision:
Remove StringDedup from GC thread list
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15082/fi
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request incrementally with one additional
commit since the last revision:
Use 64-bit atomic add for incrementing counters
-
Changes:
- all: https://git.openjdk.org/jdk/p
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains 31 additional comm
On Wed, 11 Oct 2023 22:25:04 GMT, Man Cao wrote:
>> src/hotspot/share/runtime/perfData.hpp line 64:
>>
>>> 62: COM_THREADS,
>>> 63: SUN_THREADS,
>>> 64: SUN_THREADS_GCCPU,// Subsystem for Sun Threads GC CPU
>>
>> Really not sure about this naming ...
>
> +1, dropping the "GC" seems b
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request incrementally with one additional
commit since the last revision:
Add call to publish in parallel gc and update counter names
-
Changes:
- all: https://git.openjdk.
On Wed, 11 Oct 2023 23:23:11 GMT, Man Cao wrote:
>> Jonathan Joo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add comment and change if defined to ifdef
>
> src/hotspot/share/gc/shared/collect
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request incrementally with one additional
commit since the last revision:
Add Copyright header to test and formatting changes
-
Changes:
- all: https://git.openjdk.org/jdk/p
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request incrementally with one additional
commit since the last revision:
Fix test
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15082/files
- new: ht
On Thu, 5 Oct 2023 03:00:36 GMT, Jonathan Joo wrote:
>> 8315149: Add hsperf counters for CPU time of internal GC threads
>
> Jonathan Joo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> add comment and change if defin
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request incrementally with one additional
commit since the last revision:
add comment and change if defined to ifdef
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request incrementally with one additional
commit since the last revision:
Remove header and fix long to jlong
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15082/fi
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request incrementally with one additional
commit since the last revision:
Update logic to use cmpxchg rather than add
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request incrementally with one additional
commit since the last revision:
Fix build issues
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15082/files
- new: ht
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request incrementally with one additional
commit since the last revision:
Fix logic for publishing total cpu time and convert atomic jlong to long
-
Changes:
- all: ht
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request incrementally with one additional
commit since the last revision:
Fix more broken headers for sanity checks
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request incrementally with one additional
commit since the last revision:
Add more header files for broken debug build
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request incrementally with one additional
commit since the last revision:
Add header for failing build check
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15082/fi
On Fri, 15 Sep 2023 01:29:57 GMT, David Holmes wrote:
>> Jonathan Joo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Clean up test and improve total counter name
>
> test/jdk/sun/tools/jcmd/TestGcC
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request incrementally with one additional
commit since the last revision:
Address dholmes@ comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15082/files
-
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request incrementally with one additional
commit since the last revision:
Clean up test and improve total counter name
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request incrementally with one additional
commit since the last revision:
Add unit test to check existence of GC CPU counters
-
Changes:
- all: https://git.openjdk.org/jdk/p
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request incrementally with one additional
commit since the last revision:
Fix segfaults on build
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15082/files
- new: ht
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request incrementally with one additional
commit since the last revision:
comment out lines that cause segfault
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15082/fi
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request incrementally with one additional
commit since the last revision:
Update to improve total time tracking
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15082/fi
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request incrementally with one additional
commit since the last revision:
Update total gc cpu implementation (still not finished)
-
Changes:
- all: https://git.openjdk.org/
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request incrementally with one additional
commit since the last revision:
Partial commit attempting to add total cpu tracker
-
Changes:
- all: https://git.openjdk.org/jdk/p
65 matches
Mail list logo
