On Wed, 15 Nov 2023 09:36:47 GMT, Stefan Johansson <sjoha...@openjdk.org> wrote:

>> Jonathan Joo has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Update parallel workers time after Remark
>
> Thanks for addressing my comments. I have a few more things:
> 
> - I think all changes to `test_g1ServiceThread.cpp` can be reverted. Should 
> not be needed now
> - Please fix all whitespace issues
> - Should we move the VMThread and StringDedup counters into `CPUTimeCounters` 
> as well? Any problem with this?

@kstefanj Good points - done!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15082#issuecomment-1813500906

Reply via email to