Re: RFR: 8339112: Move JVM Klass flags out of AccessFlags [v5]

2024-09-03 Thread Tobias Hartmann
On Fri, 30 Aug 2024 21:51:49 GMT, Coleen Phillimore wrote: >> Move JVM implementation access flags that are not specified by the classfile >> format into Klass so we can shrink AccessFlags to u2 in a future change. >> >> Tested with tier1-7. >> >> NOTE: there are arm, ppc and s390 changes to t

Re: RFR: 8336753: Don't run serviceability/sa/ClhsdbDumpheap.java with -Xcomp [v3]

2024-07-19 Thread Tobias Hartmann
On Fri, 19 Jul 2024 11:50:03 GMT, Daniel Lundén wrote: >> We are seeing quite a few timeouts for >> `serviceability/sa/ClhsdbDumpheap.java` running with -Xcomp in testing, >> possibly related to >> [JDK-8324241](https://bugs.openjdk.org/browse/JDK-8324241). We should >> disable running `Clhsd

Re: RFR: 8336753: Don't run serviceability/sa/ClhsdbDumpheap.java with -Xcomp [v2]

2024-07-19 Thread Tobias Hartmann
On Fri, 19 Jul 2024 09:50:43 GMT, Daniel Lundén wrote: >> test/hotspot/jtreg/serviceability/sa/ClhsdbDumpheap.java line 40: >> >>> 38: /** >>> 39: * @test >>> 40: * @bug 8240989 8336753 >> >> I don't think that change makes sense because the test is not a regression >> test for JDK-8336753.

Re: RFR: 8336753: Don't run serviceability/sa/ClhsdbDumpheap.java with -Xcomp [v2]

2024-07-19 Thread Tobias Hartmann
On Fri, 19 Jul 2024 09:31:01 GMT, Daniel Lundén wrote: >> We are seeing quite a few timeouts for >> `serviceability/sa/ClhsdbDumpheap.java` running with -Xcomp in testing, >> possibly related to >> [JDK-8324241](https://bugs.openjdk.org/browse/JDK-8324241). We should >> disable running `Clhsd

Re: RFR: 8336753: Don't run serviceability/sa/ClhsdbDumpheap.java with -Xcomp

2024-07-19 Thread Tobias Hartmann
On Thu, 18 Jul 2024 15:00:41 GMT, Daniel Lundén wrote: > We are seeing quite a few timeouts for > `serviceability/sa/ClhsdbDumpheap.java` running with -Xcomp in testing, > possibly related to > [JDK-8324241](https://bugs.openjdk.org/browse/JDK-8324241). We should disable > running `ClhsdbDump

Re: RFR: 8331087: Move immutable nmethod data from CodeCache [v2]

2024-04-28 Thread Tobias Hartmann
On Sun, 28 Apr 2024 23:37:22 GMT, Vladimir Kozlov wrote: >> Move immutable nmethod's data from CodeCache to C heap. It includes >> `dependencies, nul_chk_table, handler_table, scopes_pcs, scopes_data, >> speculations`. It amounts for about 30% (optimized VM) of space in CodeCache. >> >> Use Ho

Re: RFR: JDK-8318671: Potential uninitialized uintx value after JDK-8317683 [v4]

2023-11-13 Thread Tobias Hartmann
On Thu, 26 Oct 2023 16:17:14 GMT, Thomas Stuefe wrote: >> When using 'MemStat' CompileCommand, we accidentally register the command if >> an invalid suboption had been specified. Fixed, added regression test >> (verified). > > Thomas Stuefe has updated the pull request incrementally with one ad

Re: RFR: JDK-8318671: Potential uninitialized uintx value after JDK-8317683 [v4]

2023-10-31 Thread Tobias Hartmann
On Thu, 26 Oct 2023 16:17:14 GMT, Thomas Stuefe wrote: >> When using 'MemStat' CompileCommand, we accidentally register the command if >> an invalid suboption had been specified. Fixed, added regression test >> (verified). > > Thomas Stuefe has updated the pull request incrementally with one ad

Re: RFR: 8317446: ProblemList gc/arguments/TestNewSizeFlags.java on macosx-aarch64 in Xcomp

2023-10-04 Thread Tobias Hartmann
On Tue, 3 Oct 2023 17:53:27 GMT, Daniel D. Daugherty wrote: > Trivial fixes to ProblemList noisy tests in the JDK22 CI; > > [JDK-8317446](https://bugs.openjdk.org/browse/JDK-8317446) ProblemList > gc/arguments/TestNewSizeFlags.java on macosx-aarch64 in Xcomp > [JDK-8317448](https://bugs.openjdk

Re: RFR: 8317446: ProblemList gc/arguments/TestNewSizeFlags.java on macosx-aarch64 in Xcomp

2023-10-03 Thread Tobias Hartmann
On Tue, 3 Oct 2023 17:53:27 GMT, Daniel D. Daugherty wrote: > Trivial fixes to ProblemList noisy tests in the JDK22 CI; > > [JDK-8317446](https://bugs.openjdk.org/browse/JDK-8317446) ProblemList > gc/arguments/TestNewSizeFlags.java on macosx-aarch64 in Xcomp > [JDK-8317448](https://bugs.openjdk

Re: RFR: 8315717: ProblemList serviceability/sa/TestHeapDumpForInvokeDynamic.java with ZGC

2023-09-05 Thread Tobias Hartmann
On Tue, 5 Sep 2023 17:17:25 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > serviceability/sa/TestHeapDumpForInvokeDynamic.java with ZGC. Looks good and trivial. - Marked as reviewed by thartmann (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/15570#pullr

Re: RFR: 8307462: [REDO] VmObjectAlloc is not generated by intrinsics methods which allocate objects [v3]

2023-08-08 Thread Tobias Hartmann
On Fri, 4 Aug 2023 19:45:56 GMT, Leonid Mesnik wrote: >> The fix adds posting VmObjectAlloc events by >> Unsafe.allocateInstance(Class cls). The previous attempt to post event >> directly from 'LibraryCallKit::inline_unsafe_allocate()' cause performance >> regression even if jvmti event is not

Re: RFR: 8309044: Replace NULL with nullptr, final sweep of hotspot code [v2]

2023-06-01 Thread Tobias Hartmann
On Tue, 30 May 2023 19:15:38 GMT, Johan Sjölen wrote: >> A final sweep of Hotspot to remove all re-added NULLs. With only 110 changes >> I'd appreciate if this was considered trivial. > > Johan Sjölen has updated the pull request incrementally with two additional > commits since the last revisi

Re: RFR: 8309044: Replace NULL with nullptr, final sweep of hotspot code [v2]

2023-05-31 Thread Tobias Hartmann
On Tue, 30 May 2023 19:15:38 GMT, Johan Sjölen wrote: >> A final sweep of Hotspot to remove all re-added NULLs. With only 110 changes >> I'd appreciate if this was considered trivial. > > Johan Sjölen has updated the pull request incrementally with two additional > commits since the last revisi

Re: RFR: 8306326: [BACKOUT] 8277573: VmObjectAlloc is not generated by intrinsics methods which allocate objects [v2]

2023-05-04 Thread Tobias Hartmann
On Fri, 5 May 2023 01:06:09 GMT, Leonid Mesnik wrote: >> 8277573: VmObjectAlloc is not generated by intrinsics methods which allocate >> objects >> >> caused significant regressions in some benchmarks and should be reverted. >> >> This fix backout changes and update problemlist bugs to new iss

Re: RFR: 8301377: adjust timeout for JLI GetObjectSizeIntrinsicsTest.java subtest again

2023-04-23 Thread Tobias Hartmann
On Fri, 21 Apr 2023 21:35:07 GMT, Daniel D. Daugherty wrote: > Trivial fixes to increase timeouts for tests that timeout under heavy stress: > [JDK-8301377](https://bugs.openjdk.org/browse/JDK-8301377) adjust timeout for > JLI GetObjectSizeIntrinsicsTest.java subtest again > [JDK-8305502](https

Re: Integrated: 8305659: ProblemList com/sun/jdi/PopAndInvokeTest.java with virtual threads

2023-04-05 Thread Tobias Hartmann
On Wed, 5 Apr 2023 13:51:59 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList com/sun/jdi/PopAndInvokeTest.java with virtual > threads. Looks good with now updated bug id. - Marked as reviewed by thartmann (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/13351

Re: RFR: JDK-8301447: [REDO] CodeHeap has virtual methods that are not overridden

2023-02-01 Thread Tobias Hartmann
On Tue, 31 Jan 2023 14:30:29 GMT, Justin King wrote: > Redo [JDK-8301378](https://bugs.openjdk.org/browse/JDK-8301378), this time > also fixing the serviceability code. Looks good to me and Vladimir's testing all passed. - Marked as reviewed by thartmann (Reviewer). PR: https://g