On Tue, 30 May 2023 19:15:38 GMT, Johan Sjölen <jsjo...@openjdk.org> wrote:
>> A final sweep of Hotspot to remove all re-added NULLs. With only 110 changes >> I'd appreciate if this was considered trivial. > > Johan Sjölen has updated the pull request incrementally with two additional > commits since the last revision: > > - Align > - Suggestions I think if we just rely on reviews, NULLs will slip through again and we would need to have regular cleanup PRs. Doug's idea seems simple enough to implement in Skara/jcheck. An alternative to whitelisting would be a warning in the offending PR or a requirement for "special approvement" of such changes (for example, via a Skara command). ------------- PR Comment: https://git.openjdk.org/jdk/pull/14198#issuecomment-1573169963
