Re: RFR: 8291555: Implement alternative fast-locking scheme [v75]

2023-05-05 Thread Daniel D . Daugherty
On Fri, 5 May 2023 14:48:35 GMT, Daniel D. Daugherty wrote: >> Roman Kennke has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 172 commits: >> >> - Merge branch 'master' into JDK-8291555-v2 >> - Disable new lightweight locking in Z

Re: RFR: 8291555: Implement alternative fast-locking scheme [v75]

2023-05-05 Thread Roman Kennke
On Fri, 5 May 2023 14:53:32 GMT, Daniel D. Daugherty wrote: >> src/hotspot/cpu/aarch64/c1_LIRAssembler_aarch64.cpp line 2562: >> >>> 2560: Register lock = op->lock_opr()->as_register(); >>> 2561: if (LockingMode == LM_MONITOR) { >>> 2562: if (op->info() != null) { >> >> Hmmm... other pl

Re: RFR: 8291555: Implement alternative fast-locking scheme [v75]

2023-05-05 Thread Daniel D . Daugherty
On Fri, 5 May 2023 13:38:58 GMT, Roman Kennke wrote: >> This change adds a fast-locking scheme as an alternative to the current >> stack-locking implementation. It retains the advantages of stack-locking >> (namely fast locking in uncontended code-paths), while avoiding the overload >> of the

Re: RFR: 8291555: Implement alternative fast-locking scheme [v75]

2023-05-05 Thread Roman Kennke
> This change adds a fast-locking scheme as an alternative to the current > stack-locking implementation. It retains the advantages of stack-locking > (namely fast locking in uncontended code-paths), while avoiding the overload > of the mark word. That overloading causes massive problems with Li