On Fri, 16 Jun 2023 18:10:58 GMT, Chris Plummer wrote:
>> Ashutosh Mehra has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review comments by plummercj
>>
>> Signed-off-by: Ashutosh Mehra
>
> Yes, it is already problem listed
On Fri, 16 Jun 2023 18:10:58 GMT, Chris Plummer wrote:
>> Ashutosh Mehra has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review comments by plummercj
>>
>> Signed-off-by: Ashutosh Mehra
>
> Yes, it is already problem listed
On Thu, 22 Jun 2023 16:10:13 GMT, Ashutosh Mehra wrote:
> I am thinking of a comprehensive test that creates a classfile with specific
> attribute, load it in the VM, dump that class file using SA, then disassemble
> the generated class file to check for the presence of the attribute. We would
On Thu, 22 Jun 2023 03:21:33 GMT, Serguei Spitsyn wrote:
> Do we have any automatic test coverage for this?
Nope, I don't think there is any test for BootstrapMethods. As mentioned
[here](https://github.com/openjdk/jdk/pull/14556#issuecomment-1601946451) the
existing tests - ClhsdbDumpclass.ja
On Thu, 15 Jun 2023 20:24:39 GMT, Ashutosh Mehra wrote:
>> Please review this PR that extends SA to write BootstrapMethods attribute
>> when dumping the class files.
>>
>> Tested it by dumping the class file for java/lang/String and comparing the
>> BootstrapMethods attribute shown by javap fo
On Thu, 15 Jun 2023 20:24:39 GMT, Ashutosh Mehra wrote:
>> Please review this PR that extends SA to write BootstrapMethods attribute
>> when dumping the class files.
>>
>> Tested it by dumping the class file for java/lang/String and comparing the
>> BootstrapMethods attribute shown by javap fo
On Wed, 21 Jun 2023 13:32:55 GMT, Ashutosh Mehra wrote:
>> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/tools/jcore/ClassWriter.java
>> line 756:
>>
>>> 754: }
>>> 755: }
>>> 756: }
>>
>> Hi, it looks odd to me that we only write one short in the loop
On Wed, 21 Jun 2023 12:47:10 GMT, Kevin Walls wrote:
>> Ashutosh Mehra has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review comments by plummercj
>>
>> Signed-off-by: Ashutosh Mehra
>
> src/jdk.hotspot.agent/share/classes
On Thu, 15 Jun 2023 20:24:39 GMT, Ashutosh Mehra wrote:
>> Please review this PR that extends SA to write BootstrapMethods attribute
>> when dumping the class files.
>>
>> Tested it by dumping the class file for java/lang/String and comparing the
>> BootstrapMethods attribute shown by javap fo
On Fri, 16 Jun 2023 18:10:58 GMT, Chris Plummer wrote:
>> Ashutosh Mehra has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review comments by plummercj
>>
>> Signed-off-by: Ashutosh Mehra
>
> Yes, it is already problem listed
On Thu, 15 Jun 2023 20:24:39 GMT, Ashutosh Mehra wrote:
>> Please review this PR that extends SA to write BootstrapMethods attribute
>> when dumping the class files.
>>
>> Tested it by dumping the class file for java/lang/String and comparing the
>> BootstrapMethods attribute shown by javap fo
On Thu, 15 Jun 2023 20:24:39 GMT, Ashutosh Mehra wrote:
>> Please review this PR that extends SA to write BootstrapMethods attribute
>> when dumping the class files.
>>
>> Tested it by dumping the class file for java/lang/String and comparing the
>> BootstrapMethods attribute shown by javap fo
On Thu, 15 Jun 2023 23:20:56 GMT, Chris Plummer wrote:
>> Ashutosh Mehra has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review comments by plummercj
>>
>> Signed-off-by: Ashutosh Mehra
>
> Can you run the tests in `test/ho
On Thu, 15 Jun 2023 20:24:39 GMT, Ashutosh Mehra wrote:
>> Please review this PR that extends SA to write BootstrapMethods attribute
>> when dumping the class files.
>>
>> Tested it by dumping the class file for java/lang/String and comparing the
>> BootstrapMethods attribute shown by javap fo
On Thu, 15 Jun 2023 20:55:12 GMT, Chris Plummer wrote:
> Can you tell me what testing you've done? Would be best to call that out in
> the PR description.
Edited the description to add a comment about the testing. Hope this helps.
-
PR Comment: https://git.openjdk.org/jdk/pull/144
On Thu, 15 Jun 2023 20:24:39 GMT, Ashutosh Mehra wrote:
>> Please review this PR that extends SA to write BootstrapMethods attribute
>> when dumping the class files.
>
> Ashutosh Mehra has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addres
On Thu, 15 Jun 2023 20:24:39 GMT, Ashutosh Mehra wrote:
>> Please review this PR that extends SA to write BootstrapMethods attribute
>> when dumping the class files.
>
> Ashutosh Mehra has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addres
On Thu, 15 Jun 2023 18:15:41 GMT, Chris Plummer wrote:
>> Ashutosh Mehra has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review comments by plummercj
>>
>> Signed-off-by: Ashutosh Mehra
>
> src/jdk.hotspot.agent/share/class
> Please review this PR that extends SA to write BootstrapMethods attribute
> when dumping the class files.
Ashutosh Mehra has updated the pull request incrementally with one additional
commit since the last revision:
Address review comments by plummercj
Signed-off-by: Ashutosh Mehra
-
19 matches
Mail list logo
