On Fri, 30 Jun 2023 13:10:06 GMT, Coleen Phillimore wrote:
>> Please review change for mostly fixing return types in the constant pool and
>> metadata to fix -Wconversion warnings in JVMTI code. The order of
>> preference for changes are: 1. change the types to more distinct types
>> (fields
On 3/07/2023 10:55 am, David Holmes wrote:
On Fri, 30 Jun 2023 13:10:06 GMT, Coleen Phillimore wrote:
Please review change for mostly fixing return types in the constant pool and metadata
to fix -Wconversion warnings in JVMTI code. The order of preference for changes are:
1. change the type
On Fri, 30 Jun 2023 13:10:06 GMT, Coleen Phillimore wrote:
>> Please review change for mostly fixing return types in the constant pool and
>> metadata to fix -Wconversion warnings in JVMTI code. The order of
>> preference for changes are: 1. change the types to more distinct types
>> (fields
On Fri, 30 Jun 2023 13:10:06 GMT, Coleen Phillimore wrote:
>> Please review change for mostly fixing return types in the constant pool and
>> metadata to fix -Wconversion warnings in JVMTI code. The order of
>> preference for changes are: 1. change the types to more distinct types
>> (fields
On Fri, 30 Jun 2023 02:11:11 GMT, David Holmes wrote:
>> I had to change these two lines because BytecodeStream::get_index_u2 returns
>> an int, so got the warning and this didn't need to be declared with u2.
>> get_index_u2() could be fixed to return a u2 but I didn't want to go that
>> far
> Please review change for mostly fixing return types in the constant pool and
> metadata to fix -Wconversion warnings in JVMTI code. The order of preference
> for changes are: 1. change the types to more distinct types (fields in the
> constant pool are u2 because that's their size in the clas
