On Sun, 10 Sep 2023 21:35:39 GMT, Chris Plummer wrote:
>> Soumadipta Roy has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Changing the order of flags to maintain consistency.
>
> The changes look good, but I'd suggest adding a comment so
On Sun, 10 Sep 2023 21:35:39 GMT, Chris Plummer wrote:
> The changes look good, but I'd suggest adding a comment so the reader knows
> why these options were added.
Agreed. Something like:
"-Xmx512m", "-XX:MaxMetaspaceSize=64m",
"-XX:+CrashOnOutOfMemoryError",
On Fri, 8 Sep 2023 10:21:23 GMT, Soumadipta Roy wrote:
>> 8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with
>> -XX:-VerifyDependencies
>>
>> serviceability/sa/TestJmapCoreMetaspace.java runs in hotspot:tier2, and
>> takes about 330 seconds out of 670 seconds of the entire
On Fri, 8 Sep 2023 10:21:23 GMT, Soumadipta Roy wrote:
>> 8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with
>> -XX:-VerifyDependencies
>>
>> serviceability/sa/TestJmapCoreMetaspace.java runs in hotspot:tier2, and
>> takes about 330 seconds out of 670 seconds of the entire
On Fri, 8 Sep 2023 10:21:23 GMT, Soumadipta Roy wrote:
>> 8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with
>> -XX:-VerifyDependencies
>>
>> serviceability/sa/TestJmapCoreMetaspace.java runs in hotspot:tier2, and
>> takes about 330 seconds out of 670 seconds of the entire
On Fri, 8 Sep 2023 10:21:23 GMT, Soumadipta Roy wrote:
>> 8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with
>> -XX:-VerifyDependencies
>>
>> serviceability/sa/TestJmapCoreMetaspace.java runs in hotspot:tier2, and
>> takes about 330 seconds out of 670 seconds of the entire
On Fri, 8 Sep 2023 10:16:17 GMT, Soumadipta Roy wrote:
>> 8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with
>> -XX:-VerifyDependencies
>>
>> serviceability/sa/TestJmapCoreMetaspace.java runs in hotspot:tier2, and
>> takes about 330 seconds out of 670 seconds of the entire
> 8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with
> -XX:-VerifyDependencies
>
> serviceability/sa/TestJmapCoreMetaspace.java runs in hotspot:tier2, and takes
> about 330 seconds out of 670 seconds of the entire run on x86_64 fastdebug.
> The tier2 completion usually waits