Re: RFR: 8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with -XX:-VerifyDependencies [v2]

2023-09-11 Thread Soumadipta Roy
On Sun, 10 Sep 2023 21:35:39 GMT, Chris Plummer wrote: >> Soumadipta Roy has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Changing the order of flags to maintain consistency. > > The changes look good, but I'd suggest adding a comment so

Re: RFR: 8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with -XX:-VerifyDependencies [v2]

2023-09-11 Thread Aleksey Shipilev
On Sun, 10 Sep 2023 21:35:39 GMT, Chris Plummer wrote: > The changes look good, but I'd suggest adding a comment so the reader knows > why these options were added. Agreed. Something like: "-Xmx512m", "-XX:MaxMetaspaceSize=64m", "-XX:+CrashOnOutOfMemoryError",

Re: RFR: 8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with -XX:-VerifyDependencies [v2]

2023-09-10 Thread Leonid Mesnik
On Fri, 8 Sep 2023 10:21:23 GMT, Soumadipta Roy wrote: >> 8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with >> -XX:-VerifyDependencies >> >> serviceability/sa/TestJmapCoreMetaspace.java runs in hotspot:tier2, and >> takes about 330 seconds out of 670 seconds of the entire

Re: RFR: 8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with -XX:-VerifyDependencies [v2]

2023-09-10 Thread Chris Plummer
On Fri, 8 Sep 2023 10:21:23 GMT, Soumadipta Roy wrote: >> 8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with >> -XX:-VerifyDependencies >> >> serviceability/sa/TestJmapCoreMetaspace.java runs in hotspot:tier2, and >> takes about 330 seconds out of 670 seconds of the entire

Re: RFR: 8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with -XX:-VerifyDependencies [v2]

2023-09-08 Thread Kevin Walls
On Fri, 8 Sep 2023 10:21:23 GMT, Soumadipta Roy wrote: >> 8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with >> -XX:-VerifyDependencies >> >> serviceability/sa/TestJmapCoreMetaspace.java runs in hotspot:tier2, and >> takes about 330 seconds out of 670 seconds of the entire

Re: RFR: 8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with -XX:-VerifyDependencies [v2]

2023-09-08 Thread Kevin Walls
On Fri, 8 Sep 2023 10:21:23 GMT, Soumadipta Roy wrote: >> 8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with >> -XX:-VerifyDependencies >> >> serviceability/sa/TestJmapCoreMetaspace.java runs in hotspot:tier2, and >> takes about 330 seconds out of 670 seconds of the entire

Re: RFR: 8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with -XX:-VerifyDependencies [v2]

2023-09-08 Thread Aleksey Shipilev
On Fri, 8 Sep 2023 10:16:17 GMT, Soumadipta Roy wrote: >> 8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with >> -XX:-VerifyDependencies >> >> serviceability/sa/TestJmapCoreMetaspace.java runs in hotspot:tier2, and >> takes about 330 seconds out of 670 seconds of the entire

Re: RFR: 8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with -XX:-VerifyDependencies [v2]

2023-09-08 Thread Soumadipta Roy
> 8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with > -XX:-VerifyDependencies > > serviceability/sa/TestJmapCoreMetaspace.java runs in hotspot:tier2, and takes > about 330 seconds out of 670 seconds of the entire run on x86_64 fastdebug. > The tier2 completion usually waits