On Sun, 10 Sep 2023 21:35:39 GMT, Chris Plummer <[email protected]> wrote:
> The changes look good, but I'd suggest adding a comment so the reader knows
> why these options were added.
Agreed. Something like:
"-Xmx512m", "-XX:MaxMetaspaceSize=64m",
"-XX:+CrashOnOutOfMemoryError",
// The test loads lots of small classes to exhaust Metaspace,
skip method dependency
// verification to improve performance in debug builds.
"-XX:+IgnoreUnrecognizedVMOptions", "-XX:-VerifyDependencies",
CoreUtils.getAlwaysPretouchArg(true),
-------------
PR Comment: https://git.openjdk.org/jdk/pull/15631#issuecomment-1713464913
