Re: RFR: 8329674: JvmtiEnvThreadState::reset_current_location function should use JvmtiHandshake [v2]

2024-04-12 Thread Patricio Chilano Mateo
On Fri, 12 Apr 2024 01:22:04 GMT, Serguei Spitsyn wrote: >> Good question, thanks. >> The `JvmtiVTMSTransitionDisabler` is supposed to be installed in the >> caller's context if needed. >> However, it is not easy to make sure it is always the case. >> At least, I see a couple of contexts when

Re: RFR: 8329674: JvmtiEnvThreadState::reset_current_location function should use JvmtiHandshake [v2]

2024-04-11 Thread Serguei Spitsyn
On Thu, 11 Apr 2024 22:54:16 GMT, Serguei Spitsyn wrote: >> src/hotspot/share/prims/jvmtiEnvThreadState.cpp line 367: >> >>> 365: GetCurrentLocationClosure op; >>> 366: JvmtiHandshake::execute(, , thread, thread_h); >>> 367: >> >> Seems we are missing a

Re: RFR: 8329674: JvmtiEnvThreadState::reset_current_location function should use JvmtiHandshake [v2]

2024-04-11 Thread Serguei Spitsyn
On Thu, 11 Apr 2024 16:26:51 GMT, Patricio Chilano Mateo wrote: >> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review: refactored to get rid of overloaded doit functions > >

Re: RFR: 8329674: JvmtiEnvThreadState::reset_current_location function should use JvmtiHandshake [v2]

2024-04-11 Thread Serguei Spitsyn
On Thu, 11 Apr 2024 16:25:30 GMT, Patricio Chilano Mateo wrote: >> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review: refactored to get rid of overloaded doit functions > >

Re: RFR: 8329674: JvmtiEnvThreadState::reset_current_location function should use JvmtiHandshake [v2]

2024-04-11 Thread Serguei Spitsyn
On Thu, 11 Apr 2024 16:22:44 GMT, Patricio Chilano Mateo wrote: >> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review: refactored to get rid of overloaded doit functions > >

Re: RFR: 8329674: JvmtiEnvThreadState::reset_current_location function should use JvmtiHandshake [v2]

2024-04-11 Thread Patricio Chilano Mateo
On Wed, 10 Apr 2024 04:21:23 GMT, Serguei Spitsyn wrote: >> The internal JVM TI JvmtiHandshake and JvmtiUnitedHandshakeClosure classes >> were introduced in the JDK 22 to unify/simplify the JVM TI functions >> supporting implementation of the virtual threads. This enhancement is to >>

Re: RFR: 8329674: JvmtiEnvThreadState::reset_current_location function should use JvmtiHandshake [v2]

2024-04-10 Thread Leonid Mesnik
On Wed, 10 Apr 2024 04:21:23 GMT, Serguei Spitsyn wrote: >> The internal JVM TI JvmtiHandshake and JvmtiUnitedHandshakeClosure classes >> were introduced in the JDK 22 to unify/simplify the JVM TI functions >> supporting implementation of the virtual threads. This enhancement is to >>

Re: RFR: 8329674: JvmtiEnvThreadState::reset_current_location function should use JvmtiHandshake [v2]

2024-04-09 Thread Serguei Spitsyn
> The internal JVM TI JvmtiHandshake and JvmtiUnitedHandshakeClosure classes > were introduced in the JDK 22 to unify/simplify the JVM TI functions > supporting implementation of the virtual threads. This enhancement is to > refactor the JVM TI internal functions >