On Thu, 11 Apr 2024 16:22:44 GMT, Patricio Chilano Mateo
<[email protected]> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: refactored to get rid of overloaded doit functions
>
> src/hotspot/share/prims/jvmtiEnvThreadState.cpp line 307:
>
>> 305: if (!JvmtiEnvBase::is_vthread_alive(target_h())) {
>> 306: return; // _completed remains false.
>> 307: }
>
> Do we need this? We already do this check in JvmtiHandshake::execute().
Good suggestion, thanks. Will remove it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18630#discussion_r1561812235
