On Wed, 26 Jun 2024 10:23:45 GMT, Kevin Walls wrote:
> VM.classes uses:
>
> 995VM_PrintClasses vmop(output(), _verbose.is_set());
>
> _verbose.is_set() is wrong: it could be set, but set to false.
>
> _verbose.value() should be used (see other examples such as
> StringtableDCmd::execute).
On Wed, 26 Jun 2024 10:23:45 GMT, Kevin Walls wrote:
> VM.classes uses:
>
> 995VM_PrintClasses vmop(output(), _verbose.is_set());
>
> _verbose.is_set() is wrong: it could be set, but set to false.
>
> _verbose.value() should be used (see other examples such as
> StringtableDCmd::execute).
On Wed, 26 Jun 2024 12:44:03 GMT, David Holmes wrote:
>> It has a default value... Generally "false" for _verbose DCmdArguments.
>
> Ok
Thanks!
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19901#discussion_r1654753099
On Wed, 26 Jun 2024 10:23:45 GMT, Kevin Walls wrote:
> VM.classes uses:
>
> 995VM_PrintClasses vmop(output(), _verbose.is_set());
>
> _verbose.is_set() is wrong: it could be set, but set to false.
>
> _verbose.value() should be used (see other examples such as
> StringtableDCmd::execute).
On Wed, 26 Jun 2024 12:40:07 GMT, Kevin Walls wrote:
>> src/hotspot/share/services/diagnosticCommand.cpp line 995:
>>
>>> 993:
>>> 994: void ClassesDCmd::execute(DCmdSource source, TRAPS) {
>>> 995: VM_PrintClasses vmop(output(), _verbose.value());
>>
>> What if it wasn't set?
>
> It has a d
On Wed, 26 Jun 2024 12:29:18 GMT, David Holmes wrote:
>> VM.classes uses:
>>
>> 995VM_PrintClasses vmop(output(), _verbose.is_set());
>>
>> _verbose.is_set() is wrong: it could be set, but set to false.
>>
>> _verbose.value() should be used (see other examples such as
>> StringtableDCmd::
On Wed, 26 Jun 2024 10:23:45 GMT, Kevin Walls wrote:
> VM.classes uses:
>
> 995VM_PrintClasses vmop(output(), _verbose.is_set());
>
> _verbose.is_set() is wrong: it could be set, but set to false.
>
> _verbose.value() should be used (see other examples such as
> StringtableDCmd::execute).
VM.classes uses:
995VM_PrintClasses vmop(output(), _verbose.is_set());
_verbose.is_set() is wrong: it could be set, but set to false.
_verbose.value() should be used (see other examples such as
StringtableDCmd::execute).
With this change -verbose=false will turn off verbose mode like all o
