> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory
> share/memory/. Unfortunately the script that does the change isn't perfect,
> and so we
> need to comb through these manually to make sure nothing has gone wrong. I
> also review these changes but things slip past my
On Thu, 26 Jan 2023 15:04:06 GMT, Johan Sjölen wrote:
>> src/hotspot/share/memory/metaspace/blockTree.hpp line 228:
>>
>>> 226: DEBUG_ONLY(check_node(insertion_point);)
>>> 227: if (n->_word_size == insertion_point->_word_size) {
>>> 228: add_to_list(n, insertion_point); // p
On Thu, 26 Jan 2023 09:48:06 GMT, Thomas Stuefe wrote:
>Small nit. Do we have a unified naming scheme for comments?
Yeah, I forgot to update the PR message with all of the info. If you check now
you can see what's been decided upon. The discussions can be found in previous
PRs, I can link to t