On Mon, 15 Jan 2024 09:13:24 GMT, Joachim Kern wrote:
>> In parseAllowedMask in socketTransport.c, prefixLen of mask is compared with
>> a maxValue (32 for IPv4, 128 otherwise). This fails if it is larger than
>> 32, because getaddrinfo seems to detect IPv4 family, if IPv6 address has set
>>
On Mon, 15 Jan 2024 09:13:24 GMT, Joachim Kern wrote:
>> In parseAllowedMask in socketTransport.c, prefixLen of mask is compared with
>> a maxValue (32 for IPv4, 128 otherwise). This fails if it is larger than
>> 32, because getaddrinfo seems to detect IPv4 family, if IPv6 address has set
>>
On Fri, 12 Jan 2024 21:22:35 GMT, Alex Menkov wrote:
>> Joachim Kern has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> following proposals of alexmenkov
>
> src/jdk.jdwp.agent/share/native/libdt_socket/socketTransport.c line 400:
>
>> 398
> In parseAllowedMask in socketTransport.c, prefixLen of mask is compared with
> a maxValue (32 for IPv4, 128 otherwise). This fails if it is larger than 32,
> because getaddrinfo seems to detect IPv4 family, if IPv6 address has set only
> some of the last 32 Bits. So we take the wrong maxValue
On Fri, 12 Jan 2024 11:28:32 GMT, Joachim Kern wrote:
>> In parseAllowedMask in socketTransport.c, prefixLen of mask is compared with
>> a maxValue (32 for IPv4, 128 otherwise). This fails if it is larger than
>> 32, because getaddrinfo seems to detect IPv4 family, if IPv6 address has set
>>
On Thu, 11 Jan 2024 16:14:39 GMT, Joachim Kern wrote:
>> In parseAllowedMask in socketTransport.c, prefixLen of mask is compared with
>> a maxValue (32 for IPv4, 128 otherwise). This fails if it is larger than
>> 32, because getaddrinfo seems to detect IPv4 family, if IPv6 address has set
>>
> In parseAllowedMask in socketTransport.c, prefixLen of mask is compared with
> a maxValue (32 for IPv4, 128 otherwise). This fails if it is larger than 32,
> because getaddrinfo seems to detect IPv4 family, if IPv6 address has set only
> some of the last 32 Bits. So we take the wrong maxValue
On Fri, 12 Jan 2024 08:38:48 GMT, Christoph Langer wrote:
> @MBaesken, I believe with this idea/PR, #16561 could be closed, right?
Yes we want to use inet_pton ; the other one was just a temporary thing (when
I think about it , I could have closed this for quite some time ) .
-
P
On Thu, 11 Jan 2024 16:14:39 GMT, Joachim Kern wrote:
>> In parseAllowedMask in socketTransport.c, prefixLen of mask is compared with
>> a maxValue (32 for IPv4, 128 otherwise). This fails if it is larger than
>> 32, because getaddrinfo seems to detect IPv4 family, if IPv6 address has set
>>
On Thu, 11 Jan 2024 16:14:39 GMT, Joachim Kern wrote:
>> In parseAllowedMask in socketTransport.c, prefixLen of mask is compared with
>> a maxValue (32 for IPv4, 128 otherwise). This fails if it is larger than
>> 32, because getaddrinfo seems to detect IPv4 family, if IPv6 address has set
>>
> In parseAllowedMask in socketTransport.c, prefixLen of mask is compared with
> a maxValue (32 for IPv4, 128 otherwise). This fails if it is larger than 32,
> because getaddrinfo seems to detect IPv4 family, if IPv6 address has set only
> some of the last 32 Bits. So we take the wrong maxValue
On Thu, 11 Jan 2024 16:00:45 GMT, Matthias Baesken wrote:
>> Joachim Kern has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> cosmetic changes
>
> src/jdk.jdwp.agent/share/native/libdt_socket/socketTransport.c line 428:
>
>> 426: co
On Thu, 11 Jan 2024 15:46:59 GMT, Joachim Kern wrote:
> In parseAllowedMask in socketTransport.c, prefixLen of mask is compared with
> a maxValue (32 for IPv4, 128 otherwise). This fails if it is larger than 32,
> because getaddrinfo seems to detect IPv4 family, if IPv6 address has set only
>
In parseAllowedMask in socketTransport.c, prefixLen of mask is compared with a
maxValue (32 for IPv4, 128 otherwise). This fails if it is larger than 32,
because getaddrinfo seems to detect IPv4 family, if IPv6 address has set only
some of the last 32 Bits. So we take the wrong maxValue.
-
On Mon, 11 Dec 2023 14:38:08 GMT, Matthias Baesken wrote:
>> A colleague contacted IBM about the different behavior of getaddrinfo on
>> AIX (compared to Linux/macOS); maybe we have to adjust the result of the
>> getaddrinfo call on AIX.
>
>> A colleague contacted IBM about the different beha
On Mon, 11 Dec 2023 14:38:08 GMT, Matthias Baesken wrote:
>> A colleague contacted IBM about the different behavior of getaddrinfo on
>> AIX (compared to Linux/macOS); maybe we have to adjust the result of the
>> getaddrinfo call on AIX.
>
>> A colleague contacted IBM about the different beha
On Mon, 13 Nov 2023 11:43:08 GMT, Matthias Baesken wrote:
> A colleague contacted IBM about the different behavior of getaddrinfo on AIX
> (compared to Linux/macOS); maybe we have to adjust the result of the
> getaddrinfo call on AIX.
Haven't heard from them so far, hopefully we get an update
On Wed, 8 Nov 2023 14:37:29 GMT, Matthias Baesken wrote:
> In parseAllowedMask (file socketTransport.c) , prefixLen of mask is compared
> with a maxValue (32 for IPv4, 128 otherwise). This fails on AIX if it is
> larger than 32, because getaddrinfo seems to often (always ?) detect IPv4
> famil
On Wed, 8 Nov 2023 21:55:44 GMT, Alex Menkov wrote:
> does getaddrinfo return a single address? (parseAllowedAddr assumes so, but
> maybe that's wrong in the case)
>From what I see on AIX, only one entry is returned in the results struct of
>the getaddrinfo call.
-
PR Comment: h
On Wed, 8 Nov 2023 17:57:42 GMT, Chris Plummer wrote:
> The downside of this change is that it will cause the option parsing code to
> not properly produce an error if an IPv4 mask prefix between 32 and 128 is
> given.
Yes this is true; maybe we should not unconditionally increase the maxValu
On Wed, 8 Nov 2023 14:37:29 GMT, Matthias Baesken wrote:
> In parseAllowedMask (file socketTransport.c) , prefixLen of mask is compared
> with a maxValue (32 for IPv4, 128 otherwise). This fails on AIX if it is
> larger than 32, because getaddrinfo seems to often (always ?) detect IPv4
> famil
On Wed, 8 Nov 2023 14:37:29 GMT, Matthias Baesken wrote:
> In parseAllowedMask (file socketTransport.c) , prefixLen of mask is compared
> with a maxValue (32 for IPv4, 128 otherwise). This fails on AIX if it is
> larger than 32, because getaddrinfo seems to often (always ?) detect IPv4
> famil
In parseAllowedMask (file socketTransport.c) , prefixLen of mask is compared
with a maxValue (32 for IPv4, 128 otherwise). This fails on AIX if it is larger
than 32, because getaddrinfo seems to often (always ?) detect IPv4 family, even
for IPv6 addresses, so we take the wrong maxValue.
Probably
23 matches
Mail list logo
