On Fri, 8 Dec 2023 22:29:12 GMT, Alex Menkov wrote:
> Original fix for JDK-8299426 (Heap dump does not contain virtual Thread stack
> references, #16665) caused failures of new test (added while #16665 was under
> review):
> test/hotspot/jtreg/compiler/c2/TestReduceAllocationAndHeapDump.java
On Wed, 13 Dec 2023 04:59:16 GMT, Alex Menkov wrote:
>>> So is the main thread operating in_native whilst doing the merge? I suspect
>>> the admonition of not doing the merge at a safepoint actually meant "not a
>>> safepoint by the VMThread" as that would cause the whole VM to pause. Even
On Wed, 13 Dec 2023 01:38:03 GMT, Alex Menkov wrote:
>>> I.e. merge is performed on main java thread, but VM is at safepoint
>>
>> So is the main thread operating in_native whilst doing the merge? I suspect
>> the admonition of not doing the merge at a safepoint actually meant "not a
>>
On Tue, 12 Dec 2023 23:11:41 GMT, David Holmes wrote:
> So is the main thread operating in_native whilst doing the merge? I suspect
> the admonition of not doing the merge at a safepoint actually meant "not a
> safepoint by the VMThread" as that would cause the whole VM to pause. Even
> doing
On Tue, 12 Dec 2023 22:18:33 GMT, Alex Menkov wrote:
> I.e. merge is performed on main java thread, but VM is at safepoint
So is the main thread operating in_native whilst doing the merge? I suspect the
admonition of not doing the merge at a safepoint actually meant "not a
safepoint by the
On Tue, 12 Dec 2023 21:59:12 GMT, Alex Menkov wrote:
>> Prior to the virtual thread changes what thread is performing the merge?
>> After these changes what thread would do it if not included in the VM
>> operation?
>>
>> The assert is correct - we should not do the merge at the safepoint (or
On Tue, 12 Dec 2023 07:06:07 GMT, David Holmes wrote:
> Prior to the virtual thread changes what thread is performing the merge?
Prior the change merge is performed on either AttachListener thread (when it's
the current thread - special case for tools like jcmd) or on VMThread (if the
current
On Tue, 12 Dec 2023 00:19:15 GMT, Alex Menkov wrote:
>> src/hotspot/share/services/heapDumper.cpp line 1984:
>>
>>> 1982: // user space.
>>> 1983: void DumpMerger::merge_file(char* path) {
>>> 1984: assert(!SafepointSynchronize::is_at_safepoint(), "merging happens
>>> outside safepoint");
>>
On Fri, 8 Dec 2023 22:29:12 GMT, Alex Menkov wrote:
> Original fix for JDK-8299426 (Heap dump does not contain virtual Thread stack
> references, #16665) caused failures of new test (added while #16665 was under
> review):
> test/hotspot/jtreg/compiler/c2/TestReduceAllocationAndHeapDump.java
On Mon, 11 Dec 2023 06:05:52 GMT, David Holmes wrote:
>> Original fix for JDK-8299426 (Heap dump does not contain virtual Thread
>> stack references, #16665) caused failures of new test (added while #16665
>> was under review):
>>
On Fri, 8 Dec 2023 22:29:12 GMT, Alex Menkov wrote:
> Original fix for JDK-8299426 (Heap dump does not contain virtual Thread stack
> references, #16665) caused failures of new test (added while #16665 was under
> review):
> test/hotspot/jtreg/compiler/c2/TestReduceAllocationAndHeapDump.java
On Fri, 8 Dec 2023 22:29:12 GMT, Alex Menkov wrote:
> Original fix for JDK-8299426 (Heap dump does not contain virtual Thread stack
> references, #16665) caused failures of new test (added while #16665 was under
> review):
> test/hotspot/jtreg/compiler/c2/TestReduceAllocationAndHeapDump.java
On Fri, 8 Dec 2023 23:37:30 GMT, Serguei Spitsyn wrote:
> This seems to be the same fix that we REDO, is it right? Also, I'd like to
> double check on what testing was done for this REDO?
It's almost the same (the only differences are deleted asserts in HeapMerger
methods).
The PR contains 2
On Fri, 8 Dec 2023 22:29:12 GMT, Alex Menkov wrote:
> Original fix for JDK-8299426 (Heap dump does not contain virtual Thread stack
> references, #16665) caused failures of new test (added while #16665 was under
> review):
> test/hotspot/jtreg/compiler/c2/TestReduceAllocationAndHeapDump.java
Original fix for JDK-8299426 (Heap dump does not contain virtual Thread stack
references, #16665) caused failures of new test (added while #16665 was under
review):
test/hotspot/jtreg/compiler/c2/TestReduceAllocationAndHeapDump.java in many
tears and was reverted.
Segmented heap dump assumes
15 matches
Mail list logo
