On Fri, 8 Dec 2023 23:37:30 GMT, Serguei Spitsyn <[email protected]> wrote:
> This seems to be the same fix that we REDO, is it right? Also, I'd like to
> double check on what testing was done for this REDO?
It's almost the same (the only differences are deleted asserts in HeapMerger
methods).
The PR contains 2 commits to simplify re-review.
The 1st one ("original fix") is exactly the same commit which was integrated
for JDK-8299426 and which was reverted;
The 2nd one ("allow heapdump in safepoints") contains the fix for the issue
discovered after integration.
The fix was tested by running heapdump-related tests:
test/hotspot/jtreg/serviceability, test/hotspot/jtreg/runtime/ErrorHandling,
test/hotspot/jtreg/gc/epsilon, test/jdk/sun/tools/jhsdb
and tier1..3 on all Oracle supported platforms
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17040#issuecomment-1848012109
