Re: is trunk compiling?

2007-02-21 Thread Mike Klaas
On 2/21/07, Ryan McKinley <[EMAIL PROTECTED]> wrote: I have a clean trunk, and get a bunch of HIGHLIGHT errors: $ ant compile Buildfile: build.xml checkJunitPresence: Sigh, sorry about that. ant test is not ant clean test. Will fix presently. -Mike

[jira] Updated: (SOLR-170) StandardRequestHandler should support the 'sort' parameter

2007-02-21 Thread Ryan McKinley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan McKinley updated SOLR-170: --- Attachment: SOLR-170-sort-parameter.patch This simple patch adds 'sort' param to StandardRequestHandler

Re: sorting parameter changes?

2007-02-21 Thread Ryan McKinley
> >so, one way to disable ; parsing for all queries would be to add a >default empty parameter for "sort" Don't you have that backwards? I don't think so (but it happens so often) with the existing parser: q=id:55; q=id:55 q=id:55;score asc are all equivalent. I'm suggesting we change so t

Re: sorting parameter changes?

2007-02-21 Thread J.J. Larrea
At 10:46 PM -0800 2/21/07, Ryan McKinley wrote: >the 'explicit' parameter would be sending an empty string for 'sort' > >In the existing implementation of QueryParsing.parseSort( ): > null, "", and "score" all return a 'null' (default) SortSpec > >so, one way to disable ; parsing for all queries w

[jira] Created: (SOLR-170) StandardRequestHandler should support the 'sort' parameter

2007-02-21 Thread Ryan McKinley (JIRA)
StandardRequestHandler should support the 'sort' parameter -- Key: SOLR-170 URL: https://issues.apache.org/jira/browse/SOLR-170 Project: Solr Issue Type: Improvement Reporte

Re: sorting parameter changes?

2007-02-21 Thread J.J. Larrea
At 9:42 PM -0800 2/21/07, Chris Hostetter wrote: >yeah ... the semantics discussed previously for backwards compatibility >were... > > 1) if sort param, use it and do no special ; parsing > 2) if no sort param, check for ; and extract sort FWIW, in an in-progress refactoring of StandardRequestHand

is trunk compiling?

2007-02-21 Thread Ryan McKinley
I have a clean trunk, and get a bunch of HIGHLIGHT errors: $ ant compile Buildfile: build.xml checkJunitPresence: compile: [mkdir] Created dir: C:\workspace\TTT\build [javac] Compiling 171 source files to C:\workspace\TTT\build [javac] C:\workspace\TTT\src\java\org\apache\solr\util\Com

Re: svn commit: r510334 - in /lucene/solr/trunk/src/java/org/apache/solr/search: QueryParsing.java SolrQueryParser.java

2007-02-21 Thread Chris Hostetter
: I believe now having SolrQueryParser set the operator based on the : schema configuration is much more sensible. I haven't looked at this in depth, but i *think* this breaks the DisMaxQueryParser (i'm guessing AND isn't the default in our test config) i remember discussing this before, and sug

Re: sorting parameter changes?

2007-02-21 Thread Ryan McKinley
1) if sort param, use it and do no special ; parsing 2) if no sort param, check for ; and extract sort ..but i'm wondering if we want an explicit param indicating that the old behavior should be supressed -- that way having no sort param can default to sort on score just like with dismax (and

[jira] Updated: (SOLR-169) use release version of "commons-fileupload"

2007-02-21 Thread Ryan McKinley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan McKinley updated SOLR-169: --- Attachment: commons-fileupload-1.2.jar > use release version of "commons-fileupload" >

[jira] Created: (SOLR-169) use release version of "commons-fileupload"

2007-02-21 Thread Ryan McKinley (JIRA)
use release version of "commons-fileupload" --- Key: SOLR-169 URL: https://issues.apache.org/jira/browse/SOLR-169 Project: Solr Issue Type: Improvement Reporter: Ryan McKinley P

Re: sorting parameter changes?

2007-02-21 Thread Chris Hostetter
: > Any reason not to have the standard handler accept sort=? : : Nope, it's been discussed before I think, and everyone agreed it was a : good idea. yeah ... the semantics discussed previously for backwards compatibility were... 1) if sort param, use it and do no special ; parsing 2) if no so

Re: sorting parameter changes?

2007-02-21 Thread Yonik Seeley
On 2/21/07, Ryan McKinley <[EMAIL PROTECTED]> wrote: Currently, the standard query handler takes a "smart" sort parameter: q=query; sort and dismax requires a separate sort parameter: q=query&sort=sort Any reason not to have the standard handler accept sort=? Nope, it's been discussed be

sorting parameter changes?

2007-02-21 Thread Ryan McKinley
Currently, the standard query handler takes a "smart" sort parameter: q=query; sort and dismax requires a separate sort parameter: q=query&sort=sort Any reason not to have the standard handler accept sort=? The change of parameters is a needless gotcha for switching between the two handlers.

Re: svn commit: r510325 - in /lucene/solr/trunk: CHANGES.txt src/java/org/apache/solr/request/DisMaxRequestHandler.java src/java/org/apache/solr/util/DisMaxParams.java src/test/org/apache/solr/DisMaxR

2007-02-21 Thread Yonik Seeley
On 2/21/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: + * ps - (Query Slop) amount of slop on phrase queries explicitly + * specified in the "q" for qf fields. Ahh, thanks for the additional code comments... I was a bit confused since there already was a phrase slop param. -Yonik

Re: svn commit: r510338 - in /lucene/solr/trunk/src/java/org/apache/solr: request/SolrParams.java util/HighlightingUtils.java util/SolrPluginUtils.java

2007-02-21 Thread Erik Hatcher
Mike, Your commit causes build failures. Do "ant clean example" Erik compile: [mkdir] Created dir: /Users/erik/dev/solr/build [javac] Compiling 171 source files to /Users/erik/dev/solr/build [javac] /Users/erik/dev/solr/src/java/org/apache/solr/util/ CommonParams.java:1

Re: svn commit: r510334 - in /lucene/solr/trunk/src/java/org/apache/solr/search: QueryParsing.java SolrQueryParser.java

2007-02-21 Thread Erik Hatcher
If you see anything fishy with this, by all means let me know. This was an odd one... my custom request handler calls QueryParsing.parseQuery(String,String,IndexSchema) and it confused me for a while why our default AND operator was not working. I had implemented this feature, but for a d

[jira] Resolved: (SOLR-158) [PATCH] New query slop option for DisMaxRequestHandler

2007-02-21 Thread Hoss Man (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hoss Man resolved SOLR-158. --- Resolution: Fixed commited patch along with some documentation additions and test cases. > [PATCH] New query s

[jira] Updated: (SOLR-133) change XmlUpdateRequestHandler to use StAX instead of XPP

2007-02-21 Thread Ryan McKinley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan McKinley updated SOLR-133: --- Attachment: SOLR-133-XmlUpdateRequestHandler-StAX-139.patch fixed the document parser to handle fields

[jira] Assigned: (SOLR-158) [PATCH] New query slop option for DisMaxRequestHandler

2007-02-21 Thread Hoss Man (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hoss Man reassigned SOLR-158: - Assignee: Hoss Man > [PATCH] New query slop option for DisMaxRequestHandler > -

[jira] Resolved: (SOLR-152) Dismax should not require 'q'

2007-02-21 Thread Hoss Man (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hoss Man resolved SOLR-152. --- Resolution: Fixed I've committed a variation on Ryan's latest patch that: 1) changes from the matchall=true

[jira] Assigned: (SOLR-152) Dismax should not require 'q'

2007-02-21 Thread Hoss Man (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hoss Man reassigned SOLR-152: - Assignee: Hoss Man > Dismax should not require 'q' > - > > Key:

removal of JIRA attachments

2007-02-21 Thread Yonik Seeley
FYI: http://www.nabble.com/removal-of-JIRA-attachments-tf3268980.html#a9088105 I don't recall having these issues in Solr yet though. -Yonik

[jira] Updated: (SOLR-81) Add Query Spellchecker functionality

2007-02-21 Thread Otis Gospodnetic (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-81?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Otis Gospodnetic updated SOLR-81: - Attachment: SOLR-81-ngram.patch Here is a new patch that should include everything: - New SpellCheck

[jira] Resolved: (SOLR-140) single quote in search query will break any sorts

2007-02-21 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yonik Seeley resolved SOLR-140. --- Resolution: Fixed > single quote in search query will break any sorts > ---