[
https://issues.apache.org/jira/browse/SOLR-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752841#action_12752841
]
Uri Boness commented on SOLR-1071:
--
cool! thanks for the effort Yonik. I've updated the wik
[
https://issues.apache.org/jira/browse/SOLR-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752793#action_12752793
]
Yonik Seeley commented on SOLR-1071:
Committed! The Solr release schedule is tight enou
[
https://issues.apache.org/jira/browse/SOLR-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752472#action_12752472
]
Uri Boness commented on SOLR-1071:
--
bq. I guess it depends on how important order is in the
[
https://issues.apache.org/jira/browse/SOLR-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752449#action_12752449
]
Yonik Seeley commented on SOLR-1071:
bq. I mean the top most "suggestions" node.
Oh I se
[
https://issues.apache.org/jira/browse/SOLR-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752448#action_12752448
]
Uri Boness commented on SOLR-1071:
--
bq. It already does... it's just the client code that c
[
https://issues.apache.org/jira/browse/SOLR-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752423#action_12752423
]
Yonik Seeley commented on SOLR-1071:
Thanks for the review Uri!
bq. One more thing - I
[
https://issues.apache.org/jira/browse/SOLR-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752417#action_12752417
]
Uri Boness commented on SOLR-1071:
--
Looks good!
As for the naming, I really like your sug
[
https://issues.apache.org/jira/browse/SOLR-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752285#action_12752285
]
Yonik Seeley commented on SOLR-1071:
I haven't changed the SolrJ SpellCheckResponse clas
[
https://issues.apache.org/jira/browse/SOLR-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752268#action_12752268
]
Yonik Seeley commented on SOLR-1071:
I'm moving forward with the most straightforward fi
[
https://issues.apache.org/jira/browse/SOLR-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750659#action_12750659
]
Uri Boness commented on SOLR-1071:
--
Because there are issues with the current format is jso
[
https://issues.apache.org/jira/browse/SOLR-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750606#action_12750606
]
Stephen Day commented on SOLR-1071:
---
Why did this ever change to begin with? From the wiki
[
https://issues.apache.org/jira/browse/SOLR-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740965#action_12740965
]
Yonik Seeley commented on SOLR-1071:
bq. Why isn't this a JSONResponseWriter bug?
JSON
[
https://issues.apache.org/jira/browse/SOLR-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12735859#action_12735859
]
Uri Boness commented on SOLR-1071:
--
I'm not sure it's a bug in the JSONRW, it seems to me t
[
https://issues.apache.org/jira/browse/SOLR-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12735856#action_12735856
]
Uri Boness commented on SOLR-1071:
--
bq. I debated the two different structures for a while
[
https://issues.apache.org/jira/browse/SOLR-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12735751#action_12735751
]
Grant Ingersoll commented on SOLR-1071:
---
One thought, though:
Why isn't this a JSONRe
[
https://issues.apache.org/jira/browse/SOLR-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12735749#action_12735749
]
Grant Ingersoll commented on SOLR-1071:
---
bq. When extendedResults is used, the suggest
[
https://issues.apache.org/jira/browse/SOLR-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12701492#action_12701492
]
Uri Boness commented on SOLR-1071:
--
One more thing to consider: now this component is a bit
[
https://issues.apache.org/jira/browse/SOLR-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694763#action_12694763
]
Uri Boness commented on SOLR-1071:
--
I think "alternatives" and "corrections" are best candi
[
https://issues.apache.org/jira/browse/SOLR-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694745#action_12694745
]
Yonik Seeley commented on SOLR-1071:
bq. At first I tagged it "suggestions" but then I t
[
https://issues.apache.org/jira/browse/SOLR-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694727#action_12694727
]
Donovan Jimenez commented on SOLR-1071:
---
Some other response writers, like Serialized
[
https://issues.apache.org/jira/browse/SOLR-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694710#action_12694710
]
Uri Boness commented on SOLR-1071:
--
At first I tagged it "suggestions" but then I thought i
[
https://issues.apache.org/jira/browse/SOLR-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694707#action_12694707
]
Yonik Seeley commented on SOLR-1071:
bq. 2. A small change to the response data structu
[
https://issues.apache.org/jira/browse/SOLR-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694246#action_12694246
]
Grant Ingersoll commented on SOLR-1071:
---
Uri, does that solve your problem?
> spellch
[
https://issues.apache.org/jira/browse/SOLR-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694199#action_12694199
]
Donovan Jimenez commented on SOLR-1071:
---
the JSON response writer has a specific param
[
https://issues.apache.org/jira/browse/SOLR-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694196#action_12694196
]
Grant Ingersoll commented on SOLR-1071:
---
I don't know much about JSON, but it is my un
25 matches
Mail list logo
