[jira] Commented: (SOLR-1591) XMLWriter#writeAttr silently ignores null attribute values

2010-01-13 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12799779#action_12799779 ] Yonik Seeley commented on SOLR-1591: bq. Thanks for your last comment, but I'm still

[jira] Commented: (SOLR-1591) XMLWriter#writeAttr silently ignores null attribute values

2010-01-13 Thread Chris A. Mattmann (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12799784#action_12799784 ] Chris A. Mattmann commented on SOLR-1591: - {quote} shrugs - the example I gave was

[jira] Commented: (SOLR-1591) XMLWriter#writeAttr silently ignores null attribute values

2010-01-13 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12799787#action_12799787 ] Yonik Seeley commented on SOLR-1591: {quote} But what about this? if(map.get(foo)) !=

[jira] Commented: (SOLR-1591) XMLWriter#writeAttr silently ignores null attribute values

2010-01-13 Thread Chris A. Mattmann (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12799792#action_12799792 ] Chris A. Mattmann commented on SOLR-1591: - bq. Why are you arguing performance if

[jira] Commented: (SOLR-1591) XMLWriter#writeAttr silently ignores null attribute values

2010-01-12 Thread Chris A. Mattmann (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12799604#action_12799604 ] Chris A. Mattmann commented on SOLR-1591: - Hey Yonik: Thanks for your last comment,

[jira] Commented: (SOLR-1591) XMLWriter#writeAttr silently ignores null attribute values

2010-01-12 Thread Noble Paul (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12799617#action_12799617 ] Noble Paul commented on SOLR-1591: -- bq.I'd favor an exception to be thrown not required.

[jira] Commented: (SOLR-1591) XMLWriter#writeAttr silently ignores null attribute values

2010-01-12 Thread Chris A. Mattmann (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12799621#action_12799621 ] Chris A. Mattmann commented on SOLR-1591: - It may work as designed Noble, but as

[jira] Commented: (SOLR-1591) XMLWriter#writeAttr silently ignores null attribute values

2010-01-12 Thread Noble Paul (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12799627#action_12799627 ] Noble Paul commented on SOLR-1591: -- bq.Why waste a function call here? * null values are

[jira] Commented: (SOLR-1591) XMLWriter#writeAttr silently ignores null attribute values

2010-01-12 Thread Chris A. Mattmann (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12799628#action_12799628 ] Chris A. Mattmann commented on SOLR-1591: - Hey Noble: Here are the disadvantages:

[jira] Commented: (SOLR-1591) XMLWriter#writeAttr silently ignores null attribute values

2009-11-22 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12781293#action_12781293 ] Yonik Seeley commented on SOLR-1591: This actually changes the functionality though...

[jira] Commented: (SOLR-1591) XMLWriter#writeAttr silently ignores null attribute values

2009-11-22 Thread Chris A. Mattmann (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12781294#action_12781294 ] Chris A. Mattmann commented on SOLR-1591: - I don't get it. If someone passes in a

[jira] Commented: (SOLR-1591) XMLWriter#writeAttr silently ignores null attribute values

2009-11-22 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12781298#action_12781298 ] Yonik Seeley commented on SOLR-1591: Implementing a null check in one place can be