[jira] Commented: (SOLR-183) add getRequiredParameter() to SolrParams

[ https://issues.apache.org/jira/browse/SOLR-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482686 ] J.J. Larrea commented on SOLR-183: -- Thanks for clarifying the semantics and the implementation, Ryan. It's fine by

[jira] Commented: (SOLR-183) add getRequiredParameter() to SolrParams

[ https://issues.apache.org/jira/browse/SOLR-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482455 ] J.J. Larrea commented on SOLR-183: -- I totally agree with Ryan that the question I raised about the value of

[jira] Commented: (SOLR-183) add getRequiredParameter() to SolrParams

[ https://issues.apache.org/jira/browse/SOLR-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12478895 ] J.J. Larrea commented on SOLR-183: -- Er, sorry to be contrary, but to me it seems a bit excessive to go through so

[jira] Commented: (SOLR-183) add getRequiredParameter() to SolrParams

[ https://issues.apache.org/jira/browse/SOLR-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12478930 ] J.J. Larrea commented on SOLR-183: -- Modest proposal: If one is going to come up with a programmer-facing mechanism

[jira] Commented: (SOLR-183) add getRequiredParameter() to SolrParams

[ https://issues.apache.org/jira/browse/SOLR-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12478934 ] Ryan McKinley commented on SOLR-183: It seems bad to have the requited params be user configurable. The real use

[jira] Commented: (SOLR-183) add getRequiredParameter() to SolrParams

[ https://issues.apache.org/jira/browse/SOLR-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12478980 ] J.J. Larrea commented on SOLR-183: -- By the way, I think your logic to catch type conversion errors and return 400

[jira] Commented: (SOLR-183) add getRequiredParameter() to SolrParams

[ https://issues.apache.org/jira/browse/SOLR-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12479175 ] J.J. Larrea commented on SOLR-183: -- I was unfortunately not very clear, and confounded 2 things, an enhanced

[jira] Commented: (SOLR-183) add getRequiredParameter() to SolrParams

[ https://issues.apache.org/jira/browse/SOLR-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12478508 ] Hoss Man commented on SOLR-183: --- Ryan: this patch is nice and simple ... but it has me wondering if it might be more

[jira] Commented: (SOLR-183) add getRequiredParameter() to SolrParams

[ https://issues.apache.org/jira/browse/SOLR-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12478523 ] Hoss Man commented on SOLR-183: --- yeha ... the one thing about an approach like this that i'm not sure how i feel about

[jira] Commented: (SOLR-183) add getRequiredParameter() to SolrParams

[ https://issues.apache.org/jira/browse/SOLR-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12478525 ] Ryan McKinley commented on SOLR-183: yes, this is better. but what should happen with Integer bar =

[jira] Commented: (SOLR-183) add getRequiredParameter() to SolrParams

[ https://issues.apache.org/jira/browse/SOLR-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12478552 ] Ryan McKinley commented on SOLR-183: I'm getting into it now... the easiest is to throw a 400 exception for

[jira] Commented: (SOLR-183) add getRequiredParameter() to SolrParams

[ https://issues.apache.org/jira/browse/SOLR-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12478556 ] Yonik Seeley commented on SOLR-183: --- I like anything that can avoid yet another hash lookup in the common cases. I