[
https://issues.apache.org/jira/browse/SOLR-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12478552
]
Ryan McKinley commented on SOLR-183:
------------------------------------
I'm getting into it now... the easiest is to throw a 400 exception for
everyting. the SolrParams abstract class calls get( '' ) for each of the getX(
name, devault ) - so, we would have to overwrite all the getX functions rather
then just the one. If we do that, we may as well catch the 'parse exception'
from Integer.parseInt() and send a 400 rather then a 500 w/ stack trace.
That is cleaner from user standpoint, so it must be the better option.
> add getRequiredParameter() to SolrParams
> ----------------------------------------
>
> Key: SOLR-183
> URL: https://issues.apache.org/jira/browse/SOLR-183
> Project: Solr
> Issue Type: Wish
> Reporter: Ryan McKinley
> Priority: Trivial
> Attachments: SOLR-183-required-param.patch
>
>
> I find myself including this with every patch, so i'll just separate it out.
> This simply adds a utilty function to SolrParams that throws a 400 if the
> parameter is missing:
> /** returns the value of the param, or throws a 400 exception if missing */
> public String getRequiredParameter(String param) throws SolrException {
> String val = get(param);
> if( val == null ) {
> throw new SolrException( 400, "Missing parameter: "+param );
> }
> return val;
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
