Re: [jira] Commented: (SOLR-258) Date based Facets

2007-08-07 Thread Chris Hostetter
: The iLow and iHigh parameters seem to be reversed. good catch ... it wasn't causing any bugs since iLow and iHigh are always the same but it's definitely nice to catch this now rather then later. -Hoss

Re: [jira] Commented: (SOLR-258) Date based Facets

2007-07-30 Thread Greg Ludington
I started looking through this, and it looks very nice, though I do see one slight nit to pick. I may be reading this incorrectly, but two parameters in rangeCount appear to be transposed. In SimpleFacets.java, the rangeCount method uses: new ConstantScoreRangeQuery(field,low,high,iHigh,iLow)

[jira] Commented: (SOLR-258) Date based Facets

2007-07-25 Thread Hoss Man (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515221 ] Hoss Man commented on SOLR-258: --- It is probably wise to explicitly check for (end start XOR gap 0) and return an

[jira] Commented: (SOLR-258) Date based Facets

2007-07-24 Thread Pieter Berkel (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515208 ] Pieter Berkel commented on SOLR-258: Looking good Hoss, the NOW issue seems to be resolved and the results look

[jira] Commented: (SOLR-258) Date based Facets

2007-07-15 Thread Tristan Vittorio (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512775 ] Tristan Vittorio commented on SOLR-258: --- 4) my hesitation about renaming gap to interval is that i wanted to

[jira] Commented: (SOLR-258) Date based Facets

2007-07-15 Thread Hoss Man (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512776 ] Hoss Man commented on SOLR-258: --- it might be more precise to specify a single start time, a gap, and a gap count

[jira] Commented: (SOLR-258) Date based Facets

2007-07-15 Thread Pieter Berkel (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512778 ] Pieter Berkel commented on SOLR-258: Sorry that last comment was from me, not posted from my regular computer.

[jira] Commented: (SOLR-258) Date based Facets

2007-07-13 Thread Pieter Berkel (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512372 ] Pieter Berkel commented on SOLR-258: I've just tried this patch and the results are impressive! I agree with Ryan

[jira] Commented: (SOLR-258) Date based Facets

2007-07-13 Thread Hoss Man (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512559 ] Hoss Man commented on SOLR-258: --- 1) i'm happy to break out the FacetParams into their own interface ... but i'd like

[jira] Commented: (SOLR-258) Date based Facets

2007-07-13 Thread Ryan McKinley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512571 ] Ryan McKinley commented on SOLR-258: but i'd like to track that in a separate refactoring commit (since the

[jira] Commented: (SOLR-258) Date based Facets

2007-07-13 Thread Hoss Man (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512626 ] Hoss Man commented on SOLR-258: --- the big problem being that I doubt the SolrQueryRequest is always available

[jira] Commented: (SOLR-258) Date based Facets

2007-07-12 Thread Ryan McKinley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512353 ] Ryan McKinley commented on SOLR-258: This looks great Hoss. Thanks! The facet param interface look reasonable.