[
https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617434#action_12617434
]
Shalin Shekhar Mangar commented on SOLR-647:
Yonik, what do you feel about adding
[
https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617435#action_12617435
]
Yonik Seeley commented on SOLR-647:
---
I took a quick peek looks like there are probably
[
https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620276#action_12620276
]
Henri Biestro commented on SOLR-647:
It seems there is still the possibility that betwee
[
https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620416#action_12620416
]
Grant Ingersoll commented on SOLR-647:
--
Quick glance suggests it needs unit tests.
> Do
[
https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620441#action_12620441
]
Henri Biestro commented on SOLR-647:
Will do (tomorrow); might be the opportunity to alig
[
https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621597#action_12621597
]
Grant Ingersoll commented on SOLR-647:
--
This doesn't compile. The TimeUnit.MINUTES in S
[
https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621598#action_12621598
]
Grant Ingersoll commented on SOLR-647:
--
But, I changed it to awaitTermination(60, TimeUn
[
https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621602#action_12621602
]
Henri Biestro commented on SOLR-647:
Sorry & thanks Grant.
> Do SolrCore.close() in a re
[
https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621812#action_12621812
]
Grant Ingersoll commented on SOLR-647:
--
I'd like to see some more documentation on this.
[
https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621817#action_12621817
]
Noble Paul commented on SOLR-647:
-
bq.How does CoreDescriptor.reloadCore factor in? I don't s
[
https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621837#action_12621837
]
Henri Biestro commented on SOLR-647:
Grant;
getCore() does not protect the core from bei
[
https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621849#action_12621849
]
Grant Ingersoll commented on SOLR-647:
--
{quote}
How else can I reload the core in a sing
[
https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621853#action_12621853
]
Grant Ingersoll commented on SOLR-647:
--
Henri,
At a minimum, all that should be documen
[
https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621867#action_12621867
]
Henri Biestro commented on SOLR-647:
Grant,
bq.At a minimum, all that should be document
[
https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621909#action_12621909
]
Noble Paul commented on SOLR-647:
-
This patch is very clear as to what it is doing (and simpl
[
https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621918#action_12621918
]
Henri Biestro commented on SOLR-647:
My apologies to all for cluttering the issue.
> Do
[
https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622575#action_12622575
]
Noble Paul commented on SOLR-647:
-
I fail to see the need for this code in SolrCore#close()
{
[
https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622583#action_12622583
]
Henri Biestro commented on SOLR-647:
About the SolrCore.open() & close():
If we were to d
[
https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622586#action_12622586
]
Yonik Seeley commented on SOLR-647:
---
bq. he close could use a decrementAndGet() but the cur
[
https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622592#action_12622592
]
Henri Biestro commented on SOLR-647:
Yonik;
About the close(), you're right: the refcount
[
https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622613#action_12622613
]
Yonik Seeley commented on SOLR-647:
---
bq. Are you in agreement about open()?
Yes, if cores
[
https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622614#action_12622614
]
Noble Paul commented on SOLR-647:
-
bq.About the close(), you're right: the refcount < 0 being
[
https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622618#action_12622618
]
Yonik Seeley commented on SOLR-647:
---
bq. refcount < 0 is an error . but should it throw an
[
https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622628#action_12622628
]
Otis Gospodnetic commented on SOLR-647:
---
bq. Right... on one hand an exception brings m
[
https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622632#action_12622632
]
Noble Paul commented on SOLR-647:
-
The CoreContainer#create(CoreDescriptor dcore) must close
[
https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623000#action_12623000
]
Yonik Seeley commented on SOLR-647:
---
I'm thinking of changing the cores map to (from
)
an
[
https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623001#action_12623001
]
Yonik Seeley commented on SOLR-647:
---
Also, is there any reason not to allow the same core t
[
https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623003#action_12623003
]
Ryan McKinley commented on SOLR-647:
bq. I'm thinking of changing the cores map to (from
[
https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623007#action_12623007
]
Yonik Seeley commented on SOLR-647:
---
FYI, I'm also overhauling some of the synchronization.
[
https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623019#action_12623019
]
Yonik Seeley commented on SOLR-647:
---
Also, persistFile looks like it would take enough time
[
https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623173#action_12623173
]
Ryan McKinley commented on SOLR-647:
bq. I was going to remove the SolrCore name altogeth
[
https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623201#action_12623201
]
Noble Paul commented on SOLR-647:
-
bq. Also, is there any reason not to allow the same core t
[
https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623204#action_12623204
]
Henri Biestro commented on SOLR-647:
Small err that would affect reload() in CoreContai
[
https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623379#action_12623379
]
Yonik Seeley commented on SOLR-647:
---
bq. How will SolrCore#getCoreDescriptor() work. what w
OK, I'll buy that, maybe I just don't get Multicore/Single Core
relationship. Also, reload is not used anywhere and we've never had
the notion of reloading in the single core case, AFAICT.
-Grant
On Aug 12, 2008, at 9:48 AM, Noble Paul (JIRA) wrote:
[ https://issues.apache.org/jira/br
It is needed for SOLR-561 (core reload for config replication)
On Tue, Aug 12, 2008 at 8:01 PM, Grant Ingersoll <[EMAIL PROTECTED]>wrote:
> OK, I'll buy that, maybe I just don't get Multicore/Single Core
> relationship. Also, reload is not used anywhere and we've never had the
> notion of reload
Then it should be part of that patch, not this one. But, I still
don't think it belongs in CoreDescriptor.
On Aug 12, 2008, at 10:36 AM, Shalin Shekhar Mangar wrote:
It is needed for SOLR-561 (core reload for config replication)
On Tue, Aug 12, 2008 at 8:01 PM, Grant Ingersoll
<[EMAIL PRO
37 matches
Mail list logo
