[ 
https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621853#action_12621853
 ] 

Grant Ingersoll commented on SOLR-647:
--------------------------------------

Henri,

At a minimum, all that should be documented, but I must admit to still being 
confused (but I'm no expert in the multicore stuff so, please bear with me)

{quote}
getCore() does not protect the core from being closed by another thread (it 
must either be protected by another mean or earlier or it does not matter).
{quote}

Yes, but there appears to be mixed uses, the MultiCoreHandler uses getCore() in 
places, while the SolrDispatchFilter uses the Reference.  Isn't it possible for 
the core to then be closed behind the MultiCoreHandler?

> Do SolrCore.close() in a refcounted way
> ---------------------------------------
>
>                 Key: SOLR-647
>                 URL: https://issues.apache.org/jira/browse/SOLR-647
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 1.3
>            Reporter: Noble Paul
>            Assignee: Grant Ingersoll
>             Fix For: 1.3
>
>         Attachments: solr-647.patch, solr-647.patch, solr-647.patch, 
> solr-647.patch, solr-647.patch, SOLR-647.patch, SOLR-647.patch
>
>
> The method _SolrCore.close()_ directly closes the core . It can cause 
> Exceptions for in-flight requests. The _close()_ method should just do a 
> decrement on refcount and the actual close must happen when the last request 
> being processed by that core instance is completed

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to