[jira] Commented: (SOLR-885) Generify NamedListCodec

2008-12-19 Thread Shalin Shekhar Mangar (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12658084#action_12658084 ] Shalin Shekhar Mangar commented on SOLR-885: Committed revision 728017. I'll giv

[jira] Commented: (SOLR-885) Generify NamedListCodec

2008-12-18 Thread Noble Paul (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12657999#action_12657999 ] Noble Paul commented on SOLR-885: - bq.Of course, I was never quite sure why it was "javabin"

[jira] Commented: (SOLR-885) Generify NamedListCodec

2008-12-18 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12657903#action_12657903 ] Yonik Seeley commented on SOLR-885: --- bq. But renaming the class to JavabinCodec makes sense

[jira] Commented: (SOLR-885) Generify NamedListCodec

2008-12-17 Thread Noble Paul (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12657691#action_12657691 ] Noble Paul commented on SOLR-885: - bq.So instead of this big patch, simply change the signatu

[jira] Commented: (SOLR-885) Generify NamedListCodec

2008-12-17 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12657681#action_12657681 ] Yonik Seeley commented on SOLR-885: --- bq. NamedListCodec dictates the root Object to be a Na

[jira] Commented: (SOLR-885) Generify NamedListCodec

2008-12-17 Thread Noble Paul (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12657667#action_12657667 ] Noble Paul commented on SOLR-885: - NamedListCodec dictates the root Object to be a NamedList

[jira] Commented: (SOLR-885) Generify NamedListCodec

2008-12-17 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12657487#action_12657487 ] Yonik Seeley commented on SOLR-885: --- What is gained by making NamedListCodec a generic? >

[jira] Commented: (SOLR-885) Generify NamedListCodec

2008-12-17 Thread Noble Paul (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12657384#action_12657384 ] Noble Paul commented on SOLR-885: - My second last patch and the latest patch has only this on

[jira] Commented: (SOLR-885) Generify NamedListCodec

2008-12-17 Thread Shalin Shekhar Mangar (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12657383#action_12657383 ] Shalin Shekhar Mangar commented on SOLR-885: This looks good Noble. Let us do the

[jira] Commented: (SOLR-885) Generify NamedListCodec

2008-12-09 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654840#action_12654840 ] Yonik Seeley commented on SOLR-885: --- Noble, did you attach the latest patch? > Generify Na

[jira] Commented: (SOLR-885) Generify NamedListCodec

2008-12-09 Thread Shalin Shekhar Mangar (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654745#action_12654745 ] Shalin Shekhar Mangar commented on SOLR-885: I think we can make this one change.

[jira] Commented: (SOLR-885) Generify NamedListCodec

2008-12-03 Thread Noble Paul (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12653177#action_12653177 ] Noble Paul commented on SOLR-885: - OK. let us not make the change and stick to the original d

[jira] Commented: (SOLR-885) Generify NamedListCodec

2008-11-29 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12651743#action_12651743 ] Yonik Seeley commented on SOLR-885: --- bq. I do not see any difference between NamedList and

[jira] Commented: (SOLR-885) Generify NamedListCodec

2008-11-29 Thread Noble Paul (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12651740#action_12651740 ] Noble Paul commented on SOLR-885: - bq.by default we used a syntax that keeps order. But that

[jira] Commented: (SOLR-885) Generify NamedListCodec

2008-11-28 Thread Ryan McKinley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12651678#action_12651678 ] Ryan McKinley commented on SOLR-885: bq. But , before javabin we used to use xml which ha

[jira] Commented: (SOLR-885) Generify NamedListCodec

2008-11-27 Thread Noble Paul (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12651470#action_12651470 ] Noble Paul commented on SOLR-885: - Patch w/o deprecating NamedList . But , before javabin w

[jira] Commented: (SOLR-885) Generify NamedListCodec

2008-11-27 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12651368#action_12651368 ] Yonik Seeley commented on SOLR-885: --- NamedList and SimpleOrderedMap have different semantic